Page MenuHomePhabricator
Create Task
Maniphest T224013

Implement Shortend version
Closed, ResolvedPublic
Actions

Description

NOTE: check parent task for conditions on when to apply this version

Template:
Changed labels, descriptions and/or aliases in: <all language codes that changed >

Example:
Changed labels, descriptions and/or aliases in: fr, es, en, pl, zh, it, hu

Notes:

  • comma-separated list should be i18n-ed (i.e. not hardcode English comma + space, etc)

TODO

Details

SubjectRepoBranchLines +/-
Generate Short edit summariesmediawiki/extensions/Wikibasemaster+101 -21
Add messages for short version of automatic summarymediawiki/extensions/Wikibasemaster+4 -0
Don't use PHP classes to refer to constants in magic.php filesmediawiki/extensions/Wikibasemaster+2 -6
Add commaSeparatedList parser functionmediawiki/extensions/Wikibasemaster+100 -1
Add service to collect changed languages, for the summary messagemediawiki/extensions/Wikibasemaster+114 -22
WIP: Add service to collect changed languages, grouped by changed term typesmediawiki/extensions/Wikibasemaster+182 -0
Move Summary prepartion into its own helper classmediawiki/extensions/Wikibasemaster+138 -33
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT220696 [Story] Create better edit summaries for wbeditentity API endpoint
ResolvedRosalie_WMDET224013 Implement Shortend version
Resolved• alaa_wmdeT239522 Fix short edit summary message and add missing messages
· · ·

Event Timeline

• alaa_wmde created this task.May 21 2019, 1:33 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 21 2019, 1:33 PM
Pintoch subscribed.Oct 9 2019, 12:17 PM
• alaa_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Oct 16 2019, 7:35 PM
• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Oct 16 2019, 9:10 PM

Change 543701 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Move Summary prepartion into its own helper class

https://gerrit.wikimedia.org/r/543701

gerritbot added a project: Patch-For-Review.Oct 16 2019, 9:10 PM
• alaa_wmde moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 16 2019, 9:12 PM

First patch (& first step of isolating summary generation logic) is up for review

• alaa_wmde triaged this task as High priority.Oct 17 2019, 11:02 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:38 PM
• alaa_wmde moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 21 2019, 10:19 AM
• alaa_wmde updated the task description. (Show Details)Oct 21 2019, 10:57 AM
gerritbot added a comment.Oct 21 2019, 12:55 PM

Change 544897 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] WIP: Add service to collect changed languages, grouped by changed term types

https://gerrit.wikimedia.org/r/544897

• alaa_wmde claimed this task.Oct 22 2019, 8:50 AM
• alaa_wmde added a comment.Oct 23 2019, 10:20 AM

The current version of the message have too many dynamic (moving) parts. The languages list is of unknown length to the message in json files, and the amount of grouped changed (Changed in ... ) can be of any length between 1 and 6 (for all possible combinations of aliases, label and description).

An alternative to reduce complexity of dynamic message parts Changed labels, descriptions and/or aliases in: fr, es, en, pl zh, it, hu.

This makes this version exactly the same as the fallback version, but with the number of changed languages being replaced by the list of them.

We will still need to figure out a way to allow for dynamic length list of languages to be encoded in the summary, and to be translated by the target language using its proper separation scheme.

gerritbot added a comment.Oct 23 2019, 10:42 AM

Change 543701 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move Summary prepartion into its own helper class

https://gerrit.wikimedia.org/r/543701

• alaa_wmde moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 23 2019, 11:50 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 23 2019, 4:00 PM
• alaa_wmde moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 30 2019, 11:16 AM

After talking to @Lydia_Pintscher , we decided to go with a simpler version of the shortend version as suggested in the last comment. Task and parent Task descriptions will updated accordingly.

• alaa_wmde updated the task description. (Show Details)Oct 30 2019, 11:18 AM
• alaa_wmde moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 30 2019, 12:48 PM
• alaa_wmde moved this task from Wikidata-Campsite-Iteration-∞ (On Hold) to Ready to pick up on the Wikidata-Campsite board.Oct 30 2019, 1:31 PM
• alaa_wmde edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Rosalie_WMDE moved this task to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Nov 6 2019, 1:38 PM
Rosalie_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Rosalie_WMDE subscribed.Nov 6 2019, 2:50 PM
gerritbot added a comment.Nov 7 2019, 7:24 AM

Change 544897 abandoned by Alaa Sarhan:
WIP: Add service to collect changed languages, grouped by changed term types

Reason:
Feature changed and this no longer needed. See task

https://gerrit.wikimedia.org/r/544897

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2019, 8:10 AM
Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 7 2019, 9:58 AM
• alaa_wmde removed • alaa_wmde as the assignee of this task.Nov 7 2019, 10:32 AM
WMDE-leszek updated the task description. (Show Details)Nov 8 2019, 1:10 PM
Jakob_WMDE mentioned this in T220696: [Story] Create better edit summaries for wbeditentity API endpoint.Nov 11 2019, 1:27 PM
Rosalie_WMDE updated the task description. (Show Details)Nov 15 2019, 10:44 AM
Rosalie_WMDE updated the task description. (Show Details)Nov 15 2019, 10:52 AM
Jakob_WMDE updated the task description. (Show Details)Nov 15 2019, 10:56 AM
Jakob_WMDE updated the task description. (Show Details)Nov 15 2019, 10:58 AM
Jakob_WMDE updated the task description. (Show Details)Nov 15 2019, 11:20 AM
gerritbot added a comment.Nov 15 2019, 12:51 PM

Change 551166 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Add commaSeparatedList parser function

https://gerrit.wikimedia.org/r/551166

gerritbot added a project: Patch-For-Review.Nov 15 2019, 12:51 PM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 19 2019, 9:28 AM
gerritbot added a comment.Nov 19 2019, 9:40 AM

Change 551780 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Add service to collect changed languages, for the summary message

https://gerrit.wikimedia.org/r/551780

Rosalie_WMDE updated the task description. (Show Details)Nov 19 2019, 12:33 PM
darthmon_wmde assigned this task to Rosalie_WMDE.Nov 20 2019, 2:12 PM
Rosalie_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 21 2019, 8:51 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 22 2019, 9:44 AM
gerritbot added a comment.Nov 22 2019, 3:02 PM

Change 552522 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Add messages for short version of automatic summary

https://gerrit.wikimedia.org/r/552522

gerritbot added a comment.Nov 22 2019, 3:18 PM

Change 551780 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add service to collect changed languages, for the summary message

https://gerrit.wikimedia.org/r/551780

Rosalie_WMDE updated the task description. (Show Details)Nov 22 2019, 3:21 PM
Rosalie_WMDE updated the task description. (Show Details)
Rosalie_WMDE updated the task description. (Show Details)
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.8; 2019-11-26); removed MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Nov 22 2019, 4:00 PM
Rosalie_WMDE updated the task description. (Show Details)Nov 22 2019, 4:42 PM
Rosalie_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 25 2019, 10:16 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 26 2019, 8:52 AM
gerritbot added a comment.Nov 26 2019, 5:00 PM

Change 553148 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Generate Short edit summaries

https://gerrit.wikimedia.org/r/553148

Rosalie_WMDE updated the task description. (Show Details)Nov 26 2019, 5:01 PM
Rosalie_WMDE updated the task description. (Show Details)Nov 26 2019, 5:04 PM
gerritbot added a comment.Nov 27 2019, 6:09 PM

Change 551166 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add commaSeparatedList parser function

https://gerrit.wikimedia.org/r/551166

gerritbot added a comment.Nov 27 2019, 6:09 PM

Change 552522 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add messages for short version of automatic summary

https://gerrit.wikimedia.org/r/552522

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 27 2019, 7:00 PM
Rosalie_WMDE updated the task description. (Show Details)Nov 27 2019, 7:02 PM
Rosalie_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 28 2019, 11:00 AM
Reedy mentioned this in T239425: 8127a1eb9c492a45810ca34896d8b4ce9382e70f broke beta.Nov 28 2019, 3:36 PM
gerritbot added a comment.Nov 28 2019, 3:38 PM

Change 553493 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Wikibase@master] Don't use PHP classes to refer to constants in magic.php files

https://gerrit.wikimedia.org/r/553493

gerritbot added a comment.Nov 28 2019, 4:17 PM

Change 553493 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don't use PHP classes to refer to constants in magic.php files

https://gerrit.wikimedia.org/r/553493

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 29 2019, 11:30 AM
• alaa_wmde mentioned this in T239522: Fix short edit summary message and add missing messages.Nov 30 2019, 9:12 PM
• alaa_wmde added a subtask: T239522: Fix short edit summary message and add missing messages.
Rosalie_WMDE updated the task description. (Show Details)Dec 2 2019, 9:25 AM
WMDE-leszek updated the task description. (Show Details)Dec 2 2019, 11:39 AM
gerritbot added a comment.Dec 2 2019, 11:42 AM

Change 553148 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Generate Short edit summaries

https://gerrit.wikimedia.org/r/553148

Rosalie_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 2 2019, 11:42 AM
Rosalie_WMDE updated the task description. (Show Details)
Rosalie_WMDE added a comment.Dec 3 2019, 9:22 AM

Documented {{#commaseparatedlist}} on https://www.mediawiki.org/wiki/Wikibase/Installation/Advanced_configuration#Data_transclusion

docs.png (312×1 px, 44 KB)

Jakob_WMDE subscribed.Dec 3 2019, 9:39 AM

I made two edits here - one showing the new shortened version, and another one demonstrating that it falls back to the fallback version when the edit changes terms in over 50 languages.

Rosalie_WMDE updated the task description. (Show Details)Dec 3 2019, 11:36 AM
Addshore closed subtask T239522: Fix short edit summary message and add missing messages as Resolved.Dec 3 2019, 1:50 PM
Addshore moved this task from Test (Verification) to Needs Announcement on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 3 2019, 1:55 PM
Addshore added subscribers: Lea_Lacroix_WMDE, Addshore.

Verified on board cleanup on beta :)

Moving to needs announcement for @Lea_Lacroix_WMDE

Lea_Lacroix_WMDE moved this task from Needs Announcement to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 3 2019, 4:48 PM

Announcement done here, indicating a deployment this week, no veto so far, for me everything is good to go!

Addshore closed this task as Resolved.Jan 14 2020, 10:48 AM

I think this is all resolved then!

LucasWerkmeister mentioned this in T200814: Use language names instead of language codes in edit summaries.Apr 14 2021, 11:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL