Page MenuHomePhabricator
Create Task
Maniphest T224487

Make RESTBase take full request template for Parsoid requests
Closed, ResolvedPublic
Actions

Description

We need to be able to configure the whole request from RESTBase to Parsoid in order to provide a Host header when Parsoid API would live in Mediawiki. In order to achieve that we need to provide a full request template in the configuration instead of just the parsoid host.

Related Objects
Search...

Event Timeline

• Pchelolo created this task.May 28 2019, 3:28 PM
• mobrovac added a comment.May 28 2019, 3:45 PM

We can also just add the header, since it is ignored by Parsoid/JS any way

• Pchelolo added a comment.May 29 2019, 5:01 AM

Yes, but the paths are probably gonna be different as well..

CCicalese_WMF triaged this task as Medium priority.Jun 4 2019, 1:00 PM
CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Platform Team Legacy.
• Pchelolo edited projects, added Platform Engineering (Parsoid REST API in PHP (CDP2)); removed Platform Team Legacy (Designing), Platform Engineering (RESTBase Split (CDP2)), Services (next).Jul 16 2019, 7:16 PM
WDoranWMF moved this task from Parsoid REST API in PHP (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 7:03 PM
WDoranWMF edited projects, added Platform Team Initiatives (Parsoid REST API in PHP (CDP2)); removed Platform Engineering (Parsoid REST API in PHP (CDP2)).
• eprodromou closed this task as Resolved.Nov 6 2019, 6:13 PM
• eprodromou subscribed.

I guess this is working if Parsoid/PHP is in production.

Tgr added a comment.Nov 10 2019, 10:01 PM

I thought Parsoid/PHP is not using RESTBase?

Anomie added a comment.Nov 12 2019, 8:42 PM

IIRC, the current stage is to have Parsoid/PHP implement the same internal endpoints that are implemented by Parsoid/JS so it can be tested as a drop-in replacement. As Parsoid/JS is currently "behind" RESTBase, Parsoid/PHP will be too.

Once we've gotten Parsoid/PHP to the point where we can end the parallel maintenance of Parsoid/JS, we can start changing things further.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL