Page MenuHomePhabricator
Create Task
Maniphest T225718

Add TypeIdsLookup and implement it in DatabaseTypeIdsStore
Closed, ResolvedPublic
Actions

Description

Came from T225003#5256414

The interface responsibility is to inverse lookup type names into ids, skipping types that do not exist in the storage

Details

SubjectRepoBranchLines +/-
Implement TypeIdsLookup in {Static,InMemory}TypeIdsStoremediawiki/extensions/Wikibasemaster+20 -2
Add TypeIdsLookup interface and implement it in DatabaseTypeIdsStore.mediawiki/extensions/Wikibasemaster+51 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alaa_wmde created this task.Jun 13 2019, 11:49 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 13 2019, 11:49 AM
• alaa_wmde removed hoo as the assignee of this task.Jun 13 2019, 11:49 AM
• alaa_wmde removed a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).
• alaa_wmde moved this task from Backlog to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.
• alaa_wmde added a subscriber: hoo.
• alaa_wmde renamed this task from Add TypeIdsLookup and implement DatabaseTypeIdsLookup to Add TypeIdsLookup and implement it in DatabaseTypeIdsStore.Jun 13 2019, 11:53 AM
• alaa_wmde claimed this task.
• alaa_wmde updated the task description. (Show Details)
• alaa_wmde moved this task from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
gerritbot added a comment.Jun 13 2019, 1:12 PM

Change 516769 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/Wikibase@master] Add TypeIdsLookup interface and implement it in DatabaseTypeIdsStore.

https://gerrit.wikimedia.org/r/516769

gerritbot added a project: Patch-For-Review.Jun 13 2019, 1:12 PM
• alaa_wmde moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.Jun 13 2019, 1:12 PM
hoo moved this task from In Review to Done on the Wikidata wb_terms Trailblazing board.Jun 14 2019, 9:26 AM
gerritbot added a comment.Jun 14 2019, 2:10 PM

Change 516769 abandoned by Alaa Sarhan:
Add TypeIdsLookup interface and implement it in DatabaseTypeIdsStore.

Reason:
Now contained in 516661

https://gerrit.wikimedia.org/r/516769

gerritbot added a comment.Jun 14 2019, 2:29 PM

Change 516769 restored by Alaa Sarhan:
Add TypeIdsLookup interface and implement it in DatabaseTypeIdsStore.

https://gerrit.wikimedia.org/r/516769

gerritbot added a comment.Jun 14 2019, 3:59 PM

Change 517086 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Implement TypeIdsLookup in {Static,InMemory}TypeIdsStore

https://gerrit.wikimedia.org/r/517086

gerritbot added a comment.Jun 18 2019, 11:51 AM

Change 516769 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add TypeIdsLookup interface and implement it in DatabaseTypeIdsStore.

https://gerrit.wikimedia.org/r/516769

gerritbot added a comment.Jun 18 2019, 11:51 AM

Change 517086 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Implement TypeIdsLookup in {Static,InMemory}TypeIdsStore

https://gerrit.wikimedia.org/r/517086

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 18 2019, 1:00 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM
Aklapper removed a project: Patch-For-Review.Dec 16 2019, 9:17 AM
Aklapper added a subscriber: Addshore.

@Addshore: Patch merged. Do you know if there is more to do in this task, or can this task be closed as resolved?

Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Dec 16 2019, 12:08 PM
Addshore moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore closed this task as Resolved.Dec 23 2019, 1:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL