"Add a caption" is broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matthiasmullie
	Jul 11 2019, 4:31 PM

Description

The "add a caption" button in the captions panel is currently broken on beta/local.
It doesn't add a captions row, but instead shows this error in console:

Uncaught TypeError: Cannot read property 'filter' of undefined
    at CaptionsPanel.createIndexedEditableRow (load.php?lang=en&modules=ext.uls.common%2Ccompactlinks%2Cinterface|jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows|jquery.uls|mediawiki.ui.button%2Cicon|mmv.bootstrap|oojs-ui-core.styles|wikibase.mediainfo.filePageDisplay%2Cstatements&skin=vector&version=18qbuys:559)
    at CaptionsPanel.addNewEditableLanguageRow (load.php?lang=en&modules=ext.uls.common%2Ccompactlinks%2Cinterface|jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows|jquery.uls|mediawiki.ui.button%2Cicon|mmv.bootstrap|oojs-ui-core.styles|wikibase.mediainfo.filePageDisplay%2Cstatements&skin=vector&version=18qbuys:569)
    at load.php?lang=en&modules=ext.uls.common%2Ccompactlinks%2Cinterface|jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows|jquery.uls|mediawiki.ui.button%2Cicon|mmv.bootstrap|oojs-ui-core.styles|wikibase.mediainfo.filePageDisplay%2Cstatements&skin=vector&version=18qbuys:549
    at OoUiButtonWidget.oo.EventEmitter.emit (<anonymous>:274:486)
    at OoUiButtonWidget.OO.ui.mixin.ButtonElement.onClick (load.php?lang=en&modules=ext.uls.common%2Ccompactlinks%2Cinterface|jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows|jquery.uls|mediawiki.ui.button%2Cicon|mmv.bootstrap|oojs-ui-core.styles|wikibase.mediainfo.filePageDisplay%2Cstatements&skin=vector&version=18qbuys:203)
    at HTMLAnchorElement.dispatch (load.php?lang=en&modules=ext.uls.common%2Ccompactlinks%2Cinterface|jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows|jquery.uls|mediawiki.ui.button%2Cicon|mmv.bootstrap|oojs-ui-core.styles|wikibase.mediainfo.filePageDisplay%2Cstatements&skin=vector&version=18qbuys:94)
    at HTMLAnchorElement.elemData.handle (load.php?lang=en&modules=ext.uls.common%2Ccompactlinks%2Cinterface|jquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows|jquery.uls|mediawiki.ui.button%2Cicon|mmv.bootstrap|oojs-ui-core.styles|wikibase.mediainfo.filePageDisplay%2Cstatements&skin=vector&version=18qbuys:90)

Acceptance criteria:

On https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_08-02-2019_at_16.35.jpg

When captions panel is in edit mode:

"Add a caption" should add a captions row (without errors in console)

QA Results

AC	Status	Details
1	✅	T227798#5347889

Details

	Subject	Repo	Branch	Lines +/-
	Better guard against missing data	mediawiki/extensions/WikibaseMediaInfo	master	+8 -4

Customize query in gerrit

Event Timeline

matthiasmullie created this task.Jul 11 2019, 4:31 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptJul 11 2019, 4:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Train blocker?

Oooh. Sweet regression :) Let's fix it quickly.

Change 522431 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Better guard against missing data

https://gerrit.wikimedia.org/r/522431

gerritbot added a project: Patch-For-Review.Jul 12 2019, 12:09 PM

matthiasmullie claimed this task.Jul 12 2019, 12:09 PM

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.

Change 522431 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Better guard against missing data

https://gerrit.wikimedia.org/r/522431

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 12 2019, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 4:10 PM

matthiasmullie reassigned this task from matthiasmullie to Edtadros.Jul 15 2019, 4:05 PM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.

Nicolas_Raoul awarded a token.Jul 16 2019, 11:28 AM

I stumbled upon this bug on commons.wikimedia.org right now.
I can confirm the bug is fixed on commons.wikimedia.beta.wmflabs.org thanks, looking forward to the release.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

QA Steps

On https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_08-02-2019_at_16.35.jpg
AC1: When captions panel is in edit mode: "Add a caption" should add a captions row (without errors in console)

Screen Shot 2019-07-18 at 2.04.24 PM.png (946×1 px, 211 KB)

Edtadros updated the task description. (Show Details)Jul 18 2019, 9:07 PM

• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.Jul 29 2019, 4:26 PM

Tested on production. Working fine in Chrome and Firefox.

	F29803428: Screen Shot 2019-07-18 at 2.04.24 PM.png
	Jul 18 2019, 9:06 PM

"Add a caption" is brokenClosed, ResolvedPublicActions