According to a conversation @Dzahn and myself held at -releng yesterday related to https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/528730 we've detected that foreachwiki and foreachwikiindblist does force RUNNER=php so it somewhat moots the point of T195392.
I couldn't find much for foreachwiki but foreachwikiindblist does indeed use RUNNER=php on its code: https://github.com/wikimedia/puppet/blob/production/modules/scap/files/foreachwikiindblist
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| switch RUNNER in foreachwikiindblist back to just 'php' | operations/puppet | production | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T176370 Migrate to PHP 7 in WMF production | |||
| Resolved | jijiki | T219127 SRE FY19-20 Q1 goal: complete the transition to PHP7 | |||
| Resolved | None | T195392 Switch cronjobs on maintenance hosts to PHP7 | |||
| Resolved | Dzahn | T230110 Stop forcing RUNNER=php for foreachwiki/foreachwikiindblist |
Here is where i switched that to php7.2 to ensure all crons using foreachwikiindblist are actually using 7.2 and we don't just think it does. (cc: @jijiki )
https://gerrit.wikimedia.org/r/c/operations/puppet/+/528613
@MarcoAurelio Yes, it is in foreachwikiindblist and not in foreachwiki but foreachwiki uses foreachwikiindblist.
also see https://gerrit.wikimedia.org/r/c/operations/puppet/+/425027 though which might or might not make this obsolete
This is done as of https://gerrit.wikimedia.org/r/c/operations/puppet/+/425027 on 12 August, right?
Kind of, yea. But also we should revert setting it to php7.2 now to avoid hardcoding the version.
Change 534012 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] switch RUNNER in foreachwikiindblist back to just 'php'
Change 534012 merged by Dzahn:
[operations/puppet@production] switch RUNNER in foreachwikiindblist back to just 'php'
@DannyS712 I don't think we should even add "Patch-For-Review" in the first place, i am not aware of a single time getting a review because of that tag.
With the recent Phabricator plugin that lists pending patches bearing the Bug: Txxxx header on the very task, I'm not sure about the usefulness of that tag as of now other than being able to quickly see that a Task has a patch for review from a Workboard of Phabricator query (which is useful). But this is probably a discussion for Project-Admins / Phabricator.