Page MenuHomePhabricator
Create Task
Maniphest T230333

Impact Module: number of pageviews in mobile impact preview should be abbreviated
Closed, ResolvedPublic
Actions

Assigned To
Tgr
Authored By
• Cntlsn
Aug 12 2019, 11:37 AM
Tags
Referenced Files
F35824791: Screenshot_20221129-160810_Chrome.jpg
Nov 30 2022, 2:32 AM
F30008198: Screenshot 2019-08-12 13.27.12.png
Aug 12 2019, 11:37 AM
F30008207: Screenshot 2019-08-12 13.32.23.png
Aug 12 2019, 11:37 AM
Subscribers
Aklapper
Catrope
• Cntlsn
DMburugu
Etonkovidova
JTannerWMF
kostajh
View All 15 Subscribers
Tokens
"Party Time" token, awarded by RHo.

Description

The Impact module preview, featured in the mobile Newcomer homepage, serves as a gateway to invite users to discover about the details of the impact of their edits in the first place, and then as a quick access to their impact when user gathered familiarity with the tool.

To that extent, the preview card features the total number of pageviews (to articles edited by the user) in a bigger font-size.
With the current implementation of the layout, the UI looks unbalanced on smaller screens when the number of pageviews grows substantially, shrinking the first column and decreasing text legibility:

Screenshot 2019-08-12 13.27.12.png (480×640 px, 43 KB)

I propose to abbreviate numbers (according to international standards -- http://cldr.unicode.org/translation/number-patterns#TOC-Short-Numbers), for numbers bigger than 999:

Screenshot 2019-08-12 13.32.23.png (452×640 px, 39 KB)

A similar issue was discussed previously at T216217#5014975, the conversation might contain useful technical insights.

Details

SubjectRepoBranchLines +/-
Abbreviate pageview count in new impact module mobile summarymediawiki/extensions/GrowthExperimentsmaster+18 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Cntlsn created this task.Aug 12 2019, 11:37 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 12 2019, 11:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Cntlsn renamed this task from Homepage: number in mobile impact preview should be abbreviated to Homepage: number of pageviews in mobile impact preview should be abbreviated.Aug 12 2019, 11:38 AM
• Cntlsn mentioned this in T227104: Homepage: number in mobile impact preview doesn't look aligned in Czech version.
• Cntlsn added a parent task: T215983: Homepage: mobile version.
phuedx moved this task from Needs triage to Growth on the Mobile board.Aug 15 2019, 11:11 AM
kostajh moved this task from Inbox to Q2 2019-20 on the Growth-Team board.Aug 16 2019, 3:00 PM

Moving to Q2 but @MMiller_WMF feel free to move to Q1 if this is more important to do sooner.

Aklapper removed a project: GrowthExperiments.Sep 11 2019, 12:46 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
MMiller_WMF edited parent tasks, added: T222310: [EPIC] Positive reinforcement: New Impact Module; removed: T215983: Homepage: mobile version.Jun 30 2021, 10:54 PM
Sgs subscribed.Jun 15 2022, 8:24 PM
Sgs added a comment.Jul 8 2022, 11:29 AM

I belive using Intl.NumberFormat could be a good option to leverage the locale negotiation and comply to international standards. The rounding it does also seems convenient for our case. These are some examples:

Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(1000);
'1K'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(25318);
'25.3K'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(124872);
'124.9K'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(1248720);
'1.2M'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(1248720000);
'1.2B'
Intl.NumberFormat('es', { notation: "compact", maximumFractionDigits: 1 }).format(2500);
'2,5 mil'
Intl.NumberFormat('hi', { notation: "compact", maximumFractionDigits: 1 }).format(2500);
'2.5 हज़ार'
Intl.NumberFormat('de', { notation: "compact", maximumFractionDigits: 1 }).format(2500);
'2500'
Intl.NumberFormat('de', { notation: "compact", maximumFractionDigits: 1 }).format(25000);
'25.000'
Intl.NumberFormat('de', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'2,5 Mio.'
Intl.NumberFormat('pt', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'2,5 mi'
Intl.NumberFormat('pt-BR', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'2,5 mi'
KStoller-WMF renamed this task from Homepage: number of pageviews in mobile impact preview should be abbreviated to Impact Module: number of pageviews in mobile impact preview should be abbreviated.Jul 18 2022, 11:20 PM
kostajh added a comment.Jul 19 2022, 4:27 PM
In T230333#8065018, @Sgs wrote:

I belive using Intl.NumberFormat could be a good option to leverage the locale negotiation and comply to international standards. The rounding it does also seems convenient for our case. These are some examples:

Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(1000);
'1K'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(25318);
'25.3K'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(124872);
'124.9K'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(1248720);
'1.2M'
Intl.NumberFormat('en', { notation: "compact", maximumFractionDigits: 1 }).format(1248720000);
'1.2B'
Intl.NumberFormat('es', { notation: "compact", maximumFractionDigits: 1 }).format(2500);
'2,5 mil'
Intl.NumberFormat('hi', { notation: "compact", maximumFractionDigits: 1 }).format(2500);
'2.5 हज़ार'
Intl.NumberFormat('de', { notation: "compact", maximumFractionDigits: 1 }).format(2500);
'2500'
Intl.NumberFormat('de', { notation: "compact", maximumFractionDigits: 1 }).format(25000);
'25.000'
Intl.NumberFormat('de', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'2,5 Mio.'
Intl.NumberFormat('pt', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'2,5 mi'
Intl.NumberFormat('pt-BR', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'2,5 mi'

That sounds good to me, but let's ask around (to Language-Team especially) if there are any concerns with doing that, as I see only one minor usage in a WMF deployed extension.

kostajh removed a project: Growth-Team-Filtering.Jul 19 2022, 4:28 PM
DMburugu subscribed.Aug 3 2022, 12:03 PM

@Sgs: Just saw that IE 11 doesn't support this API: Intl.NumberFormat. Will that be something to worry about incase we decide to adopt the shortening?

Sgs added a comment.Aug 4 2022, 3:22 PM
In T230333#8127673, @DMburugu wrote:

@Sgs: Just saw that IE 11 doesn't support this API: Intl.NumberFormat. Will that be something to worry about incase we decide to adopt the shortening?

The new impact module is gonna be built with Vue 3 which neither supports IE11 so not something to worry for adoption. I think what we need to test before giving it an ok is the locale negotiation. We should make sure it works for all the languages wiki projects support and does appropriate fallback.

kostajh added a project: GrowthExperiments-ImpactModule.Oct 17 2022, 9:27 AM
KStoller-WMF edited parent tasks, added: T316699: [EPIC] Growth: Positive reinforcement - Iteration 2; removed: T222310: [EPIC] Positive reinforcement: New Impact Module.Oct 21 2022, 10:37 PM
MShilova_WMF mentioned this in T222310: [EPIC] Positive reinforcement: New Impact Module.Nov 22 2022, 5:26 PM
Tgr subscribed.Nov 23 2022, 8:32 PM

We did a variant of this in SuggestedEdits::formatSiteViews() but in a somewhat shoddy way (see T236641: Create Language method for human-readable numbers). At a glance Intl does a better job, e.g. it's not bound to 10^3 powers like our code:

Intl.NumberFormat('es', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'2,5 M'
Intl.NumberFormat('hi', { notation: "compact", maximumFractionDigits: 1 }).format(2500000);
'25 लाख'

If it were something supported in MediaWiki core, I would ask whether we are supporting more languages than browsers, as MediaWiki usually beats other software in breadth of language support, but we ended up defining our own messages in GrowthExperiments and they don't have many translations, so we are definitely better off with Intl in that regard as well.

In T230333#8131544, @Sgs wrote:

I think what we need to test before giving it an ok is the locale negotiation. We should make sure it works for all the languages wiki projects support and does appropriate fallback.

We could set the MediaWiki language fallback chain explicitly (Intl.NumberFormat(['pt', 'pt-br', 'en'], { localeMatcher: 'lookup', ...}) - not sure how best fit matching is different exactly).

Tgr claimed this task.Nov 26 2022, 1:08 AM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 26 2022, 1:12 AM

Change 860939 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Abbreviate pageview count in new impact module mobile summary

https://gerrit.wikimedia.org/r/860939

gerritbot added a project: Patch-For-Review.Nov 26 2022, 1:12 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 26 2022, 10:46 AM
gerritbot added a comment.Nov 26 2022, 11:06 AM

Change 860939 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Abbreviate pageview count in new impact module mobile summary

https://gerrit.wikimedia.org/r/860939

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2022, 11:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 26 2022, 12:01 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 30 2022, 2:32 AM

Checked in betalabs - no issues were found.

Screenshot_20221129-160810_Chrome.jpg (2×1 px, 319 KB)

RHo awarded a token.Nov 30 2022, 10:43 PM
Etonkovidova closed this task as Resolved.Dec 2 2022, 9:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL