Page MenuHomePhabricator

Homepage: module headers in mobile Start module dialog should have no padding
Closed, ResolvedPublicBUG REPORT

Description

In the mobile Start module details dialog, module headers are indented. According to mockup specifications they should not.

Actual Results:
The h3 element is inheriting the growthexperiments-homepage-module-section class, resulting in

Screenshot 2019-08-07 11.54.35.png (476×752 px, 41 KB)

Expected Results:
The h3 element should not inherit the growthexperiments-homepage-module-section class, resulting in

Screenshot 2019-08-12 16.26.09.png (496×750 px, 44 KB)

Event Timeline

Change 530593 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start: update submodules header

https://gerrit.wikimedia.org/r/530593

Change 530593 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start: update submodules header

https://gerrit.wikimedia.org/r/530593

The specs seem to be in place:

betalabstestwiki
Screen Shot 2019-08-19 at 3.16.05 PM.png (943×755 px, 93 KB)
Screen Shot 2019-08-19 at 3.15.55 PM.png (983×721 px, 94 KB)