Description

According to mockup specifications, modules in the mobile Start module details dialog should have larger top and bottom padding.

Actual Results:

Screenshot 2019-08-07 11.57.01.png (416×750 px, 38 KB)

Expected Results:

Screenshot 2019-08-12 17.57.40.png (368×640 px, 29 KB)

.growthexperiments-homepage-module-start.growthexperiments-homepage-module-mobile-overlay > .growthexperiments-homepage-module-section-body .growthexperiments-homepage-module {
  padding: 1em 0 1.85em 0;
}

Details

	Subject	Repo	Branch	Lines +/-
	Start: increase submodules padding	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Rileych	T213990 [EPIC] Growth: Newcomer homepage
Resolved		MMiller_WMF	T215983 Homepage: mobile version
Resolved		• Rileych	T230014 Homepage: layout and UI fixes
Resolved	BUG REPORT	SBisson	T230360 Homepage: modules padding issues in mobile Start module dialog

Event Timeline

• Cntlsn created this task.Aug 12 2019, 3:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2019, 3:59 PM

• Cntlsn triaged this task as Medium priority.Aug 12 2019, 3:59 PM

• Cntlsn moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

• Cntlsn added parent tasks: T230014: Homepage: layout and UI fixes, T215983: Homepage: mobile version.Aug 12 2019, 5:51 PM

phuedx moved this task from Needs triage to Growth on the Mobile board.Aug 15 2019, 11:11 AM

Change 530592 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start: increase submodules padding

https://gerrit.wikimedia.org/r/530592

gerritbot added a project: Patch-For-Review.Aug 16 2019, 3:17 PM

SBisson claimed this task.Aug 16 2019, 3:18 PM

SBisson moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2019, 8:06 PM

Change 530592 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start: increase submodules padding

https://gerrit.wikimedia.org/r/530592

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2019, 9:10 PM

The specs seem to be in place:

betalabs	testwiki

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 9:01 PM

LGTM

Thank you!

	F30048401: Screen Shot 2019-08-19 at 3.56.02 PM.png
	Aug 19 2019, 11:33 PM

	F30048399: Screen Shot 2019-08-19 at 3.55.54 PM.png
	Aug 19 2019, 11:33 PM

	F30008779: Screenshot 2019-08-12 17.57.40.png
	Aug 12 2019, 3:59 PM

	F30008523: Screenshot 2019-08-07 11.57.01.png
	Aug 12 2019, 3:59 PM

Homepage: modules padding issues in mobile Start module dialogClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Homepage: modules padding issues in mobile Start module dialog
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...