| • Cntlsn | |
| Aug 12 2019, 5:39 PM |
| F30068733: IMG_8225.PNG | |
| Aug 22 2019, 10:13 PM |
| F30068717: IMG_8224.PNG | |
| Aug 22 2019, 10:13 PM |
| F30068708: IMG_8226.PNG | |
| Aug 22 2019, 10:13 PM |
| F30045663: Screen Shot 2019-08-17 at 4.08.10 PM.png | |
| Aug 17 2019, 11:14 PM |
| F30045665: Screen Shot 2019-08-17 at 4.08.03 PM.png | |
| Aug 17 2019, 11:14 PM |
| F30045670: Screen Shot 2019-08-17 at 4.01.11 PM.png | |
| Aug 17 2019, 11:14 PM |
| F30045674: IMG_8213.PNG | |
| Aug 17 2019, 11:14 PM |
| F30045672: IMG_8214.PNG | |
| Aug 17 2019, 11:14 PM |
In the context of the mobile Newcomer homepage, the number of pageviews in the list of recent edited articles in the Impact module details dialog should be bigger.
Actual Results:
Expected Results:
.growthexperiments-homepage-module-impact .impact-row .pageviews {
font-size: 1.15em;
}| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Rileych | T213990 [EPIC] Growth: Newcomer homepage | |||
| Resolved | MMiller_WMF | T215983 Homepage: mobile version | |||
| Resolved | • Rileych | T230014 Homepage: layout and UI fixes | |||
| Resolved | BUG REPORT | SBisson | T230377 Homepage: text size issue of pageviews number in Impact module |
This task is only for mobile, but the CSS rule would apply to both mobile and desktop. Should this change be made for both mobile and desktop? It seems to me that the ratio between the font size of the number and the font size of the text to the left of it should be consistent between desktop and mobile (right now it's 1:1 on both).
Sorry, my mistake, this should be clearly increased in both mobile AND desktop. Thanks!
Change 530570 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: increase pageviews text size
Change 530570 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: increase pageviews text size
For Design review:
| present production - testwiki | betalabs with the fix |
 |  |
However, the space between the title and the label "People are viewing..":
| testwiki | betalabs |
 |  |
The screenshots from a real device:
| testwiki | betalabs |
 |  |
hi @SBisson - font-size looks good to me but can we make the numbers text-align right? It would also be better if numbers were formatted with correct localized notation ( eg 1,002 for one thousand and two in english, vs 1.002 when written in danish)? I can create a new ticket if you prefer for either or both of these points!
Change 531500 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: right align pageviews
Change 531504 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: format pageviews numbers according to user language
I'm sure they used to be right-aligned but that got lost somehow. Fixed in a patch above.
It would also be better if numbers were formatted with correct localized notation ( eg 1,002 for one thousand and two in english, vs 1.002 when written in danish)? I can create a new ticket if you prefer for either or both of these points!
I've made a patch for it (see above) but I'm not sure how I feel about it.. It kinda looks like money. I'll let you and the team decide what you want to do with it.
Change 531500 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: right align pageviews
That leaves the spacing issue identified in T230377#5419906. Is that something that should be restored to the previous layout?
Change 531504 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: format pageviews numbers according to user language
For Design review - right-aligned and localized pageviews number:
 |  |
With extremely long titles:
