Page MenuHomePhabricator
Create Task
Maniphest T235564

Implement Integration Tests for Existing iOS Endpoints
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Description
The new iOS endpoints currently have no tests at all. We want to go back and implement a set of integration tests using the framework developed by @daniel and @Clarakosi.

T234995 contains an initial discussion. Daniel's recommendation for the first iteration is that the initial tests can reside in api-testing repo, with the understanding that we will revisit that at a later point.

The first step will be to define the test requirements for each endpoint and then implement the tests.

Requirements

  • Review existing iOS endpoints and define test requirements for each:
    • Implement GET History Filter (T231597)
    • Implement GET page history (T231558)
    • Implement bot edit count endpoint (T234488)
    • Implement anonymous edit count endpoint (T234487)
    • Implement reverted edits count endpoint (T234486)
    • Implement GET Edit Count (T231590)
    • Implement Editors Count Endpoint (T234485)
    • Implement GET Revision Comparison (T231580)
    • Implement GET Page Revision (T231588)
  • Implement Integration Tests for each endpoint
    • Implement GET History Filter (T231597)
    • Implement GET page history (T231558)
    • Implement bot edit count endpoint (T234488)
    • Implement anonymous edit count endpoint (T234487)
    • Implement reverted edits count endpoint (T234486)
    • Implement GET Edit Count (T231590)
    • Implement Editors Count Endpoint (T234485)
    • Implement GET Revision Comparison (T231580)
    • Implement GET Page Revision (T231588)

Details

SubjectRepoBranchLines +/-
Add integration tests for revision/{id}/baremediawiki/tools/api-testingmaster+25 -0
Add integration tests for page historymediawiki/tools/api-testingmaster+238 -96
Integration tests for /revision/{from}/compare/{to}mediawiki/tools/api-testingmaster+49 -0
Add integration tests for page history countsmediawiki/tools/api-testingmaster+205 -1
docker: bump Quibble to 0.0.39integration/configmaster+48 -0
Switch api-testing job to Quibble 0.0.39integration/configmaster+1 -1
Release Quibble 0.0.39integration/quibblemaster+8 -2
Enable REST API for testingintegration/quibblemaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

WDoranWMF created this task.Oct 15 2019, 9:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2019, 9:29 PM
WDoranWMF triaged this task as High priority.Oct 15 2019, 9:29 PM
WDoranWMF added parent tasks: T231355: Curator gets reverted edit history, T231369: Curator gets bot edit history, T231368: Curator gets anonymous edit history, T231352: Curator gets anonymous edit count, T231345: Curator reads revision metadata , T231347: Curator compares revisions, T231348: Curator gets edit count, T231349: Curator gets editors count, T231351: Curator gets reverted edits count, T231354: Curator gets bot edit count.Oct 15 2019, 9:33 PM
WDoranWMF added a project: Platform Team Initiatives (MW REST API in PHP).Oct 15 2019, 9:44 PM
WDoranWMF lowered the priority of this task from High to Medium.Oct 16 2019, 1:21 PM
WDoranWMF moved this task from Next Sprint to Tasks Ready for Estimation on the Platform Team Workboards (Green) board.Oct 16 2019, 2:44 PM
WDoranWMF set the point value for this task to 5.Oct 16 2019, 7:21 PM
WDoranWMF moved this task from Tasks Ready for Estimation to Ready on the Platform Team Workboards (Green) board.
• Clarakosi claimed this task.Oct 17 2019, 2:30 PM
• Clarakosi moved this task from Ready to Doing on the Platform Team Workboards (Green) board.
gerritbot added a comment.Oct 18 2019, 12:56 PM

Change 544189 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[integration/quibble@master] Enable REST API for testing

https://gerrit.wikimedia.org/r/544189

gerritbot added a project: Patch-For-Review.Oct 18 2019, 12:56 PM
gerritbot added a comment.Oct 18 2019, 1:19 PM

Change 544189 merged by jenkins-bot:
[integration/quibble@master] Enable REST API for testing

https://gerrit.wikimedia.org/r/544189

gerritbot added a comment.Oct 18 2019, 1:28 PM

Change 544192 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Release Quibble 0.0.39

https://gerrit.wikimedia.org/r/544192

gerritbot added a comment.Oct 18 2019, 1:38 PM

Change 544192 merged by jenkins-bot:
[integration/quibble@master] Release Quibble 0.0.39

https://gerrit.wikimedia.org/r/544192

Stashbot mentioned this in T235023: Selenium test "User should be able to log in @daily" fails with Quibble 0.0.37.Oct 18 2019, 1:44 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-18T13:44:15Z] <hashar> Tag Quibble 0.0.39 @ a1e0b85 # T235023 T235564

gerritbot added a comment.Oct 18 2019, 1:49 PM

Change 544195 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: bump Quibble to 0.0.39

https://gerrit.wikimedia.org/r/544195

gerritbot added a comment.Oct 18 2019, 1:51 PM

Change 544196 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Switch api-testing job to Quibble 0.0.39

https://gerrit.wikimedia.org/r/544196

gerritbot added a comment.Oct 18 2019, 1:54 PM

Change 544195 merged by jenkins-bot:
[integration/config@master] docker: bump Quibble to 0.0.39

https://gerrit.wikimedia.org/r/544195

gerritbot added a comment.Oct 18 2019, 2:35 PM

Change 544196 merged by jenkins-bot:
[integration/config@master] Switch api-testing job to Quibble 0.0.39

https://gerrit.wikimedia.org/r/544196

gerritbot added a comment.Oct 18 2019, 2:36 PM

Change 543953 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/tools/api-testing@master] Add integration tests for page history counts

https://gerrit.wikimedia.org/r/543953

Jdforrester-WMF subscribed.Oct 18 2019, 7:58 PM
gerritbot added a comment.Oct 22 2019, 3:20 PM

Change 543953 merged by jenkins-bot:
[mediawiki/tools/api-testing@master] Add integration tests for page history counts

https://gerrit.wikimedia.org/r/543953

• Clarakosi updated the task description. (Show Details)Oct 22 2019, 3:32 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 22 2019, 4:10 PM
gerritbot added a comment.Oct 23 2019, 6:45 PM

Change 545632 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/tools/api-testing@master] Add integration tests for page history

https://gerrit.wikimedia.org/r/545632

gerritbot added a project: Patch-For-Review.Oct 23 2019, 6:45 PM
gerritbot added a comment.Oct 23 2019, 8:00 PM

Change 545649 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/tools/api-testing@master] Integration tests for /revision/{from}/compare/{to}

https://gerrit.wikimedia.org/r/545649

• eprodromou subscribed.Oct 24 2019, 3:24 PM

I don't see a checkmark for T231345. Did we miss that out on purpose, or just an oversight?

• Pchelolo added a subtask: T236333: Install wikidiff2 into mediawiki-quibble-api-testing-vendor-mysql-php72-docker.Oct 24 2019, 5:54 PM
• Clarakosi updated the task description. (Show Details)Oct 24 2019, 8:48 PM
gerritbot added a comment.Oct 28 2019, 7:58 PM

Change 545649 merged by jenkins-bot:
[mediawiki/tools/api-testing@master] Integration tests for /revision/{from}/compare/{to}

https://gerrit.wikimedia.org/r/545649

gerritbot added a comment.Oct 28 2019, 8:01 PM

Change 545632 merged by jenkins-bot:
[mediawiki/tools/api-testing@master] Add integration tests for page history

https://gerrit.wikimedia.org/r/545632

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2019, 8:11 PM
gerritbot added a comment.Oct 28 2019, 8:38 PM

Change 546729 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/tools/api-testing@master] Add integration tests for revision/{id}/bare

https://gerrit.wikimedia.org/r/546729

gerritbot added a project: Patch-For-Review.Oct 28 2019, 8:38 PM
• Clarakosi updated the task description. (Show Details)Oct 28 2019, 8:39 PM
• Clarakosi moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Oct 28 2019, 8:45 PM
gerritbot added a comment.Oct 28 2019, 8:52 PM

Change 546729 merged by jenkins-bot:
[mediawiki/tools/api-testing@master] Add integration tests for revision/{id}/bare

https://gerrit.wikimedia.org/r/546729

• Clarakosi updated the task description. (Show Details)Oct 28 2019, 8:57 PM
• Clarakosi moved this task from Waiting for Review to Done on the Platform Team Workboards (Green) board.
brennen closed subtask T236333: Install wikidiff2 into mediawiki-quibble-api-testing-vendor-mysql-php72-docker as Resolved.Oct 28 2019, 9:02 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 28 2019, 9:10 PM
• eprodromou added a comment.Oct 29 2019, 4:22 PM

I reviewed; these are all implemented and running. Thanks for the good work, @Clarakosi !

• eprodromou closed this task as Resolved.Oct 29 2019, 4:22 PM
hashar mentioned this in T235865: Modify Quibble to accept a LocalSettings.php file .Dec 19 2019, 3:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL