Remove "response" from comparison REST API endpoint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• eprodromou
	Oct 18 2019, 12:49 PM

Description

The comparison endpoint includes an extra "response" property, which wraps the rest of the response. The "from", "to", and "diff" properties should be top-level in the comparison object; no "response" wrapper is necessary.

Details

	Subject	Repo	Branch	Lines +/-
	Remove 'response' prop. from revision comparison JSON	mediawiki/core	master	+9 -11

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T229661 Core REST API in MediaWiki
Resolved	• eprodromou	T231338 Page history API
Resolved	• eprodromou	T231347 Curator compares revisions
Resolved	• nnikkhoui	T235864 Remove "response" from comparison REST API endpoint

Event Timeline

• eprodromou created this task.Oct 18 2019, 12:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2019, 12:49 PM

• eprodromou mentioned this in T231580: Implement GET Revision Comparison.Oct 18 2019, 12:52 PM

• eprodromou added a parent task: T231347: Curator compares revisions.Oct 23 2019, 7:47 PM

• nnikkhoui claimed this task.Oct 24 2019, 4:59 PM

Change 545925 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] Remove 'response' prop. from revision comparison JSON

https://gerrit.wikimedia.org/r/545925

gerritbot added a project: Patch-For-Review.Oct 24 2019, 7:39 PM

• nnikkhoui moved this task from Backlog to Waiting for Review on the Platform Team Workboards (Green) board.Oct 24 2019, 7:46 PM

Change 545925 merged by jenkins-bot:
[mediawiki/core@master] Remove 'response' prop. from revision comparison JSON

https://gerrit.wikimedia.org/r/545925

Maintenance_bot removed a project: Patch-For-Review.Oct 24 2019, 8:10 PM

• nnikkhoui moved this task from Waiting for Review to Done on the Platform Team Workboards (Green) board.Oct 24 2019, 8:47 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 24 2019, 9:00 PM

Updated docs to reflect this change