Parsoid/PHP HTML output for PageBundle should contain Content-Language and Vary headers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mobrovac
	Oct 24 2019, 1:17 PM

Description

Spotted while testing RESTBase with Parsoid/PHP. When replying to pagebundle requests, the HTML sub-section of the response body differs between JS and PHP:

'content-type': 'text/html; charset=utf-8; profile="https://www.mediawiki.org/wiki/Specs/HTML/2.1.0"',
'content-language': 'en',
vary: 'Accept'

PHP

'content-type': 'text/html; charset=utf-8; profile="https://www.mediawiki.org/wiki/Specs/HTML/2.1.0"'

It seems like this feature was left out during the port but RESTBase relies on these for language conversions and caching.

Additionally, while looking at the Parsoid code, I realised that [Parsoid/PHP forces content-language: en for all output](https://github.com/wikimedia/parsoid/blob/2035954f40a31c97a6a7051a6238113eb2b50976/extension/src/Rest/Handler/ParsoidHandler.php#L593-L595), but that shouldn't be the case (since not all content's language is en).

Details

	Subject	Repo	Branch	Lines +/-
	Add language converter endpoints to the REST API	mediawiki/services/parsoid	master	+273 -64

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ssastry	T229015 Tracking: Direct live production traffic at Parsoid/PHP
Resolved	• mobrovac	T229018 RESTBase should be able to store Parsoid/PHP contents in Cassandra alongwith Parsoid/JS contents
Resolved	ssastry	T235902 Tracking: Shadow Parsoid/PHP deployment to production cluster to handle mirrored reparse traffic
Resolved	• mobrovac	T230791 Have a Mechanism for Storing and Retrieving Parsoid HTML from JS and PHP
Resolved	• mobrovac	T236382 Parsoid/PHP HTML output for PageBundle should contain Content-Language and Vary headers

Event Timeline

• mobrovac triaged this task as High priority.Oct 24 2019, 1:17 PM

• mobrovac created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2019, 1:17 PM

• mobrovac added a parent task: T230791: Have a Mechanism for Storing and Retrieving Parsoid HTML from JS and PHP.Oct 24 2019, 1:17 PM

• mobrovac mentioned this in T230791: Have a Mechanism for Storing and Retrieving Parsoid HTML from JS and PHP.

This is fixed in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/545391/3/src/PageBundle.php#77

In T236382#5603273, @Arlolra wrote:

This is fixed in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/545391/3/src/PageBundle.php#77

I was mentioning this to @mobrovac on IRC, but looks like they need these headers independent of LC endpoints. Unless the LC endpoints are done, how difficult is it to pull out the code that sets these headers into a separate patch so we can merge that and unblock Marko?

Unless the LC endpoints are done, how difficult is it to pull out the code that sets these headers into a separate patch so we can merge that and unblock Marko?

It wouldn't be too difficult but the patch is nearly done.

@ssastry and I discussed this on IRC. Since language conversion will be merged before T229015: Tracking: Direct live production traffic at Parsoid/PHP, it is safe to work around this in RESTBase for now (BUT leave a todo and log it in case this ever happens), so I will do that.

Change 545391 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Add language converter endpoints to the REST API

https://gerrit.wikimedia.org/r/545391

gerritbot added a project: Patch-For-Review.Oct 24 2019, 8:06 PM

Change 545391 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add language converter endpoints to the REST API

https://gerrit.wikimedia.org/r/545391

• Pchelolo mentioned this in T236836: RESTBase warning missing Content-Language or Vary header in pb.body.html.headers.Oct 29 2019, 7:27 PM

Aklapper removed a project: Patch-For-Review.Apr 10 2020, 9:43 AM