Page MenuHomePhabricator
Create Task
Maniphest T236837

High rate of 412 responses from Parsoid-PHP
Closed, ResolvedPublic
Actions

Description

After we started mirroring the traffic to parsoid-php, we've observed a high number of 412 responses from Parsoid.

Parsoid codebase never returns 412, however core REST framework does. We need to investigate why the 412s are returned.

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Oct 29 2019, 7:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 7:30 PM
ssastry triaged this task as Medium priority.Oct 29 2019, 8:58 PM
ssastry moved this task from Backlog to Bugs, Notices, Crashers on the Parsoid-PHP board.
ssastry added a comment.Oct 30 2019, 1:38 PM

https://github.com/wikimedia/mediawiki/blob/master/includes/Rest/ConditionalHeaderUtil.php#L43-L96 is the code in the REST framework that returns a http 412. Glancing at that code, that indicates potentially issues in request tags (etag, if-modified-since .. )

ssastry added a comment.Oct 30 2019, 1:39 PM

@Pchelolo Likely an issue with RESTBase requests.

ssastry moved this task from Bugs, Notices, Crashers to Non-parsing Team Work on the Parsoid-PHP board.Oct 30 2019, 1:40 PM
Stashbot added a comment.Oct 30 2019, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-30T21:17:36Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@88cf547]: Parsoid mirroring followups: T236837, T236838

Stashbot mentioned this in T236838: RESTBase mirror mode for Parsoid-PHP doesn't honor storage.Oct 30 2019, 9:17 PM
Stashbot added a comment.Oct 30 2019, 9:31 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-30T21:31:40Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@88cf547]: Parsoid mirroring followups: T236837, T236838 (duration: 14m 04s)

• Pchelolo added a comment.Oct 30 2019, 9:42 PM

Ok, I know what's happening now. RESTBase is passing through the if-unmodified-since header to parsoid-php. With current implementation MediaWiki responds with 412 for any valid if-unmodified-since request, which is technically correct - we don't cache parsoid results in core. Fixing.

Stashbot mentioned this in T235902: Tracking: Shadow Parsoid/PHP deployment to production cluster to handle mirrored reparse traffic.Oct 30 2019, 9:55 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-30T21:55:05Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@fa934c8]: Bump parsoid mirroring to 25% and fix 412: T235902, T236837

Stashbot added a comment.Oct 30 2019, 10:09 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-30T22:08:59Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@fa934c8]: Bump parsoid mirroring to 25% and fix 412: T235902, T236837 (duration: 13m 54s)

• Pchelolo added a comment.Oct 30 2019, 10:11 PM

Seem to have been fixed by my latest deployment. Resolving.

• Pchelolo closed this task as Resolved.Oct 30 2019, 10:11 PM
• Pchelolo claimed this task.
ssastry mentioned this in T238849: Post switchover to Parsoid/PHP on private wikis, VE edit saves on officewiki responded with a HTTP 412.Nov 21 2019, 8:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL