Page MenuHomePhabricator
Create Task
Maniphest T238126

Investigate feasibility of using comment_data
Closed, ResolvedPublic
Actions

Description

As described in T220696#5653419 we would like to use the comment_data field from the comments table to generate better edit summaries.

To make comment_data usable it needs to be exposed through the FormatAutocomments hook and stay backwards-compatible. This hook is run from Linter::formatComment which is in turn called from the following files:

Calls to Linker::formatComment
extensions/Wikibase/client/includes/RecentChanges/ChangeLineFormatter.php

includes/DummyLinker.php
includes/FeedUtils.php
includes/Linker.php
includes/actions/RollbackAction.php
includes/api/ApiComparePages.php
includes/api/ApiParse.php
includes/api/ApiQueryDeletedrevs.php
includes/api/ApiQueryFilearchive.php
includes/api/ApiQueryImageInfo.php
includes/api/ApiQueryLogEvents.php
includes/api/ApiQueryProtectedTitles.php
includes/api/ApiQueryRecentChanges.php
includes/api/ApiQueryRevisionsBase.php
includes/api/ApiQueryUserContribs.php
includes/api/ApiQueryWatchlist.php
includes/page/ImageHistoryList.php
includes/specials/pagers/BlockListPager.php
includes/specials/pagers/ImageListPager.php
includes/specials/pagers/ProtectedPagesPager.php

Calls to Linker::revComment (which is itself calling Linker::formatComment)
includes/Revision.php

Calls to Linker::commentBlock (which is itself calling Linker::formatComment)
includes/DummyLinker.php
includes/EditPage.php
includes/actions/McrUndoAction.php
includes/changes/ChangesList.php
includes/logging/LogFormatter.php
includes/revisiondelete/RevDelFileItem.php
includes/revisiondelete/RevDelLogItem.php
includes/specials/SpecialUndelete.php

The above are only the relevant calls from mediawiki/core and wikibase itself.

Details

SubjectRepoBranchLines +/-
[DNM] Put comment_data into FormatAutocomments hook argsmediawiki/coremaster+11 -7
[DNM] Show comment_data in edit summariesmediawiki/extensions/Wikibasemaster+13 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT220696 [Story] Create better edit summaries for wbeditentity API endpoint
ResolvedAddshoreT238126 Investigate feasibility of using comment_data
· · ·

Event Timeline

Jakob_WMDE created this task.Nov 12 2019, 5:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2019, 5:36 PM
Jakob_WMDE updated the task description. (Show Details)Nov 12 2019, 5:39 PM
Rosalie_WMDE subscribed.Nov 12 2019, 6:02 PM
WMDE-leszek subscribed.Nov 12 2019, 6:34 PM
Jakob_WMDE updated the task description. (Show Details)Nov 13 2019, 10:26 AM
Jakob_WMDE added a comment.Nov 13 2019, 1:39 PM

One of the necessary changes to get RecentChanges to work are waiting for further review here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/489741

Jakob_WMDE added a comment.Nov 13 2019, 2:12 PM

With the RecentChanges patch, and returning a CommentStoreComment from Revision::getComment we can without a lot of changes get the comment_data through as an argument of the FormatAutocomments hook. This would already allow us to use it to format edit summaries in RecentChanges and the entity history page.

gerritbot added a comment.Nov 13 2019, 4:04 PM

Change 550710 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/core@master] [DNM] Experiment in getting comment_data to work

https://gerrit.wikimedia.org/r/550710

gerritbot added a project: Patch-For-Review.Nov 13 2019, 4:04 PM
gerritbot added a comment.Nov 13 2019, 4:11 PM

Change 550711 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] [DNM] Show comment_data in edit summaries

https://gerrit.wikimedia.org/r/550711

Jakob_WMDE added a comment.Nov 13 2019, 4:23 PM

With the two proof of concept patches checked out, we can access comment_data through the FormatAutocomments hook. The main work for RecentChanges was already done in this unmerged patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/489741

A lot of discussion around the CommentStoreComment object which we would like to have passed around instead of the summary string also happened here: T218127.

Rosalie_WMDE added a subscriber: • alaa_wmde.Nov 15 2019, 1:11 PM
Addshore subscribed.Nov 16 2019, 8:54 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Dec 11 2019, 11:48 AM
Addshore edited projects, added Wikidata-Trailblazing-Exploration; removed Patch-For-Review, Wikidata-Campsite.Jan 14 2020, 1:54 PM
Addshore added a project: [DEPRECATED] wdwb-tech.Jan 22 2021, 10:03 PM
Addshore moved this task from Inbox to Investigate & Discuss on the [DEPRECATED] wdwb-tech board.Jan 22 2021, 10:27 PM
Addshore closed this task as Resolved.Sep 9 2021, 8:58 AM
Addshore claimed this task.
Restricted Application added a project: User-Addshore. · View Herald TranscriptSep 9 2021, 8:58 AM
gerritbot added a comment.Sep 17 2021, 9:17 AM

Change 550711 abandoned by Addshore:

[mediawiki/extensions/Wikibase@master] [DNM] Show comment_data in edit summaries

Reason:

Abandoning, but this is linked in the ticket anyway so we won't miss it!

https://gerrit.wikimedia.org/r/550711

gerritbot added a comment.Feb 24 2022, 9:34 AM

Change 550710 abandoned by Jakob:

[mediawiki/core@master] [DNM] Put comment_data into FormatAutocomments hook args

Reason:

https://gerrit.wikimedia.org/r/550710

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL