DataAccess.php for the integrated mode invokes the 'ParsoidFetchTemplateData' hook but the TemplateData extension doesn't implement this hook currently.
Implementing this is a blocker for further production deployments, and also highlights a testing gap that we didn't discover this till now even after all our testing on the beta cluster and test wiki. And, I suppose mediawiki.org doesn't use templatedata much either.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ssastry | T229015 Tracking: Direct live production traffic at Parsoid/PHP | |||
| Resolved | ssastry | T238954 html2wt: Missing implementation of 'ParsoidFetchTemplateData' to fetch templatedata |
@mobrovac, we may have to push back Tuesday's deploy to the following week since we need this code to be implemented and then ride the train into production.
Change 552620 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/extensions/TemplateData@master] WIP: Implement ParsoidFetchTemplateData hook for Parsoid/PHP
@ssastry note that if you let it ride the train, that means setting switching back for two weeks (this week + next week for the train). Ideally, you may want to put the patch up for SWAT as soon as it gets merged into master (either Tuesday or next Monday).
Change 552620 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Implement ParsoidFetchTemplateData hook for Parsoid/PHP
Change 552871 had a related patch set uploaded (by Reedy; owner: Subramanya Sastry):
[mediawiki/extensions/TemplateData@wmf/1.35.0-wmf.5] Implement ParsoidFetchTemplateData hook for Parsoid/PHP
Change 552871 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@wmf/1.35.0-wmf.5] Implement ParsoidFetchTemplateData hook for Parsoid/PHP
Mentioned in SAL (#wikimedia-operations) [2019-11-25T18:55:40Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/TemplateData/: SWAT: [[gerrit:552871|Implement ParsoidFetchTemplateData hook for Parsoid/PHP (T238954)]] (duration: 00m 53s)