Page MenuHomePhabricator
Create Task
Maniphest T242095

TermSearchInteractor should have a new implementation supporting new terms storage
Closed, ResolvedPublic
Actions

Description

Highlighted in T232040#5774510

Details

SubjectRepoBranchLines +/-
Start DatabaseMatchingTermsLookupmediawiki/extensions/Wikibasemaster+555 -0
Use MatchingTermsLookup instead of TermIndex in TermIndexPropertyLabelResolvermediawiki/extensions/Wikibasemaster+18 -19
Use MockMatchingTermsLookup instead of MockTermIndexmediawiki/extensions/ArticlePlaceholdermaster+6 -6
Rename TermIndexSearchInteractorFactory to MatchingTermsSearchInteractorFactorymediawiki/extensions/Wikibasemaster+13 -13
Remove class alias for TermIndexSearchInteractormediawiki/extensions/Wikibasemaster+1 -11
Move search parts of LegacyEntityTermStoreReader into MatchingTermsLookupmediawiki/extensions/Wikibasemaster+110 -85
Use the new name of TermIndexSearchInteractormediawiki/extensions/ArticlePlaceholdermaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 7 2020, 11:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2020, 11:18 AM
Addshore moved this task from Incoming to Ready to pick up on the Wikidata-Campsite board.Jan 7 2020, 11:18 AM
Addshore mentioned this in T208425: [EPIC] Kill the wb_terms table.
Addshore added a parent task: T232040: Add label and description collision detectors for new terms store.Jan 7 2020, 11:38 AM
gerritbot added a comment.Jan 7 2020, 11:38 AM

Change 562320 had a related patch set uploaded (by Addshore; owner: Sarhan):
[mediawiki/extensions/Wikibase@master] Update SingleEntitySourceServices to respect item terms migration stages

https://gerrit.wikimedia.org/r/562320

gerritbot added a project: Patch-For-Review.Jan 7 2020, 11:38 AM
Addshore moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 7 2020, 1:30 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore removed a project: Patch-For-Review.Jan 7 2020, 1:32 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 7 2020, 2:15 PM
Ladsgroup subscribed.Jan 8 2020, 8:14 AM

Maybe I'm wrong here but the lack of implementation for TermSearchInteractor is not related to SingleEntitySourceServices. An entity source based federation would also need an implementation of it as well.

Ladsgroup claimed this task.Jan 10 2020, 6:51 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 10 2020, 6:51 AM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 10 2020, 7:15 AM
gerritbot added a comment.Jan 10 2020, 9:47 AM

Change 563396 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move search parts of LegacyEntityTermStoreReader into MatchingTermsLookup

https://gerrit.wikimedia.org/r/563396

gerritbot added a project: Patch-For-Review.Jan 10 2020, 9:48 AM
gerritbot added a comment.Jan 10 2020, 11:06 AM

Change 563419 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/ArticlePlaceholder@master] Use the new name of TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563419

gerritbot added a comment.Jan 10 2020, 11:11 AM

Change 563420 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Remove class alias for TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563420

gerritbot added a comment.Jan 10 2020, 11:16 AM

Change 563421 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Rename TermIndexSearchInteractorFactory to MatchingTermsSearchInteractorFactory

https://gerrit.wikimedia.org/r/563421

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 10 2020, 11:26 AM
gerritbot added a comment.Jan 13 2020, 12:50 PM

Change 563998 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Use MatchingTermsLookup instead of TermIndex in TermIndexPropertyLabelResolver

https://gerrit.wikimedia.org/r/563998

gerritbot added a comment.Jan 13 2020, 1:08 PM

Change 563396 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move search parts of LegacyEntityTermStoreReader into MatchingTermsLookup

https://gerrit.wikimedia.org/r/563396

gerritbot added a comment.Jan 13 2020, 1:23 PM

Change 563419 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Use the new name of TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563419

gerritbot added a comment.Jan 13 2020, 1:23 PM

Change 563420 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove class alias for TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563420

gerritbot added a comment.Jan 13 2020, 1:23 PM

Change 563421 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename TermIndexSearchInteractorFactory to MatchingTermsSearchInteractorFactory

https://gerrit.wikimedia.org/r/563421

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 13 2020, 2:00 PM
gerritbot added a comment.Jan 13 2020, 2:13 PM

Change 564013 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/ArticlePlaceholder@master] Use MockMatchingTermsLookup instead of MockTermIndex

https://gerrit.wikimedia.org/r/564013

gerritbot added a comment.Jan 13 2020, 2:50 PM

Change 564013 abandoned by Ladsgroup:
Use MockMatchingTermsLookup instead of MockTermIndex

Reason:
Doesn't work :/

https://gerrit.wikimedia.org/r/564013

gerritbot added a comment.Jan 14 2020, 9:28 AM

Change 563998 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use MatchingTermsLookup instead of TermIndex in TermIndexPropertyLabelResolver

https://gerrit.wikimedia.org/r/563998

Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 14 2020, 10:11 AM
Addshore triaged this task as Medium priority.Jan 14 2020, 4:08 PM
Addshore added a comment.Jan 14 2020, 8:03 PM
In T242095#5785047, @Ladsgroup wrote:

Maybe I'm wrong here but the lack of implementation for TermSearchInteractor is not related to SingleEntitySourceServices. An entity source based federation would also need an implementation of it as well.

Correct!

gerritbot added a comment.Jan 14 2020, 8:07 PM

Change 564772 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] [WIP] Start DatabaseMatchingTermsLookup

https://gerrit.wikimedia.org/r/564772

Ladsgroup renamed this task from SingleEntitySourceServices TermSearchInteractor should use new terms storage to TermSearchInteractor should have a implementation supporting new terms storage.Jan 15 2020, 8:11 AM
Ladsgroup renamed this task from TermSearchInteractor should have a implementation supporting new terms storage to TermSearchInteractor should have a new implementation supporting new terms storage.
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 15 2020, 3:45 PM
Addshore removed a parent task: T232040: Add label and description collision detectors for new terms store.Jan 15 2020, 5:09 PM
Addshore added a parent task: T236979: Fix remaining usecases still reading from old wb_terms schema.

This is not needed / no longer needed for wikidata.org migration.
Only for wikibase itself.

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 17 2020, 11:42 AM
gerritbot added a comment.Jan 17 2020, 12:31 PM

Change 564772 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Start DatabaseMatchingTermsLookup

https://gerrit.wikimedia.org/r/564772

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.16; 2020-01-21); removed MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 17 2020, 1:00 PM
Addshore closed this task as Resolved.Jan 24 2020, 10:20 AM
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Jan 24 2020, 11:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL