Update SpecialNewProperty and SpecialNewItem to use new store conflict detection
Closed, ResolvedPublic
Actions

Description

SpecialNewProperty and SpecialNewItem directly entities from form data and do their own validation inside validateFormData.

New store fingure print uniqueness validation was introduced as a validator executed inside ChangeOpFingerprintResult, so since the aforementioned two specials do not use ChangeOp to create the entities (unlike the other specials such as SpecialSetAliases .. etc), they will have to be updated to use the new store conflict detection directly as well.

Details

	Subject	Repo	Branch	Lines +/-
	Update new enitty specials to check fingerprint uniqueneness in new store	mediawiki/extensions/Wikibase	master	+233 -16

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Addshore	T208425 [EPIC] Kill the wb_terms table
Resolved	Addshore	T219303 [Checkpoint 5] Update Read Logic
Duplicate	None	T236979 Fix remaining usecases still reading from old wb_terms schema
Resolved	Addshore	T232040 Add label and description collision detectors for new terms store
Resolved	Ladsgroup	T242204 Update SpecialNewProperty and SpecialNewItem to use new store conflict detection

Event Timeline

sarhan.alaa created this task.Jan 8 2020, 9:48 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 8 2020, 9:48 AM

sarhan.alaa moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 8 2020, 9:48 AM

Change 562782 had a related patch set uploaded (by Sarhan; owner: Sarhan):
[mediawiki/extensions/Wikibase@master] Update new enitty specials to check fingerprint uniqueneness in new store

https://gerrit.wikimedia.org/r/562782

gerritbot added a project: Patch-For-Review.Jan 8 2020, 10:05 AM

I drafted a patch for this, but won't have enough time to clean it up .. it works fine now, but the code is not the prettiest. Specifically, it might require some clean-up around where TermCollisionDetector instances come from, as for these two special pages we are getting them directly from WikibaseRepo (where it is determined whether we are using new store or not) but inside TermsValidatorFactory it is done using another layer of indirection (with ByIdFingerprintUniquenessValidator) and so on.. but probably it is better to do such clean up when migration is done and temporary stuff are removed.

sarhan.alaa claimed this task.Jan 8 2020, 10:10 AM

sarhan.alaa added a subscriber: sarhan.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 8 2020, 10:15 AM

Jenkins is failing.

Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Jan 9 2020, 9:49 AM

Ladsgroup claimed this task.Jan 9 2020, 10:05 AM

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 9 2020, 10:05 AM

Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 9 2020, 10:15 AM

Change 562782 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update new enitty specials to check fingerprint uniqueneness in new store

https://gerrit.wikimedia.org/r/562782

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.15; 2020-01-14); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Jan 10 2020, 9:00 AM

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 10 2020, 9:05 AM