Page MenuHomePhabricator
Create Task
Maniphest T242326

Wikibase Client PageTerms api module should not use SqlTermIndex directly
Closed, ResolvedPublic
Actions

Description

Part of T208425: [EPIC] Kill the wb_terms table, discovered while looking into T242096: SingleEntitySourceServices PrefetchingTermLookup should use new terms storage

Details

SubjectRepoBranchLines +/-
Use Assert more in TermLookup implementationsmediawiki/extensions/Wikibasemaster+20 -32
wbterms, Use TermBuffer not TermIndex in PageTerms apimediawiki/extensions/Wikibasemaster+134 -242
wbterms: Add AliasTermBuffermediawiki/extensions/Wikibasemaster+293 -41
wbterms: adopt getPrefetchedAliases for PrefetchingTermLookupmediawiki/extensions/WikibaseMediaInfomaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 9 2020, 9:31 AM
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 9 2020, 9:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 9 2020, 9:31 AM
gerritbot added a comment.Jan 9 2020, 9:31 AM

Change 563135 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] wbterms, Use TermBuffer not TermIndex in PageTerms api

https://gerrit.wikimedia.org/r/563135

gerritbot added a project: Patch-For-Review.Jan 9 2020, 9:31 AM
Addshore added a parent task: T236979: Fix remaining usecases still reading from old wb_terms schema.Jan 9 2020, 9:32 AM
Addshore mentioned this in T208425: [EPIC] Kill the wb_terms table.
Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Jan 9 2020, 9:49 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 9 2020, 10:15 AM
WMDE-leszek subscribed.Jan 9 2020, 11:09 AM
Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 10 2020, 10:16 AM
gerritbot added a comment.Jan 10 2020, 12:55 PM

Change 563428 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseMediaInfo@master] wbterms: adopt getPrefetchedAliases for PrefetchingTermLookup

https://gerrit.wikimedia.org/r/563428

gerritbot added a comment.Jan 10 2020, 12:55 PM

Change 563411 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] wbterms: Add AliasTermBuffer

https://gerrit.wikimedia.org/r/563411

Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 10 2020, 12:58 PM
gerritbot added a comment.Jan 13 2020, 9:55 AM

Change 563971 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Use Assert more in TermLookup implementations

https://gerrit.wikimedia.org/r/563971

gerritbot added a comment.Jan 13 2020, 10:35 AM

Change 563428 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] wbterms: adopt getPrefetchedAliases for PrefetchingTermLookup

https://gerrit.wikimedia.org/r/563428

gerritbot added a comment.Jan 13 2020, 10:56 AM

Change 563411 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms: Add AliasTermBuffer

https://gerrit.wikimedia.org/r/563411

gerritbot added a comment.Jan 13 2020, 11:00 AM

Change 563135 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms, Use TermBuffer not TermIndex in PageTerms api

https://gerrit.wikimedia.org/r/563135

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 13 2020, 11:00 AM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 13 2020, 12:54 PM
Addshore closed this task as Resolved.Jan 15 2020, 5:08 PM
gerritbot added a comment.Sep 15 2021, 8:36 AM

Change 563971 abandoned by Addshore:

[mediawiki/extensions/Wikibase@master] Use Assert more in TermLookup implementations

Reason:

https://gerrit.wikimedia.org/r/563971

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL