VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model
Closed, ResolvedPublicBUG REPORT
Actions

Description

There should be no such thing as visual mode for diffs of non-wikitext pages. So these buttons should be hidden.

Steps to Reproduce:

Enable VisualDiff beta feature.
Visit a diff both in mobile mode and desktop mode. eg. https://www.mediawiki.org/w/index.php?title=MediaWiki:Gadget-rtrc.js&diff=2175617 and https://m.mediawiki.org/wiki/Special:MobileDiff/2175617.
Compare them

Results:

The two toggle buttons unexpectedly appear in the mobile diff page while they are missing from the desktop diff page.

Details

	Subject	Repo	Branch	Lines +/-
	Ensure diff engine uses the correct title	mediawiki/extensions/MobileFrontend	master	+8 -3
	Use correct context for checking for MobileDiff	mediawiki/extensions/RevisionSlider	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		ovasileva	T242310 Regression: issues with MobileDiff
Resolved		• marcella	T242351 HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack)
Resolved	BUG REPORT	Esanders	T245172 VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model
Resolved		ovasileva	T243783 MobileDiff drops whitespaces from edits

Event Timeline

Masumrezarock100 removed • marcella as the assignee of this task.Feb 13 2020, 4:55 PM

Masumrezarock100 created this task.

Masumrezarock100 removed a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).

Masumrezarock100 added a subscriber: • marcella.

I did not see any toggle buttons.

In T245172#5881673, @Ammarpad wrote:

I did not see any toggle buttons.

Have you enabled the VisualDiff beta feature?

In T245172#5881730, @Masumrezarock100 wrote:

In T245172#5881673, @Ammarpad wrote:

I did not see any toggle buttons.

Have you enabled the VisualDiff beta feature?

I followed what "Steps to Reproduce" says. So that condition should be added there

Masumrezarock100 updated the task description. (Show Details)Feb 13 2020, 7:30 PM

I said this is about the VisualDiff extension. One can not see the buttons and use it unless they enable the beat feature in their preferences. That much should have been obvious. Regardless, I have now updated the task description to avoid any unnecessary confusion in future.

This is a bug in MobileFrontend. It looks like it passes "Special:MobileDiff" as the page title to the diff engine, rather than the real title of the page, so we have no way to detect the visual diff should be disabled.

I suggest Web-Team-Backlog to look into it since this appears to be a MF bug.
(I really hope Special:MobileDiff page will be removed and MF will use the core diff url. Current special:mobilediff creates a lot of problems for users.)

Current special:mobilediff creates a lot of problems for users.)

And desktop has traditionally causes a lot of problems for mobile users so that's why we are in this situation.

I really hope Special:MobileDiff page will be removed and MF will use the core diff url

That is the goal but is at least a six month project (if we're focused). I've began making several changes to push us in that direction in my volunteer time, but we're far from there. I currently have no partner in crime to speed that up.

I suggest Readers-Web-Backlog to look into it since this appears to be a MF bug.

Tracking is sufficient here. Readers Web are currently focused on desktop improvements so we're not going to get to this any time soon. VisualDiffs is currently only a beta feature so this particular issue impacts very few users which is why on a previous patchset I suggested the feature was hidden.

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 15 2020, 12:29 AM

In T245172#5886707, @Jdlrobson wrote:

Tracking is sufficient here. Readers Web are currently focused on desktop improvements so we're not going to get to this any time soon. VisualDiffs is currently only a beta feature so this particular issue impacts very few users which is why on a previous patchset I suggested the feature was hidden.

I agree with you. If the product owner of this feature agrees, it should be hidden on mobile. I am not sure if there is much demand for this feature on mobile (I haven't heard anyone asking for this, nor I found any prior phab tasks to enable it on mobile). Simply put, there are too many problems here, so I don't believe this is ready for production yet. The biggest one is the layout issue. The VisualDiff style currently doesn't match the unified diff style on mobile.

Jdlrobson removed a project: MobileFrontend.Feb 21 2020, 6:48 PM

Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.

Change 625922 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Ensure diff engine uses the correct title

https://gerrit.wikimedia.org/r/625922

gerritbot added a project: Patch-For-Review.Sep 8 2020, 2:32 PM

Esanders added a project: MobileFrontend.Sep 8 2020, 2:32 PM

Change 626706 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/RevisionSlider@master] Use correct context for checking for MobileDiff

https://gerrit.wikimedia.org/r/626706

thiemowmde added projects: Revision-Slider, WMDE-QWERTY-Sprint-2020-09-09.Sep 17 2020, 9:01 AM

thiemowmde moved this task from Sprint Backlog to Watching on the WMDE-QWERTY-Sprint-2020-09-09 board.

thiemowmde moved this task from Incoming to Watching on the Revision-Slider board.

Change 626706 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Use correct context for checking for MobileDiff

https://gerrit.wikimedia.org/r/626706

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 17 2020, 6:00 PM

Change 625922 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Ensure diff engine uses the correct title

https://gerrit.wikimedia.org/r/625922

Looks like no one wants to pull this on their workboard, so I'm just going to mark it as resolved. The patches fixed the issue for me locally.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 17 2020, 6:18 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 7:11 PM

Ammarpad mentioned this in T263937: Special:MobileDiff no longer allows viewing deleted diffs because of wrong context title.Sep 27 2020, 10:13 AM

VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content modelClosed, ResolvedPublicBUG REPORTActions