Page MenuHomePhabricator

114: Open compound diff in new tab
Closed, ResolvedPublicFeature

Description

Hi. I suggest to add an attribute target=_blank to links that open diffs between versions, at least in grouping mode. It will make the work much more convenient. Thank you.

Related Objects

StatusSubtypeAssignedTask
DeclinedDannyS712
ResolvedDannyS712
ResolvedFeatureDannyS712

Event Timeline

Restricted Application added a subscriber: DannyS712. · View Herald Transcript
IKhitron changed the subtype of this task from "Task" to "Feature Request".Feb 17 2020, 7:07 PM

You could just right click on it and open it in a new tab.

Funny. Of course, but all I want is avoid doing this hundreds of times every day. Now I run attr in console every time. Unfortunately, I couldn't find a way to catch the moment when all the lists are shown, so javascript could do something.

DannyS712 renamed this task from Open compound diff in new tab to 114: Open compound diff in new tab.Feb 17 2020, 11:07 PM
DannyS712 triaged this task as Medium priority.

I need to rewrite the whole link logic, and I should be able to do this as part of that

I don't see why we are not doing this for all diff links. Opening a link in the same tab just wastes time, because it would take some time to load the watchlist once you click the back button and if you have a big watchlist with many unseen changes.

Done in 8.3.3

Does not work on Chrome. Will check on Firefox console later today.

Done in 8.3.3

Does not work on Chrome. Will check on Firefox console later today.

It does for me...

Weird. Well, it's the same Chrome on which my Watchlist Manager new tabs work well...

Weird. Well, it's the same Chrome on which my Watchlist Manager new tabs work well...

Maybe another script is conflicting?

With html element attribute? Not realistic. Let's see the console later on.

Found the problem, @DannyS712. Forget about it.