Convert TrackingCategories to a service with DI
Closed, ResolvedPublic
Actions

Description

the TrackingCategories class uses

$wgTrackingCategories (via Config)
$wgEnableMagicLinks (via Config)
the NamespaceInfo service
Multiple title calls that could be done via a TitleFactory

I suggest that it be converted to a service with these injected (currently created with a Config object, but still retrieves nsinfo and uses Title:: repeatedly)

Details

	Subject	Repo	Branch	Lines +/-
	Convert TrackingCategories to a service with DI	mediawiki/core	master	+86 -23
	Make TrackingCategories into a service	mediawiki/core	master	+26 -5

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T259960 Inject services into API modules and special pages
Open	Feature	None	T76290 Add module to get the list of all TrackingCategories
Resolved		cscott	T247194 Convert TrackingCategories to a service with DI

Event Timeline

DannyS712 created this task.Mar 8 2020, 11:36 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 8 2020, 11:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Mar 8 2020, 11:37 AM

DannyS712 added a parent task: T35033: [DO NOT USE] Tracking categories (tracking) [superseded by #MediaWiki-TrackingCategories].Mar 8 2020, 11:49 AM

I guess you need an approval of this plan from the CPT. Moving into triage meeting inbox to discuss.

DannyS712 mentioned this in T76290: Add module to get the list of all TrackingCategories.Mar 12 2020, 6:58 PM

DannyS712 added a project: MediaWiki-TrackingCategories.Mar 13 2020, 6:02 PM

DannyS712 removed a project: MediaWiki-Categories.

DannyS712 removed a parent task: T35033: [DO NOT USE] Tracking categories (tracking) [superseded by #MediaWiki-TrackingCategories].

• AMooney moved this task from Triage Meeting Inbox to Feature Requests to Review on the Platform Engineering board.Mar 17 2020, 8:10 PM

DannyS712 added a project: Dependency injection.Mar 20 2020, 5:38 PM

In T247194#5958987, @Pchelolo wrote:

I guess you need an approval of this plan from the CPT. Moving into triage meeting inbox to discuss.

{{ping}} Any updates?

daniel moved this task from Feature Requests to Review to Tech Planning Review on the Platform Engineering board.May 7 2020, 4:17 PM

looks good at a glance

Unlicking, probably won't get to this soon

Umherirrender added a subtask: T259960: Inject services into API modules and special pages.Oct 13 2020, 7:40 PM

Umherirrender removed a subtask: T259960: Inject services into API modules and special pages.Oct 13 2020, 8:15 PM

Umherirrender added a parent task: T259960: Inject services into API modules and special pages.

Change 634090 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Convert TrackingCategories to a service with DI

https://gerrit.wikimedia.org/r/634090

gerritbot added a project: Patch-For-Review.Oct 14 2020, 11:04 PM

DannyS712 claimed this task.Oct 14 2020, 11:19 PM

DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.

DannyS712 added a project: Platform Team Workboards (External Code Reviews).Oct 15 2020, 12:57 AM

Aklapper added a parent task: T76290: Add module to get the list of all TrackingCategories.Oct 19 2020, 4:23 PM

Change 728563 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Make TrackingCategories into a service

https://gerrit.wikimedia.org/r/728563

Change 728563 abandoned by C. Scott Ananian:

[mediawiki/core@master] Make TrackingCategories into a service

Reason: