Page MenuHomePhabricator
Create Task
Maniphest T249169

Can't edit page after switching editors on mobile phone
Closed, ResolvedPublic
Actions

Description

Hello,

I can't edit this page at Czech Wikipedia: https://cs.m.wikipedia.org/wiki/Wikipedista:Patriccck/Wikiv%C5%A1em.

Try this steps:

  1. Edit the page in source editor and type some text.
  2. Switch to the Visual Editor and type some text.
  3. Switch back to source editor, type some text and try to publish changes.

Screenshot_20200401-220235_Chrome.jpg (2×1 px, 438 KB)

Details

SubjectRepoBranchLines +/-
EditorGateway: Fix handling of null sectionIdmediawiki/extensions/MobileFrontendwmf/1.35.0-wmf.26+4 -4
EditorGateway: Fix handling of null sectionIdmediawiki/extensions/MobileFrontendmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Patriccck created this task.Apr 1 2020, 8:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 8:13 PM
Patriccck added a comment.EditedApr 1 2020, 8:43 PM

Another Czech Wikipedia user (User:Jan Myšák) tried it but it doesn't work.

gerritbot added a comment.Apr 1 2020, 9:24 PM

Change 585327 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] EditorGateway: Fix handling of null sectionId

https://gerrit.wikimedia.org/r/585327

gerritbot added a project: Patch-For-Review.Apr 1 2020, 9:24 PM
matmarex claimed this task.Apr 1 2020, 9:24 PM
matmarex added projects: Editing-team (Q3 2019-2020 Kanban Board), Regression.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.

Caused by rEMFR8c0447156626: Allow section "numbers" like 'T-1' in the editors (which fixed T198011).

gerritbot added a comment.Apr 2 2020, 5:23 PM

Change 585327 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] EditorGateway: Fix handling of null sectionId

https://gerrit.wikimedia.org/r/585327

gerritbot added a comment.Apr 2 2020, 5:55 PM

Change 585555 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@wmf/1.35.0-wmf.26] EditorGateway: Fix handling of null sectionId

https://gerrit.wikimedia.org/r/585555

gerritbot added a comment.Apr 2 2020, 6:21 PM

Change 585555 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.35.0-wmf.26] EditorGateway: Fix handling of null sectionId

https://gerrit.wikimedia.org/r/585555

Stashbot added a comment.Apr 2 2020, 6:27 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-02T18:27:51Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.26/extensions/MobileFrontend/: SWAT: 4e2a092: EditorGateway: Fix handling of null sectionId (T249169) (duration: 01m 09s)

matmarex edited projects, added Editing QA, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31); removed Patch-For-Review.Apr 2 2020, 6:50 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

The bug affects wmf.25 and wmf.26. I only backported it to wmf.26 for consistency with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/585554. wmf.26 should be deployed everywhere in a few hours.

Jdforrester-WMF subscribed.Apr 2 2020, 7:18 PM
In T249169#6024001, @matmarex wrote:

The bug affects wmf.25 and wmf.26. I only backported it to wmf.26 for consistency with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/585554. wmf.26 should be deployed everywhere in a few hours.

Deployed everywhere now.

Patriccck closed this task as Resolved.Apr 2 2020, 7:42 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 2 2020, 7:42 PM
Patriccck added a comment.Apr 2 2020, 7:44 PM

I tested and it works. Thank you so much!

Jdlrobson subscribed.Apr 2 2020, 10:25 PM

Thanks for SWATing!

Jdlrobson added a comment.Apr 2 2020, 10:31 PM
This comment was removed by Jdlrobson.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL