Section edit icon not displaying in Minerva skin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DonTrung
	Apr 9 2020, 7:25 PM

Description

Can't see "edit" icon for section headings on mobile

For whatever reason I can't see any "edit pencils ✏ " (or pens) while I use the "Mobile view".

wp_ss_20200409_0002.png (2×1 px, 426 KB)

wp_ss_20200409_0001.png (2×1 px, 350 KB)

I have this issue on all Wikimedia websites, and started experiencing it sometime after 21:00 (Central European Time).

QA Results - Prod

AC	Status	Details
1	✅	T249864#6053640

Details

	Subject	Repo	Branch	Lines +/-
	Update the icon glyph	mediawiki/skins/MinervaNeue	wmf/1.35.0-wmf.27	+1 -1
	Update the icon glyph	mediawiki/skins/MinervaNeue	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T244444: Replace all possible, non-product specific icons in MobileFrontend/MinervaNeue with WikimediaUI/OOUI ones

Event Timeline

DonTrung created this task.Apr 9 2020, 7:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2020, 7:25 PM

I forgot to note that I do see them on the top of the page, just not anywhere else.

I also have it, the button works, only the pencil is missing

Reedy added projects: MobileFrontend, Mobile.Apr 9 2020, 11:06 PM

Gustmd7410 subscribed.Apr 10 2020, 4:42 AM

Gustmd7410 unsubscribed.

Ammarpad merged a task: T249899: mobile/minerva section edit icon (pencil) not visible.Apr 10 2020, 5:18 AM

Ammarpad added subscribers: Kipod, Masumrezarock100.

fwiw, i added to mediawiki:minerva.js on hewiki the following line, and the pencils are visible again.

$(function() {$('h2.section-heading a').addClass('mw-ui-icon-wikimedia-edit-base20'); } );

this is not a "solution", but it will re-enable mobile section edit, until a real fix is deployed, if you want it on your wiki. true, section edit is still possible, if the editor knows that an "invisible button" is there, but most do not know this secret.

peace.

@Kipod , thanks for creating the (provisional) solution.

@DonTrung: Hi, please always include browser / operating system information, clear steps to reproduce, links.
Please see and follow https://www.mediawiki.org/wiki/How_to_report_a_bug when creating tasks - thanks.

Pcoombe added projects: MinervaNeue, Regression.Apr 10 2020, 8:12 AM

taavi subscribed.Apr 10 2020, 9:16 AM

CyberTroopers subscribed.Apr 10 2020, 9:22 AM

Lol this is funny.. invisible pencil

Ahmad252 subscribed.Apr 10 2020, 2:59 PM

Also broken in desktop view, if using minerva skin

Added @Kipod 's patch to enwiki.

Caused by T244444

Jdlrobson added a subscriber: Volker_E.Apr 10 2020, 4:53 PM

Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 10 2020, 5:42 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.

Change 588021 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Update the icon glyph

https://gerrit.wikimedia.org/r/588021

gerritbot added a project: Patch-For-Review.Apr 10 2020, 5:43 PM

Change 588021 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update the icon glyph

https://gerrit.wikimedia.org/r/588021

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2020, 6:10 PM

Jdlrobson assigned this task to Edtadros.Apr 10 2020, 6:35 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.

Pcoombe subscribed.Apr 10 2020, 8:13 PM

• 4nn1l2 subscribed.Apr 10 2020, 10:46 PM

Jdlrobson merged a task: T249980: Cannot see a pencil icon in Korean Wikipedia.Apr 11 2020, 5:21 AM

Jdlrobson added subscribers: MotokoCK, revi.

Now I can see the edit icons in English Wikipedia, but not yet in Korean Wikipedia.

In T249864#6048316, @MotokoCK wrote:

Now I can see the edit icons in English Wikipedia, but not yet in Korean Wikipedia.

The relevant patch has not been deployed to any production wiki. English Wikipedia employed a temporary hack at en:MediaWiki:Minerva.js. You can use it if necessary.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 11 2020, 10:00 AM

Larske subscribed.Apr 11 2020, 6:53 PM

Jmar67 subscribed.Apr 11 2020, 7:00 PM

Sorry, please delete. New here.

Thought I had added an action. Please ignore.

The temporary fix applies to level 2 (h2) only. I do not see pencils at level 3, but can still edit.

Rendering the mobile edit interface useless. This could be backported on Monday.

Sakretsu subscribed.Apr 11 2020, 9:38 PM

Aftabuzzaman subscribed.Apr 11 2020, 11:21 PM

Xiplus subscribed.Apr 13 2020, 2:22 AM

eranroz subscribed.Apr 13 2020, 4:22 AM

Stryn subscribed.Apr 13 2020, 12:21 PM

Change 588405 had a related patch set uploaded (by Niedzielski; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.35.0-wmf.27] Update the icon glyph

https://gerrit.wikimedia.org/r/588405

gerritbot added a project: Patch-For-Review.Apr 13 2020, 1:28 PM

Jdlrobson moved this task from Needs QA to Needs QA in Prod on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 13 2020, 5:07 PM

Change 588405 merged by Niedzielski:
[mediawiki/skins/MinervaNeue@wmf/1.35.0-wmf.27] Update the icon glyph

https://gerrit.wikimedia.org/r/588405

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.27; 2020-04-07); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 13 2020, 7:00 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-13T19:02:46Z] <niedzielski@deploy1001> Synchronized php-1.35.0-wmf.27/skins/MinervaNeue: SWAT: [[gerrit:588405|Update the icon glyph (T249864)]] (duration: 01m 00s)

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2020, 7:11 PM

I could see "the edit pencil ✏" again, I think since yesterday. Thanks everyone for your hard work "behind the curtains", keep being awesome. 😉