Update external JS loading for CSP friendlyness
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Apr 18 2020, 2:10 AM

Description

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ConfirmEdit/+/588051/15/hCaptcha/includes/HTMLHCaptchaField.php@29

Basically you have to call $out->getCSP()->addScriptSrc( "domain here");

Details

	Subject	Repo	Branch	Lines +/-
	Add Content Security Policy handling for ReCaptcha and hCaptcha	mediawiki/extensions/ConfirmEdit	REL1_35	+40 -0
	Add Content Security Policy handling for ReCaptcha and hCaptcha	mediawiki/extensions/ConfirmEdit	master	+40 -0

Customize query in gerrit

Event Timeline

Reedy created this task.Apr 18 2020, 2:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2020, 2:10 AM

Reedy added a project: ContentSecurityPolicy.Apr 18 2020, 2:12 AM

The same probably for reCaptcha as well, right?

Florian claimed this task.Apr 18 2020, 9:35 AM

Change 589841 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@master] Add CSP policies for hCaptcha and reCaptcha

https://gerrit.wikimedia.org/r/589841

gerritbot added a project: Patch-For-Review.Apr 18 2020, 9:50 AM

In T250544#6067810, @Florian wrote:

The same probably for reCaptcha as well, right?

Yeah. I guess it was mostly mentioned as it was new code.

Change 589841 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Add Content Security Policy handling for ReCaptcha and hCaptcha

https://gerrit.wikimedia.org/r/589841

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 29 2020, 4:01 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 4:10 AM

Change 637054 had a related patch set uploaded (by Reedy; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@REL1_35] Add Content Security Policy handling for ReCaptcha and hCaptcha

https://gerrit.wikimedia.org/r/637054

gerritbot added a project: Patch-For-Review.Oct 29 2020, 12:17 PM

Change 637054 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@REL1_35] Add Content Security Policy handling for ReCaptcha and hCaptcha

https://gerrit.wikimedia.org/r/637054

Reedy closed this task as Resolved.Oct 29 2020, 12:23 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 1:10 PM

Update external JS loading for CSP friendlynessClosed, ResolvedPublicActions

Description

Details

Event Timeline

Update external JS loading for CSP friendlyness
Closed, ResolvedPublic
Actions