Page MenuHomePhabricator

PCS should gracefully handle Notes section
Closed, ResolvedPublic

Assigned To
Authored By
MattCleinman
May 9 2020, 12:46 AM
Referenced Files
F31808645: IMG_8231.PNG
May 9 2020, 12:46 AM
F31808643: PCS notes.png
May 9 2020, 12:46 AM
F31808647: IMG_8230.PNG
May 9 2020, 12:46 AM
F31808642: IMG_8232.PNG
May 9 2020, 12:46 AM
F31808638: PCS tap from notes section.png
May 9 2020, 12:46 AM
F31808640: PCS tap note superscript.png
May 9 2020, 12:46 AM
F31808639: IMG_8233.PNG
May 9 2020, 12:46 AM
F31808646: PCS end of section.png
May 9 2020, 12:46 AM

Description

A few things to improve Notes in PCS. See subtasks.

Event Timeline

MattCleinman renamed this task from PCS Regression: Should gracefully handle notes to PCS Regression: Should gracefully handle Notes section.May 9 2020, 12:46 AM
MattCleinman updated the task description. (Show Details)

Thanks for writing this up and doing the regression! Just one "note":

  1. Reading - When reading in the article and tapping a notes superscript letter, the reference is shown as it's internal name (lower -alpha 10) rather than it's display name (something like j, for English wiki). See image 2 below.

^ This is an upstream issue that's tracked by T51538:

Parsoid doesn't know about special group names like "lower-alpha" etc. and treats them like other group names like "xyz", "books", etc.

JMinor renamed this task from PCS Regression: Should gracefully handle Notes section to PCS should gracefully handle Notes section.May 11 2020, 6:39 PM
JMinor updated the task description. (Show Details)

@MattCleinman Looks like this ticket lists multiple different issues. If that's the case I recommend adding sub-tickets for the individual issues or breaking this ticket into individual tickets some other way.

@MattCleinman Looks like this ticket lists multiple different issues. If that's the case I recommend adding sub-tickets for the individual issues or breaking this ticket into individual tickets some other way.

Thanks, done.

LGoto claimed this task.