Notify gadget users to update Vector scripts and styles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 11 2020, 7:23 PM

Description

On 20th and 21st May, as part of T249372: [Dev] DRY up the menu templating code, a minor technical change will be made to Vector to standardise menu HTML which will cause any gadgets or user styles containing the following selectors to break

#p-variants > ul
#p-namespaces > ul
#p-personal > ul
#p-views > ul
#p-cactions > ul

Migration strategy

for JS

The supported (official) solution to add menu items is using the mw.util.addPortletLink() JavaScript API (documented on mediawiki).
Using this API your code will be resilient to this change and will also work for all skins (presumably).

Adding a menu item with id #pt-somemenuitem to the START of #p-personal (the user menu):
mw.util.addPortletLink( 'p-personal', '<link href>', '<link text>', 'pt-somemenuitem', '<tooltip>', '<accesskey>', 'li:first' );

Adding a menu item with id #pt-somemenuitem to the END of #p-personal (the user menu):
mw.util.addPortletLink( 'p-personal', '<link href>', '<link text>', 'pt-somemenuitem', '<tooltip>', '<accesskey>', null );

for CSS

The above links should be updated to support the new selector by dropping the '>' character e.g. or strengthening the selectors to contain .vector-menu-content

e.g.

#p-variants  ul
#p-namespaces  ul
#p-personal  ul
#p-views  ul
#p-cactions  ul

Note: removed vector internals. Gadgets should use the public ids.

Possibly Impacted users

@Wetitpig0 @Yiyetianxiang @FTBabin @Wikimäths @נרו יאיר @Trooper777 @Grunny @Peterdownunder @BurritoBazooka @CoolCanuck @Stwalton @Xijia37 aokomoriuta @Wikisaurus @Алекснадр_Мехоношин @Green_WU @Frozen-mikan @ציון הלוי @Macedonia Apple @Atmark-chan @Thesecretaryofwar SalixAlba @Tobin.r.bell @Nka.eee @Yiyetianxiang @Geagea @:דולב @George_Orwell_III @~riley @Cole.ziegler @Steinsplitter @Mtorolite @Slomox @T_kns @George8211 @Vector2.0 @Iunknown110 @Speravir @Hanay @Se4598 @Fitindia @Geagea @Unready @NickTheTurtle @Nka.eee @SoledadKabocha @He7d3r

If you know any of the users above that are not linked - please help by messaging them and asking them to setup a Phabricator account as similar changes are likely over the next few months.

Potentially impacted pages

The change is limited to Vector and may impact the following pages:

Related Objects

Mentioned In: T256897: Decide on and clean up naming of CSS classes identifying menus in toolbars and the sidebar.
T252467: Notify editors and users to update their Vector gadgets and user scripts/styles on portal CSS selector simplification
T249372: [Dev] DRY up the menu templating code
T253929: User script no longer displaying before p-personal in Vector menu on Commons
Mentioned Here: T252467: Notify editors and users to update their Vector gadgets and user scripts/styles on portal CSS selector simplification
T249372: [Dev] DRY up the menu templating code

Event Timeline

Jdlrobson created this task.May 11 2020, 7:23 PM

Restricted Application added subscribers: Masumrezarock100, jeblad, Danmichaelo and 2 others. · View Herald TranscriptMay 11 2020, 7:23 PM

Jdlrobson updated the task description. (Show Details)May 11 2020, 7:24 PM

Volker_E subscribed.May 11 2020, 7:24 PM

RhinosF1 subscribed.May 11 2020, 7:43 PM

Can someone check if https://en.wikipedia.org/wiki/User:RhinosF1/StatusChange.js is impacted?

mw.util.addPortletLink(

"p-personal", //target tab - personal links

And fix if you can?

Jdlrobson renamed this task from Notify gadget users to update scripts and styles to Notify gadget users to update Vector scripts and styles.May 11 2020, 8:27 PM

Jdlrobson edited projects, added Vector (legacy skin) (Tracking); removed Vector (legacy skin).

Jdlrobson updated the task description. (Show Details)

Jdlrobson added subscribers: Atmark-chan, Wikisaurus, Fitindia and 14 others.

In T252447#6126579, @RhinosF1 wrote:
Can someone check if https://en.wikipedia.org/wiki/User:RhinosF1/StatusChange.js is impacted?

mw.util.addPortletLink(
"p-personal", //target tab - personal links
And fix if you can?

@RhinosF1 Your script should not be affected by change above.

Volker_E updated the task description. (Show Details)May 11 2020, 8:52 PM

Thanks @Volker_E

Jdlrobson added a project: Desktop Improvements (Vector 2022).May 11 2020, 9:01 PM

Jdlrobson updated the task description. (Show Details)

JJMC89 updated the task description. (Show Details)May 11 2020, 9:50 PM

JJMC89 added subscribers: SalixAlba, Riley_Huntley.

JJMC89 updated the task description. (Show Details)May 11 2020, 9:54 PM

JJMC89 added a subscriber: aokomoriuta.

Jdlrobson moved this task from To Triage to Announce in next Tech/News on the User-notice board.May 11 2020, 11:12 PM

Amorymeltzer subscribed.May 12 2020, 12:20 AM

aokomoriuta unsubscribed.May 12 2020, 12:41 AM

Added to Tech/News/2020/21 to be distributed on Monday.

Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.May 14 2020, 12:47 PM

• Jar subscribed.May 18 2020, 6:51 PM

Restricted Application added a subscriber: alaa. · View Herald TranscriptMay 18 2020, 6:51 PM

ovasileva triaged this task as Medium priority.May 20 2020, 9:40 AM

ovasileva moved this task from Incoming to Q1 2020-2021 on the Desktop Improvements (Vector 2022) board.

ovasileva added a project: Web-Team-Backlog (Tracking).

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.May 20 2020, 1:38 PM

Volker_E updated the task description. (Show Details)May 27 2020, 4:33 PM

Volker_E added a subscriber: aokomoriuta.

Jdlrobson merged a task: T253929: User script no longer displaying before p-personal in Vector menu on Commons.May 29 2020, 1:10 AM

Jdlrobson mentioned this in T253929: User script no longer displaying before p-personal in Vector menu on Commons.

Jdlrobson added subscribers: Josve05a, Basvb, Naypta.

aokomoriuta unsubscribed.May 29 2020, 3:16 AM

adminwatch.js does not works to me. What should I need to do to fix it?

OK, fixed it.

In T252447#6179587, @Geagea wrote:

adminwatch.js does not works to me. What should I need to do to fix it?
OK, fixed it.

@Geagea $( '#p-personal ul > li:first' ) will work for all skins. The > is removed between #p-personal and ul.

Yes thanks. fixed it.

In T252447#6179680, @Geagea wrote:

Yes thanks. fixed it.

I see. I just wanted to say that .vector-menu-content matches a few more menus, not just the personal menu. I'm not sure if that's important to you, but the following line would be more reliable:
.insertBefore( $( '#p-personal ul > li:first' ) );

• Demian mentioned this in T249372: [Dev] DRY up the menu templating code.May 31 2020, 9:34 AM

ok, changed it.

• Demian updated the task description. (Show Details)May 31 2020, 9:40 AM

• Demian updated the task description. (Show Details)

• Demian added a subscriber: aokomoriuta.

• Demian removed a subscriber: aokomoriuta.

In T252447#6179736, @Geagea wrote:

ok, changed it.

Is there any reason you can't use mw.util.addPortletLink here ?

and how to add it? nstead of what?

In T252447#6180426, @Geagea wrote:

and how to add it? nstead of what?

That needs quite a bit of tinkering. If you are interested in making this change, I've implemented it for you, just copy it: https://commons.wikimedia.org/wiki/User:Aron_Manning/adminwatch.js

If you're interested in the details, mediawiki has the documentation for mw.util.addPortletLink(). That is the supported (official) JS solution to add menu items.

• Demian updated the task description. (Show Details)Jun 1 2020, 3:28 AM

Ok I'v changed it.

SalixAlba unsubscribed.Jun 1 2020, 9:51 AM

SunAfterRain updated the task description. (Show Details)Jun 1 2020, 2:33 PM

SunAfterRain added a subscriber: SalixAlba.

SalixAlba unsubscribed.Jun 1 2020, 3:17 PM

• Demian updated the task description. (Show Details)Jun 1 2020, 3:33 PM

• Demian updated the task description. (Show Details)

• Demian added a subscriber: SalixAlba.

• Demian removed a subscriber: SalixAlba.

Jdlrobson awarded a token.Jun 1 2020, 4:47 PM

He7d3r updated the task description. (Show Details)Jun 18 2020, 11:22 AM

He7d3r subscribed.

Iniquity added a project: Tech Ambassadors & Translators.Jun 19 2020, 7:33 PM

Iniquity moved this task from Backlog to Mostly FYI (take action if you want) on the Tech Ambassadors & Translators board.

@Jdlrobson for better discoverability I believe this task is a child of T249372: [Dev] DRY up the menu templating code
You don't mind if I set that relation?

• Demian updated the task description. (Show Details)Jul 1 2020, 5:12 PM

• Demian mentioned this in T252467: Notify editors and users to update their Vector gadgets and user scripts/styles on portal CSS selector simplification.

• Demian mentioned this in T256897: Decide on and clean up naming of CSS classes identifying menus in toolbars and the sidebar..Jul 1 2020, 5:28 PM

ovasileva moved this task from Q1 2020-2021 to Community/Analytics Conversations on the Desktop Improvements (Vector 2022) board.Aug 31 2021, 8:50 PM

Jdlrobson closed this task as Resolved.Sep 30 2021, 9:24 PM

Jdlrobson claimed this task.

Stang unsubscribed.Nov 13 2021, 11:58 PM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM

Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptAug 13 2022, 1:54 PM

Meno25 removed a subscriber: • Jar.Jan 14 2023, 10:30 PM