FallbackTemplate is being removed from core in 1.35. It was not intended for use outside core so will not follow the deprecation process but currently is used by unit tests for the Wikibase and the CookieWarning extensions.
https://codesearch.wmflabs.org/search/?q=SkinFallbackTemplate&i=nope&files=&repos=
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't use FallbackTemplate inside tests | mediawiki/extensions/Wikibase | master | +3 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T254048 Render the FallbackSkin and SkinApi with a simplistic SkinMustache class | |||
| Resolved | Florian | T254525 Don't use internal FallbackTemplate inside code |
Event Timeline
Comment Actions
They were likely picked because BaseTemplate is abstract so SkinFallbackTemplate was the only somewhat neutral non-abstract implementation in core to pick.
- Wikibase test: Straight-forward to replace by direct use of BaseTemplate with createMock().
- CookieWarning: Needs a real instance, e.g. via getMockBuilder and stub execute().
Comment Actions
Change 602772 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Wikibase@master] Don't use FallbackTemplate inside tests
Comment Actions
CookieWarning is not deployed anywhere on Wikimedia from what I can see so I don't think that should block the core change.
Comment Actions
Change 602772 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don't use FallbackTemplate inside tests