Page MenuHomePhabricator
Create Task
Maniphest T255502

Goal: Save Timing median back under 1 second
Open, HighPublic
Actions

Description

This is a tracking task for the annual goal of bringing save timing back to under one second, and doing what is needed to make it likely for the org as a whole to keep staying under it.

Definition

(This is still a draft).

Loosely: The time it takes for users to save their edit on wikitext content pages.

Concretely: TBD.

Goal
  • Median: under 1 second for a 24 hour period with no known incidents or data loss.
  • p75: under 1.5 second for 24 hour period with no known incidents or data loss.
See also

Details

SubjectRepoBranchLines +/-
IPSet: Remove AtEase overhead from hot code pathIPSetmaster+6 -6
Use lazypush for queuing jobsmediawiki/extensions/Echomaster+3 -3
watcheditem: Use lazy push for WatchlistExpiryJobmediawiki/coremaster+1 -1
Lazy push CacheInvalidator jobmediawiki/extensions/Cognatemaster+2 -2
Use lazypush for queuing job of onLinksUpdateCompleted hookmediawiki/extensions/CirrusSearchmaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT255502 Goal: Save Timing median back under 1 second
 ResolvedaaronT253679 Dedicated Flamegraphs for save timing
 DeclinedNoneT238493 Frontend save timing regression on/after 30 October 2019
 OpenNoneT225961 Add wiki group breakdown of backend save timing to grafana
 OpenNoneT214460 Add synthetic testing for editing process (save timing)
 OpenNoneT254805 Document Wptuser account on English Wikipedia
 OpenNoneT237708 Audit page parsing time (2020)
 ResolvedaaronT267061 Save Timing regression starting around 2020-10-27
 DuplicateaaronT270273 Instrument major parts of save timing
 OpenNoneT245464 Use php-hrtime monotonic clock instead of microtime for perf measure in MW
 ResolvedKrinkleT277788 Save Timing improvements (2021-2022)
 ResolvedLadsgroupT283029 FlaggableWikiPage::preloadPreparedEdit() does not actually carry over the parser output, leading to double parses on save
 ResolvedLadsgroupT292300 Eliminate unnecessary duplicate parses (2021-2022)
 Resolved• PcheloloT292302 CommonsMetadata extension causes every page on commons to be always parsed twice
 Openmatej_suchanekT264104 Verify AbuseFilter code that claims to share and re-use ParserOutput from core
 ResolvedmatmarexT301309 Refreshlinks job is parsing pages twice
 ResolvedLadsgroupT301310 CommonsMetadata extension is triggering a duplicate parse in commons
 ResolvedLadsgroupT297147 RevisionStore::newRevisionSlots() needs a cache
 ResolvedLadsgroupT285987 Do not generate full html parser output at the end of Wikibase edit requests
 ResolvedLadsgroupT288639 SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice
 ResolvedLadsgroupT269960 Schema properties in client code loads the whole item in every page view
 DeclinedaaronT304283 Backend save timing regression 2021-03-21
 ResolvedtstarlingT300075 P75 Edit response time has almost doubled since Jan 11, 2022
 ResolvedaaronT322823 Restore ability for PageEditStash to store "large" ParserOutput/Content objects with value segmentation
 ResolvedMarosteguiT263127 Remove groups from db configs
 Resolved• nnikkhouiT267077 Document remaining database load groups
ResolvedaaronT225968 Profile and visualise time spent per component/extension in MW entry points
 ResolvedaaronT330810 Add variable to track the entry point action/handler for a request for use with metrics
 OpenNoneT315165 Enable edit stashing on section=new edits
 DuplicateNoneT321613 Add statsd to TransactionProfiler
 OpenNoneT321966 Support igbinary with SqlBagOStuff
 OpenLadsgroupT337431 Rework MediaWiki:SpamBlacklist
 OpenNoneT345769 Migrate SaveTiming away from Statsd/Graphite
 OpenNoneT289923 Let AbuseFilter cache its parser AST result
 OpenNoneT290454 Create a new RuleChecker class to transform string rules into result objects
 OpenNoneT189821 Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor)
 OpenNoneT189824 Expose api-stashedit JS to non-legacy textarea editors

Event Timeline

Krinkle created this task.Jun 15 2020, 9:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 9:39 PM
Krinkle updated the task description. (Show Details)Jun 15 2020, 9:39 PM
Krinkle added a comment.Jun 15 2020, 9:42 PM

(This is still a draft).

Loosely: The time it takes for users to save their edit on wikitext content pages.

Concretely: TBD.

Strawman:

  • Metric: Frontend Save Timing.
  • Aggregate: group2 wikis.
    • We don't yet have it by content model, and group2 (Wikipedia) is a good approximation to exclude non-wikitext from Wikidata, Commons, Meta and Wikisource. But maybe we should just add content model to SaveTiming schema and do a by-contentmodel breakdown for Frontend Save Timing, as we already do for backend save timing.

https://grafana.wikimedia.org/d/000000085/save-timing?orgId=1

Krinkle added a subtask: T253679: Dedicated Flamegraphs for save timing.Jun 15 2020, 9:42 PM
Krinkle added a subtask: T238493: Frontend save timing regression on/after 30 October 2019.
Krinkle added a parent task: T214460: Add synthetic testing for editing process (save timing).
Krinkle added a subtask: T225961: Add wiki group breakdown of backend save timing to grafana.
Krinkle removed a parent task: T214460: Add synthetic testing for editing process (save timing).
Krinkle added a subtask: T214460: Add synthetic testing for editing process (save timing).
Krinkle renamed this task from Save Timing median under 1 second (FY2020-2021) to FY2020-2021: Save Timing median under 1 second.Jun 15 2020, 9:44 PM
Krinkle added a subtask: T237708: Audit page parsing time (2020).
Krinkle mentioned this in T237708: Audit page parsing time (2020).
• Gilles moved this task from Inbox, needs triage to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.Jun 22 2020, 8:02 PM
Krinkle triaged this task as High priority.Jun 22 2020, 8:02 PM
Krinkle closed subtask T253679: Dedicated Flamegraphs for save timing as Resolved.Jul 27 2020, 8:22 PM
ori subscribed.Aug 4 2020, 8:02 PM
• Gilles closed subtask T238493: Frontend save timing regression on/after 30 October 2019 as Declined.Oct 20 2020, 8:00 PM
Krinkle added a subtask: T270273: Instrument major parts of save timing.Dec 21 2020, 7:55 PM
Krinkle added a subtask: T245464: Use php-hrtime monotonic clock instead of microtime for perf measure in MW.Feb 16 2021, 3:49 PM
Krinkle renamed this task from FY2020-2021: Save Timing median under 1 second to FY2021-2022: Save Timing median under 1 second.Mar 25 2021, 8:44 PM
Krinkle added a subtask: T263127: Remove groups from db configs.
Ladsgroup subscribed.Apr 27 2021, 9:49 AM

An observation from Wikidata. Most of our save time (60%) is going through all abuse filters. I know your focus is Wikipedia and Daimona has done a lot to improve abuse filter performance but maybe we can look further into it (possibly with some community engagement to clean up unused, old ones).

Regardless. Great initiative! Let me know if I can help on anything.

Krinkle added a subtask: T225968: Profile and visualise time spent per component/extension in MW entry points.Jun 2 2021, 3:43 PM
Paladox subscribed.Sep 8 2021, 9:30 PM
gerritbot added a comment.Sep 29 2021, 7:04 PM

Change 724820 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/CirrusSearch@master] Use lazypush for queuing job of onLinksUpdateCompleted hook

https://gerrit.wikimedia.org/r/724820

gerritbot added a project: Patch-For-Review.Sep 29 2021, 7:04 PM
gerritbot added a comment.Sep 29 2021, 7:15 PM

Change 724826 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Echo@master] Use lazypush for queuing jobs

https://gerrit.wikimedia.org/r/724826

gerritbot added a comment.Sep 30 2021, 12:38 PM

Change 724820 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Use lazypush for queuing job of onLinksUpdateCompleted hook

https://gerrit.wikimedia.org/r/724820

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 30 2021, 1:00 PM
gerritbot added a comment.Oct 1 2021, 8:18 AM

Change 725258 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Lazy push WatchlistExpiryJob

https://gerrit.wikimedia.org/r/725258

gerritbot added a comment.Oct 1 2021, 8:23 AM

Change 725259 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Cognate@master] Lazy push CacheInvalidator job

https://gerrit.wikimedia.org/r/725259

gerritbot added a comment.Oct 1 2021, 11:08 AM

Change 725259 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Lazy push CacheInvalidator job

https://gerrit.wikimedia.org/r/725259

Ladsgroup mentioned this in rECOG97dba76d3c38: Lazy push CacheInvalidator job.Oct 1 2021, 11:09 AM
gerritbot added a comment.Oct 1 2021, 2:53 PM

Change 725258 merged by jenkins-bot:

[mediawiki/core@master] watcheditem: Use lazy push for WatchlistExpiryJob

https://gerrit.wikimedia.org/r/725258

gerritbot added a comment.Oct 4 2021, 6:07 AM

Change 724826 abandoned by Ladsgroup:

[mediawiki/extensions/Echo@master] Use lazypush for queuing jobs

Reason:

This one doesn't give much benefit, the ones that do are already fixed now.

https://gerrit.wikimedia.org/r/724826

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2021, 6:10 AM
Krinkle added a subtask: T292300: Eliminate unnecessary duplicate parses (2021-2022).Oct 4 2021, 7:34 PM
Krinkle removed a subtask: T292300: Eliminate unnecessary duplicate parses (2021-2022).
Krinkle renamed this task from FY2021-2022: Save Timing median under 1 second to FY2021-2022: Save Timing median back under 1 second.Dec 14 2021, 10:57 PM
Krinkle removed a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).
Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)
Marostegui closed subtask T263127: Remove groups from db configs as Resolved.Feb 11 2022, 9:02 AM
Krinkle closed subtask T245464: Use php-hrtime monotonic clock instead of microtime for perf measure in MW as Declined.Aug 10 2022, 1:06 AM
Krinkle reopened subtask T245464: Use php-hrtime monotonic clock instead of microtime for perf measure in MW as Open.
Krinkle added a subtask: T315165: Enable edit stashing on section=new edits.Aug 15 2022, 3:24 PM
aaron closed subtask T267061: Save Timing regression starting around 2020-10-27 as Resolved.Oct 4 2022, 6:31 PM
aaron closed subtask T315165: Enable edit stashing on section=new edits as Declined.Oct 4 2022, 7:58 PM
aaron reopened subtask T315165: Enable edit stashing on section=new edits as Open.
Krinkle mentioned this in T216744: libpcre-related performance opportunities.Oct 8 2022, 4:06 AM
Krinkle added a subtask: T321613: Add statsd to TransactionProfiler.Oct 25 2022, 11:48 PM
Krinkle added a subtask: T321966: Support igbinary with SqlBagOStuff.Oct 31 2022, 7:53 PM
Krinkle added a subtask: T322823: Restore ability for PageEditStash to store "large" ParserOutput/Content objects with value segmentation.Dec 13 2022, 10:40 PM
aaron closed subtask T322823: Restore ability for PageEditStash to store "large" ParserOutput/Content objects with value segmentation as Resolved.Dec 14 2022, 10:55 PM
Krinkle added a subtask: T337431: Rework MediaWiki:SpamBlacklist.Jun 7 2023, 7:56 PM
Novem_Linguae subscribed.Jun 7 2023, 8:02 PM
Krinkle moved this task from To-do: Goals, prioritized next 4 Quarters to Backlog: Future Goals, non-prioritized on the Performance-Team board.Jun 15 2023, 5:31 PM
Krinkle edited projects, added MediaWiki-Platform-Team; removed Performance-Team.Aug 28 2023, 1:57 PM
Krinkle added a subtask: T345769: Migrate SaveTiming away from Statsd/Graphite.Sep 16 2023, 7:05 AM
Krinkle added a subtask: T289923: Let AbuseFilter cache its parser AST result.
Krinkle renamed this task from FY2021-2022: Save Timing median back under 1 second to Goal: Save Timing median back under 1 second.Sep 16 2023, 7:09 AM
Krinkle added a subtask: T189821: Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor).
Krinkle closed subtask T277788: Save Timing improvements (2021-2022) as Resolved.Sep 16 2023, 7:16 AM
Krinkle mentioned this in T277788: Save Timing improvements (2021-2022).
gerritbot added a comment.Sep 16 2023, 7:22 AM

Change 957993 had a related patch set uploaded (by Krinkle; author: Krinkle):

[IPSet@master] IPSet: Remove AtEase overhead from hot code path

https://gerrit.wikimedia.org/r/957993

gerritbot added a project: Patch-For-Review.Sep 16 2023, 7:22 AM
gerritbot added a comment.Sep 16 2023, 8:03 AM

Change 957993 merged by jenkins-bot:

[IPSet@master] IPSet: Remove AtEase overhead from hot code path

https://gerrit.wikimedia.org/r/957993

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2023, 8:10 AM
Krinkle mentioned this in rMLIP5f6d1c7fde21: IPSet: Remove AtEase overhead from hot code path.Sep 24 2023, 3:31 AM
colewhite changed the status of subtask T245464: Use php-hrtime monotonic clock instead of microtime for perf measure in MW from Open to In Progress.Oct 12 2023, 8:11 PM
larissagaulia moved this task from Inbox, needs triage to Within 2 Qs on the MediaWiki-Platform-Team board.Oct 16 2023, 3:20 PM
colewhite changed the status of subtask T245464: Use php-hrtime monotonic clock instead of microtime for perf measure in MW from In Progress to Open.Jan 19 2024, 9:13 PM
Krinkle closed subtask T225968: Profile and visualise time spent per component/extension in MW entry points as Resolved.Mar 10 2024, 2:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL