Simplify logo CSS
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	• Demian
	Jul 1 2020, 4:44 PM

Description

Motivation

The logo currently uses flex layout with float fallback for some old browsers (patch). There is a simpler, compatible way to do this with just display: inline-block which is supported by browsers on our radar (ref).
Admittedly I've over-engineered those rules and I'd like to make up for the oversight.

Benefit

This reduces the number of CSS rules by about 5, mostly by eliminating the vendor prefixed flex rules.

The patch is a spin-off of T256893: Move the PersonalMenu to the header

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Jdlrobson	T16501 A way to hide the sidebar providing a "fullscreen" view
Resolved		ovasileva	T247032 [EPIC] Build collapsible sidebar and deploy to all test wikis
Resolved	Goal	ovasileva	T242131 [GOAL] Deploy new header to at least one test wiki
Resolved		Jdlrobson	T240856 [EPIC] New header for desktop improvements project
Duplicate		None	T54019 Vectorize all project logos
Resolved		Jdlrobson	T309972 [Goal] prepare desktop improvements project for further deployment
Duplicate	Spike	None	T244486 [GOAL] Create new logos for all projects for DI header and make sure everyone knows how to use them
Resolved		Jdlrobson	T251903 Translate's NaviToggle should be hidden in modern Vector
Resolved		ovasileva	T246419 Build collapsible sidebar and sidebar button
Resolved		ovasileva	T246170 Build new logo for Desktop Improvements Header
Duplicate		• Demian	T256895 Simplify logo CSS

Event Timeline

• Demian created this task.Jul 1 2020, 4:44 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 1 2020, 4:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 608255 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] [modern] Simplify Logo layout rules: use inline-block instead of float and flex

https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/ /608255

gerritbot added a project: Patch-For-Review.Jul 1 2020, 4:44 PM

• Demian updated the task description. (Show Details)Jul 1 2020, 4:51 PM

• Demian updated the task description. (Show Details)

Volker_E updated the task description. (Show Details)Jul 1 2020, 5:19 PM

• Demian mentioned this in T256893: Move the PersonalMenu to the header.Jul 5 2020, 4:11 PM

• Demian added a project: User-Demian.Jul 6 2020, 12:07 AM

• Demian moved this task from Incoming to Awaiting Review on the User-Demian board.Jul 6 2020, 1:00 AM

ovasileva moved this task from Incoming to Nice to Have on the Desktop Improvements (Vector 2022) board.Jul 24 2020, 3:36 PM

Jdlrobson mentioned this in T258544: Technical: Reconsider logo implementation.Jul 31 2020, 10:20 PM

Jdlrobson closed this task as a duplicate of T258544: Technical: Reconsider logo implementation.