Clean up user page link icon positioning in Vector
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Demian
	Jul 5 2020, 4:09 PM

Description

Motivation

The icon of #pt-anonuserpage, #pt-userpage is positioned with magic numbers. This is fragile and unresponsive (anti-pattern): the link text overlays the icon when increasing font-size.

Requirements

Icon positioning and size is responsive, no overlapping at uncommon font-size and viewport width.
Use of magic numbers minimized or eliminated.
The layout can be used on other menu items with a CSS class.

This work started in: T256893: Move the PersonalMenu to the header

Details

	Subject	Repo	Branch	Lines +/-
	[modern] Move user page icon to pseudo-element for reliable layout	mediawiki/skins/Vector	master	+29 -12

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T16501 A way to hide the sidebar providing a "fullscreen" view
Resolved	ovasileva	T247032 [EPIC] Build collapsible sidebar and deploy to all test wikis
Resolved	ovasileva	T258072 [REQUEST] QA Support on the new header
Resolved	ovasileva	T250375 QA VE with new header and collapsible sidebar
Resolved	Edtadros	T246420 Limit content width, and refine alignment & styling of relevant elements
Resolved	• Demian	T256893 Move the PersonalMenu to the header
Resolved	Jdlrobson	T257144 Clean up user page link icon positioning in Vector

Event Timeline

• Demian created this task.Jul 5 2020, 4:09 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 5 2020, 4:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Demian updated the task description. (Show Details)Jul 5 2020, 4:10 PM

• Demian mentioned this in T256893: Move the PersonalMenu to the header.

• Demian updated the task description. (Show Details)Jul 5 2020, 4:20 PM

• Demian updated the task description. (Show Details)

• Demian moved this task from Incoming to In progress on the User-Demian board.Jul 5 2020, 5:35 PM

• Demian moved this task from Unsorted to Cleanup on the Technical-Debt board.Jul 6 2020, 12:11 AM

• Demian added a project: Vector (legacy skin).Jul 6 2020, 12:22 AM

Change 609882 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] [modern] Move user page icon to pseudo-element for reliable layout

https://gerrit.wikimedia.org/r/609882

gerritbot added a project: Patch-For-Review.Jul 7 2020, 12:57 AM

Jdlrobson moved this task from Needs triage to Menus on the Vector (legacy skin) board.Jul 21 2020, 11:44 PM

ovasileva moved this task from Incoming to Nice to Have on the Desktop Improvements (Vector 2022) board.Jul 24 2020, 3:36 PM

• Demian moved this task from In progress to Denied on the User-Demian board.Nov 1 2020, 11:46 PM