Add tools to DiscussionTools' source mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Jul 8 2020, 12:30 AM

Description

This task is about adding a yet-to-be defined set of tools to the Reply and New Discussion tool's source mode.

Note: adding tools to the DiscussionTools' source mode depends on changes being made to the source mode's "editing surface".

Tool ideas

This sections contains a living list of tools we ought to consider adding.

Same tools that exist in the visual mode
- via user:ネイ posting at mw.org and other ja.wiki editors posting here: https://w.wiki/atr.
- via New Discussion Tool Junior Contributor usability testing: T243249#6684112.

Pinging
- via @Pelagic: https://w.wiki/WMb and https://w.wiki/bii
- via user: مستخدم:فيصل at ar.wiki: https://w.wiki/Xc$
- via @Urbanecm: "...would be possible to add the mention tool to the source editor as well? I use source editor most of the time, because it allows me to insert templates/links "easily" without using my mouse, but for mentions, I have to type it myself, or switch to the visual editor."
- T264520 is potentially relevant/a consequence of pinging not being available in source. via @DannyS712.
- "Oh, just now I found a button to mention a user in the Visual mode... I hadn't found it, sorry! But I also want to use it in the Source mode. Can you please do?" via @Atmark-chan at Topic:Vvzrgsaz3p0y1pcg.
- via @MJL on mediawiki.org here: https://www.mediawiki.org/w/index.php?title=Topic:Vyimdysriov7wls7
- via @DannyS712 in T264520
- via @Earwig (User:The_Earwig) on en.wiki here: https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project
- via @SQL (User:SQL) on en.wiki here: https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project
- via @Barkeep49 on en.wiki here: https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project
- via @Ahecht on en.wiki here: https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project
- via @Berrely on en.wiki here: https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project

Details

	Subject	Repo	Branch	Lines +/-
	Support the enable2017Wikitext option	mediawiki/extensions/DiscussionTools	master	+57 -33

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T294592 [EPIC] Ensure Talk Pages Project "Phase 1" work is easy to maintain, build upon, and learn from
Open	None	T276607 Converge on a single DiscussionTools source mode
Resolved	ppelberg	T276608 Offer the source mode with tools as an opt-in setting
Resolved	Esanders	T257391 Add tools to DiscussionTools' source mode
Resolved	Esanders	T275950 Introduce a setting for enabling the text editing toolbar in DiscussionTools' source mode

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2020, 12:30 AM

ppelberg renamed this task from Add tools to Reply tool's source mode to Add tools to DiscussionTools' source mode.Jul 8 2020, 12:33 AM

ppelberg updated the task description. (Show Details)

We will revisit the priority of this task if we receive more reports of users requesting this functionality

ppelberg updated the task description. (Show Details)Jul 23 2020, 12:40 AM

This user wants this functionality! At least give us the keyboard shortcuts.

In T257391#6304943, @JTannerWMF wrote:

We will revisit the priority of this task if we receive more reports of users requesting this functionality

@JTannerWMF It can be useful also for me.

In T257391#6382434, @Patriccck wrote:

In T257391#6304943, @JTannerWMF wrote:

We will revisit the priority of this task if we receive more reports of users requesting this functionality

@JTannerWMF It can be useful also for me.

@Patriccck is there a particular tool or tools you had in mind when writing the above? E.g. being able to access a tool like the visual mode's pinging feature?

ppelberg updated the task description. (Show Details)Sep 9 2020, 11:43 PM

Task description update
I've updated the task description to include the feedback user:ネイ shared at mw.org here: https://w.wiki/chN.

In T257391#6383246, @ppelberg wrote:

In T257391#6382434, @Patriccck wrote:

In T257391#6304943, @JTannerWMF wrote:

We will revisit the priority of this task if we receive more reports of users requesting this functionality

@JTannerWMF It can be useful also for me.

@Patriccck is there a particular tool or tools you had in mind when writing the above? E.g. being able to access a tool like the visual mode's pinging feature?

Sorry for a late reply. I had in mind pinging and also italic, bold, link and another.

Sakretsu subscribed.Oct 1 2020, 11:24 PM

ppelberg updated the task description. (Show Details)Oct 21 2020, 5:23 PM

ppelberg added a subscriber: DannyS712.

ppelberg updated the task description. (Show Details)Oct 22 2020, 3:24 PM

ppelberg updated the task description. (Show Details)

ppelberg added a subscriber: Atmark-chan.

Ahmad252 subscribed.Oct 24 2020, 12:59 PM

ppelberg mentioned this in T265956: Learn what volunteers think of New Discussion Tool design approach.Nov 24 2020, 2:45 AM

ppelberg updated the task description. (Show Details)Dec 1 2020, 12:01 AM

ppelberg added a subscriber: MJL.

MJL awarded a token.Dec 1 2020, 4:26 AM

ppelberg mentioned this in T264520: Don't add nowiki tags in visual mode (or allow opting out).Dec 12 2020, 3:27 AM

ppelberg updated the task description. (Show Details)

ppelberg updated the task description. (Show Details)Dec 23 2020, 10:24 PM

ppelberg edited projects, added Editing-team (Tracking); removed Editing-team.

ppelberg moved this task from Backlog to FY2020-21 on the Editing-team (Tracking) board.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

ppelberg mentioned this in T243249: New discussion v1.0: conduct usability testing.Dec 23 2020, 10:34 PM

mxn subscribed.Jan 9 2021, 7:16 PM

Levivich subscribed.Jan 12 2021, 12:53 AM

ppelberg updated the task description. (Show Details)Feb 11 2021, 7:36 PM

ppelberg added subscribers: Isochrone, Barkeep49, SQL and 2 others.

Change 628932 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Support the enable2017Wikitext option

https://gerrit.wikimedia.org/r/628932

gerritbot added a project: Patch-For-Review.Feb 11 2021, 8:20 PM

Demo: https://patchdemo.wmflabs.org/wikis/12cdbb1f7baf0b71e7dc733aff3da949/w/index.php/Talk:Main_Page

Cool! One (likely) bug: if I press the reply button multiple times, it adds multiple @s.

In T257391#6835475, @Earwig wrote:

Cool! One (likely) bug: if I press the reply button multiple times, it adds multiple @s.

Thanks, filed as T275906

Change 628932 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Support the enable2017Wikitext option

https://gerrit.wikimedia.org/r/628932

This is not enabled for Wikimedia wikis yet. We will need to make a config change to set $wgDiscussionToolsEnable2017Wikitext = true;.

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Feb 26 2021, 8:08 PM

matmarex moved this task from Incoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

Maintenance_bot removed a project: Patch-For-Review.Feb 26 2021, 8:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 26 2021, 10:00 PM

ppelberg mentioned this in T275950: Introduce a setting for enabling the text editing toolbar in DiscussionTools' source mode .Feb 27 2021, 2:10 AM

Next step

@ppelberg to propose deployment plan

In T257391#6879463, @ppelberg wrote:

Next step

@ppelberg to propose deployment plan

The rough plan [i] is as follows:

#	Action	Purpose	Ticket
1.	Offer the `source mode with tools` as an opt-in setting for everyone who has DT enabled	1) Verify people who have expressed interest in this new mode functions as they expect it to. 2) Determine whether people who start using the new mode continue using it.	T276608
2.	Offer `source mode with tools` as an opt-out setting for some of the people who have DT enabled	1) Identify and address edge cases. 2) Determine whether the `source mode with tools` has parity with the existing `source` mode.	T276609
3.	Converge on a single `source mode with tools` within DiscussionTools	1. Increase the maintainability of Discussion Tools Note: this step assumes no blocking issues surface in "Step 1." and "Step 2."	T276607

i. This plan will no longer be rough after we have talked about this as a team next week (the week of 8-March).

ppelberg added a parent task: T276608: Offer the source mode with tools as an opt-in setting.Mar 5 2021, 6:40 PM

To clarify from our discussion last week, we can't switch form opt-in to opt-out with the same setting. For users who have the preference set to "disabled" we have no way of knowing if they have deliberately turned off the tool, or if they just haven't seen the setting yet. To take this approach we will need to use two settings over time (i.e. the value of the opt-in setting will be ignored when we switch to opt-out).

ppelberg mentioned this in T276614: Consult with volunteers about the prototype.Mar 5 2021, 8:08 PM

Why can't there be three options "Enabled", "Disabled", and "Default", to separate users who deliberately turned off the tool from those that hadn't seen the settings?

In T257391#6887795, @Ahecht wrote:

Why can't there be three options "Enabled", "Disabled", and "Default", to separate users who deliberately turned off the tool from those that hadn't seen the settings?

I wouldn't want to offload that complexity on to the user, but we can see if there is a way to achieve that transparently (i.e. record if the user has turned the feature on then off again).

In T257391#6887939, @Esanders wrote:

... we can see if there is a way to achieve that transparently (i.e. record if the user has turned the feature on then off again).

@Esanders: can you please give T276635 a read and edit anything I might've missed/misconstrued?

Patriccck added a subtask: T277241: Add syntax highlighting to DiscussionTools' source mode.Mar 11 2021, 10:16 PM

Esanders mentioned this in T277309: Add directionality switcher tool to reply/new topic tools.Mar 12 2021, 4:29 PM

ppelberg mentioned this in T277827: Prevent the username suggestion list from opening if @ is preceded by a non-whitespace character.Mar 19 2021, 12:08 AM

matmarex merged a task: T278169: Add a mention button in source mode.Mar 22 2021, 8:13 PM

matmarex added a subscriber: AntiCompositeNumber.

Another request from user @Ijoe2003 here.

In T257391#6940190, @Patriccck wrote:

Another request from user @Ijoe2003 here.

Thank you for adding this, @Patriccck !

@Esanders: would it be accurate for me to think the following?

This task can be resolved because the code that enables the new "source mode with tools" functionality has already been deployed
The new "source mode with tools" functionality, and its associated setting, will not be visible to anyone on any production wiki until T275950 is deployed.