Page MenuHomePhabricator
Create Task
Maniphest T257525

Upgrade WebdriverIO in the CirrusSearch repository
Closed, ResolvedPublic
Actions

Description

Status

  • v4 - running smoke test in CI (617416) fails
  • v5 - Cindy-the-browser-test-bot fails when running 610396 without saying which tests failed
  • Vidhi still doesn't have CirrusSearch running locally, 613007 might help
  • Vidhi can't log in to horizon.wikimedia.org

TODO

  • add a separate patch renaming @selenium-test to selenium-test to check if webdriverio v4 tests pass in CI: 617416:
  • update T253869
    • count lines of code in tests/selenium and tests/integration
    • count tests in feature files (scenario and scenario outline)
  • local development environment
  • Update to v5
  • Update to v6
  • Update to v7

Details

SubjectRepoBranchLines +/-
Selenium: Run tests on CImediawiki/extensions/CirrusSearchmaster+1 -1
selenium: Upgrade WebdriverIO to v6mediawiki/extensions/CirrusSearchmaster+2 K -2 K
build: Add missing @wdio/cli npm packagemediawiki/extensions/CirrusSearchmaster+73 -214
build: Switch wdio from 4.x (2018) to 5.x (2019)mediawiki/extensions/CirrusSearchmaster+15 K -2 K
build: Switch wdio from 4.x (2018) to 5.x (2019)mediawiki/extensions/CirrusSearchREL1_35+3 K -2 K
build: Switch wdio from 4.x (2018) to 5.x (2019)mediawiki/extensions/CirrusSearchREL1_36+2 K -2 K
Selenium: Update to WebdriverIO v5mediawiki/extensions/CirrusSearchmaster+39 -39
Bad instructions for running integration in wmcs with wmvmediawiki/extensions/CirrusSearchmaster+154 -0
Selenium: Update README filemediawiki/extensions/CirrusSearchmaster+5 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Vidhi-Mody triaged this task as Medium priority.Jul 8 2020, 10:12 PM
Vidhi-Mody added a parent task: T247844: Upgrade WebdriverIO to v6 in all repositories.
Vidhi-Mody mentioned this in T247844: Upgrade WebdriverIO to v6 in all repositories.
gerritbot added a comment.Jul 8 2020, 10:26 PM

Change 610396 had a related patch set uploaded (by Vidhi-Mody; owner: Vidhi-Mody):
[mediawiki/extensions/CirrusSearch@master] Selenium: Update to WebdriverIO v5

https://gerrit.wikimedia.org/r/610396

gerritbot added a project: Patch-For-Review.Jul 8 2020, 10:26 PM
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.Jul 9 2020, 9:05 AM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin moved this task from Backlog to In Progress on the User-Vidhi-Mody board.
zeljkofilipin moved this task from Backlog 🪒 to Learn/Teach 💡 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)Jul 13 2020, 10:19 AM
Vidhi-Mody added a comment.Jul 13 2020, 12:42 PM

Terminal Output: Running tests targeting mediawiki-docker
https://phabricator.wikimedia.org/P11874

Vidhi-Mody updated the task description. (Show Details)Jul 13 2020, 12:43 PM
zeljkofilipin updated the task description. (Show Details)Jul 16 2020, 4:27 PM
gerritbot added a comment.Jul 16 2020, 4:30 PM

Change 613007 had a related patch set uploaded (by Zfilipin; owner: Ebernhardson):
[mediawiki/extensions/CirrusSearch@master] Bad instructions for running integration in wmcs with wmv

https://gerrit.wikimedia.org/r/613007

zeljkofilipin updated the task description. (Show Details)Jul 16 2020, 4:31 PM
zeljkofilipin updated the task description. (Show Details)Jul 16 2020, 4:35 PM
zeljkofilipin updated the task description. (Show Details)
EBernhardson subscribed.Jul 16 2020, 4:45 PM
In T257525#6300741, @Vidhi-Mody wrote:

Terminal Output: Running tests targeting mediawiki-docker
https://phabricator.wikimedia.org/P11874

This is checked off but I wouldn't really consider it complete. Perhaps I'm misinterpreting the task, but the expected output is more like the following (i need to investigate these failures separately, it will be back to 0 failing soon):

2159 passing (700.00s)                                                                                                                                                     
6 skipped                                                                                                                                                                  
5 failing
zeljkofilipin updated the task description. (Show Details)Jul 16 2020, 5:01 PM
zeljkofilipin subscribed.Jul 17 2020, 8:56 AM
In T257525#6313043, @EBernhardson wrote:

This is checked off but I wouldn't really consider it complete.

@Vidhi-Mody is just trying different ways to run the tests. She tried mw-docker, but the experiment didn't go well. 😬 It's checked off as "we've tried this, didn't work, let's try something else".

zeljkofilipin updated the task description. (Show Details)Jul 20 2020, 10:16 AM
zeljkofilipin updated the task description. (Show Details)Jul 21 2020, 9:42 AM
Vidhi-Mody added a comment.Jul 21 2020, 8:18 PM

I get this error when I tried setting up MediaWiki Vagrant: P12001

zeljkofilipin updated the task description. (Show Details)Jul 23 2020, 9:11 AM
zeljkofilipin updated the task description. (Show Details)Jul 23 2020, 2:54 PM
CBogen moved this task from needs triage to watching / waiting on the Discovery-Search board.Jul 23 2020, 7:21 PM
gerritbot added a comment.Jul 28 2020, 11:17 AM

Change 616734 had a related patch set uploaded (by Vidhi-Mody; owner: Vidhi-Mody):
[mediawiki/extensions/CirrusSearch@master] Selenium: Update README file

https://gerrit.wikimedia.org/r/616734

zeljkofilipin updated the task description. (Show Details)Jul 29 2020, 10:52 AM
zeljkofilipin updated the task description. (Show Details)Jul 29 2020, 10:55 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jul 29 2020, 10:58 AM
zeljkofilipin updated the task description. (Show Details)
Vidhi-Mody updated the task description. (Show Details)Jul 29 2020, 12:37 PM
Vidhi-Mody updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jul 29 2020, 1:33 PM
gerritbot added a comment.Jul 29 2020, 6:40 PM

Change 616734 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Selenium: Update README file

https://gerrit.wikimedia.org/r/616734

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 29 2020, 7:00 PM
gerritbot added a comment.Jul 30 2020, 11:35 AM

Change 617416 had a related patch set uploaded (by Vidhi-Mody; owner: Vidhi-Mody):
[mediawiki/extensions/CirrusSearch@master] Selenium: Run tests on CI

https://gerrit.wikimedia.org/r/617416

Vidhi-Mody updated the task description. (Show Details)Jul 30 2020, 11:54 AM
Vidhi-Mody updated the task description. (Show Details)
Vidhi-Mody updated the task description. (Show Details)Jul 30 2020, 1:26 PM
zeljkofilipin updated the task description. (Show Details)Jul 30 2020, 4:41 PM
zeljkofilipin updated the task description. (Show Details)Jul 30 2020, 4:55 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jul 30 2020, 4:59 PM
zeljkofilipin updated the task description. (Show Details)Jul 30 2020, 5:02 PM
zeljkofilipin updated the task description. (Show Details)Jul 30 2020, 5:05 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)
Mhurd updated the task description. (Show Details)Jul 30 2020, 5:10 PM
Mhurd updated the task description. (Show Details)Jul 30 2020, 5:24 PM
Mhurd subscribed.Jul 30 2020, 5:34 PM

It looks like the https://github.com/montehurd/mediawiki-docker-dev-sdc setup instructions still work after all :)

I tested it on MacOS. I'll still try to create a stripped down version with only Cirrus Search configured, but in the mean time @Vidhi-Mody feel free to try the 'mediawiki-docker-dev-sdc' version if you have time.

zeljkofilipin updated the task description. (Show Details)Jul 31 2020, 10:01 AM
Vidhi-Mody updated the task description. (Show Details)Aug 23 2020, 7:41 PM
Vidhi-Mody updated the task description. (Show Details)
zeljkofilipin removed Vidhi-Mody as the assignee of this task.Aug 25 2020, 10:11 AM
zeljkofilipin moved this task from In Progress to Backlog on the User-Vidhi-Mody board.
zeljkofilipin moved this task from Learn/Teach 💡 to Backlog 🪒 on the User-zeljkofilipin board.Sep 9 2020, 8:19 AM
gerritbot added a comment.Oct 12 2020, 7:52 AM

Change 613007 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Bad instructions for running integration in wmcs with wmv

https://gerrit.wikimedia.org/r/613007

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.13; 2020-10-12); removed MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Oct 12 2020, 8:00 AM
zeljkofilipin mentioned this in T271102: selenium-daily-beta-CirrusSearch is failing.Jan 18 2021, 5:58 PM
Vidhi-Mody mentioned this in T274579: Upgrade WebdriverIO to v7 in all repositories.Feb 11 2021, 6:29 PM
gerritbot added a comment.Jun 8 2021, 9:47 PM

Change 698631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CirrusSearch@master] build: Switch wdio from 4.x (2018) to 5.x (2019)

https://gerrit.wikimedia.org/r/698631

gerritbot added a comment.Jun 8 2021, 9:48 PM

Change 610396 abandoned by Jforrester:

[mediawiki/extensions/CirrusSearch@master] Selenium: Update to WebdriverIO v5

Reason:

Squashed into parent, sort-of.

https://gerrit.wikimedia.org/r/610396

gerritbot added a comment.Jun 8 2021, 10:24 PM

Change 698631 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] build: Switch wdio from 4.x (2018) to 5.x (2019)

https://gerrit.wikimedia.org/r/698631

Vidhi-Mody updated the task description. (Show Details)Jun 9 2021, 5:49 PM
Vidhi-Mody updated the task description. (Show Details)Jun 9 2021, 5:52 PM
Vidhi-Mody added a parent task: T274579: Upgrade WebdriverIO to v7 in all repositories.
gerritbot added a comment.Jul 28 2021, 1:18 PM

Change 708516 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):

[mediawiki/extensions/CirrusSearch@master] selenium: Upgrade WebdriverIO to v7

https://gerrit.wikimedia.org/r/708516

gerritbot added a comment.Aug 5 2021, 7:50 PM

Change 703927 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):

[wikimedia/portals/deploy@master] selenium: Upgrade WebdriverIO to v6

https://gerrit.wikimedia.org/r/703927

zeljkofilipin added a subtask: T289168: Upgrade WebdriverIO to v6 in CirrusSearch.Aug 20 2021, 2:21 PM
gerritbot added a comment.Aug 20 2021, 4:23 PM

Change 714070 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CirrusSearch@REL1_36] build: Switch wdio from 4.x (2018) to 5.x (2019)

https://gerrit.wikimedia.org/r/714070

gerritbot added a comment.Aug 20 2021, 4:28 PM

Change 714077 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CirrusSearch@REL1_35] build: Switch wdio from 4.x (2018) to 5.x (2019)

https://gerrit.wikimedia.org/r/714077

gerritbot added a comment.Aug 20 2021, 6:19 PM

Change 714070 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_36] build: Switch wdio from 4.x (2018) to 5.x (2019)

https://gerrit.wikimedia.org/r/714070

gerritbot added a comment.Aug 20 2021, 7:07 PM

Change 714077 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_35] build: Switch wdio from 4.x (2018) to 5.x (2019)

https://gerrit.wikimedia.org/r/714077

gerritbot added a comment.Aug 23 2021, 5:27 PM

Change 714389 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/CirrusSearch@master] build: Add missing @wdio/cli npm package

https://gerrit.wikimedia.org/r/714389

gerritbot added a comment.Aug 23 2021, 8:41 PM

Change 714389 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] build: Add missing @wdio/cli npm package

https://gerrit.wikimedia.org/r/714389

zeljkofilipin removed a parent task: T247844: Upgrade WebdriverIO to v6 in all repositories.Sep 16 2021, 8:10 AM
zeljkofilipin removed a project: User-Vidhi-Mody.Sep 16 2021, 10:40 AM
zeljkofilipin removed a project: Quality-and-Test-Engineering-Team.Sep 16 2021, 11:01 AM
zeljkofilipin raised the priority of this task from Medium to Needs Triage.Oct 7 2021, 5:47 PM
zeljkofilipin added a project: Browser-Tests.
gerritbot added a comment.Nov 8 2022, 12:23 PM

Change 708516 abandoned by Zfilipin:

[mediawiki/extensions/CirrusSearch@master] selenium: Upgrade WebdriverIO to v6

Reason:

https://gerrit.wikimedia.org/r/708516

gerritbot added a comment.Nov 8 2022, 12:29 PM

Change 617416 abandoned by Zfilipin:

[mediawiki/extensions/CirrusSearch@master] Selenium: Run tests on CI

Reason:

https://gerrit.wikimedia.org/r/617416

zeljkofilipin mentioned this in T324685: Upgrade WebdriverIO to v8 in all repositories.Feb 22 2023, 10:04 AM
zeljkofilipin edited parent tasks, added: T324685: Upgrade WebdriverIO to v8 in all repositories; removed: T274579: Upgrade WebdriverIO to v7 in all repositories.
zeljkofilipin closed this task as Resolved.Jul 17 2023, 3:44 PM
zeljkofilipin assigned this task to EBernhardson.
zeljkofilipin closed subtask T289168: Upgrade WebdriverIO to v6 in CirrusSearch as Resolved.

Done in 911347.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL