Page MenuHomePhabricator

VE Dialog on the Test Instance: Change placement of examples
Closed, ResolvedPublic2 Estimated Story Points

Description

The example should only be shown as part of the description underneath the parameter name (change), the default should only be shown as the placeholder in the input field (status quo). Formatting of the example itself remains unchanged - VE adds e.g. and shows the value (status quo).

Requirements

  • Examples are not shown as placeholders in the input field
  • Examples are added to the description on a new line
  • If adding the example makes the total description size go past 2 lines total (approximately is fine for now), then it is hidden inside the 'More' button and only shown on click
  • If there is no example and no default, the input field is shown empty

Mock

Screen Shot 2020-08-26 at 10.56.24.png (414×537 px, 37 KB)

Note: this ticket is the result of the discussion in this ticket T260147: VE Dialog on the Test Instance: Make instructions more visible

Event Timeline

Lena_WMDE renamed this task from VE Dialog on the Test Instance: Example placement to VE Dialog on the Test Instance: Change placement of examples.Aug 26 2020, 10:04 AM
Lena_WMDE updated the task description. (Show Details)
Lena_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.
Lena_WMDE set the point value for this task to 3.Sep 3 2020, 8:48 AM

Change 625599 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/VisualEditor@master] Never use example values as a placeholder

https://gerrit.wikimedia.org/r/625599

awight changed the point value for this task from 3 to 1.Sep 7 2020, 8:51 AM
awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-08-26 board.

Reducing the estimate, there wasn't much left to this ticket.

Change 625748 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/VisualEditor@wmde-templates] Never use example values as a placeholder

https://gerrit.wikimedia.org/r/625748

Change 625748 abandoned by Awight:
[mediawiki/extensions/VisualEditor@wmde-templates] Never use example values as a placeholder

Reason:
branch not needed.

https://gerrit.wikimedia.org/r/625748

Ready for demoing again. An earlier patch had inadvertently removed the example and parameter deprecation notices from the description text.

awight changed the point value for this task from 1 to 2.Sep 9 2020, 9:34 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-08-26 board.

Change 625599 abandoned by Awight:

[mediawiki/extensions/VisualEditor@master] Never use example values as a placeholder

Reason:

Not changing legacy workflow.

https://gerrit.wikimedia.org/r/625599