Page MenuHomePhabricator
Create Task
Maniphest T263180

1.36.0-wmf.14 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor
• LarsWirzenius
Release Version
1.36.0-wmf.14
Release Date
Oct 19 2020, 12:00 AM

2020 week 43 1.36-wmf.14 Changes wmf/1.36.0-wmf.14

This MediaWiki Train Deployment is scheduled for the week of Monday, October 19th:

Monday October 19thTuesday, October 20thWednesday, October 21stThursday, October 22ndFriday
Backports only.Branch wmf.14 and deploy to Group 0 Wikis.Deploy wmf.14 to Group 1 Wikis.Deploy wmf.14 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.14 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.36.0-wmf.13
Next: 1.36.0-wmf.15

Related Objects
Search...

Event Timeline

thcipriani created this task.Sep 17 2020, 7:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2020, 7:29 PM
thcipriani assigned this task to jeena.Sep 22 2020, 8:21 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: • LarsWirzenius.
thcipriani added a project: Release-Engineering-Team-TODO.
Jdlrobson added a subtask: T256173: Allow filtering of errors from logged in users.Oct 15 2020, 5:09 PM
• Pchelolo subscribed.Oct 18 2020, 8:17 PM

FYI: This train will contain the code switching ParserCache from PHP serialization to JSON serialization: T263579
The code is disabled by default, thus it *should* be a no-op. We have also put significant efforts into testing backward and forward compatibility for this feature, see T264397 - a new serialization testing framework was made and we added few hundred tests for various combinations of versions, cached objects etc. In case the train needs to be reverted, we've already put compatibility code in there, so things should behave well after a revert. We feel fairly confident in this change, but please be aware anyways.

Jdlrobson removed a subtask: T256173: Allow filtering of errors from logged in users.Oct 19 2020, 10:55 PM
• LarsWirzenius claimed this task.Oct 20 2020, 11:32 AM
• LarsWirzenius added subscribers: jeena, • LarsWirzenius.

I'm taking over as backup train conductor.

• LarsWirzenius added a comment.Oct 20 2020, 11:33 AM

Filed T265994: PHP Warning: mb_stripos(): Empty delimiter before starting train.

Stashbot added a comment.Oct 20 2020, 11:37 AM

Mentioned in SAL (#wikimedia-operations) [2020-10-20T11:37:08Z] <liw> 1.36.0-wmf.14 was branched at 1b7b5f716015f9303d37158820dadf759e8db707 for T263180

• LarsWirzenius added a comment.Oct 20 2020, 2:15 PM

Reported T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null, but not a blocker yet.

CCicalese_WMF subscribed.Oct 20 2020, 4:53 PM

T266021 is resolved by https://gerrit.wikimedia.org/r/c/mediawiki/skins/WikimediaApiPortal/+/635045. The backport to 1.36-wmf.14 is ready at https://gerrit.wikimedia.org/r/c/mediawiki/skins/WikimediaApiPortal/+/635329.

• LarsWirzenius added a subtask: T266051: Class 'TranslatablePage' not found.EditedOct 20 2020, 5:05 PM

Reported T266051: Class 'TranslatablePage' not found as blocker.

dancy subscribed.Oct 20 2020, 5:34 PM

Reported T266052 as a blocker.

dancy added a subtask: T266052: Interface 'MediaWiki\EditPafe\IEditObject' not found.Oct 20 2020, 5:37 PM
CDanis removed a subtask: T266051: Class 'TranslatablePage' not found.Oct 20 2020, 5:51 PM
CDanis removed a subtask: T266052: Interface 'MediaWiki\EditPafe\IEditObject' not found.
• LarsWirzenius added a subtask: T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().Oct 21 2020, 10:03 AM

Reported T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd() as a blocker.

• LarsWirzenius removed a subtask: T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().Oct 21 2020, 10:15 AM
greg added a subtask: T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null.Oct 21 2020, 5:29 PM
• Pchelolo closed subtask T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null as Resolved.Oct 21 2020, 5:43 PM
• LarsWirzenius added a comment.Oct 22 2020, 1:10 PM

Reported T266234: PHP Warning: fclose() expects parameter 1 to be resource, boolean given but not as a blocker.

• LarsWirzenius closed this task as Resolved.Oct 23 2020, 11:54 AM

Train's been at group2 for about 22 hours. I'm tempting fate by declaring this done.

Lucas_Werkmeister_WMDE mentioned this in T239931: Reduce the impact of the sanitizer on wikidata.Oct 26 2020, 6:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL