Page MenuHomePhabricator
Create Task
Maniphest T264684

"Invalid response from server." when using hCaptcha and Visual Editor
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Enable hCaptcha (or ReCaptcha) and configure it.
  2. Edit or create a page with Visual Editor as a user that has to see a captcha.
  3. Try to submit the edit.

Actual Results:
See Error "Invalid Response from Server", click "Dismiss" and notice you're unable to send in a edit at all.

Expected Results:
Either hCaptcha working and showing (like QuestyCaptcha does, even though buggy) or at least not throwing an error that disables users ability to send in edits.

Comment:
On the wiki page for the extension reCaptcha is mentioned to 'not work' with visual editor, but i didnt expect an error blocking users to edit to be 'not working'. I rather expected it's simply not shown.
hCaptcha does not mention it not working with visual editor at all. Given visual editor is now used out of the box, supporting it would be quite cool.

Screenshot:

image.png (535×701 px, 55 KB)

Details

SubjectRepoBranchLines +/-
Support hCaptcha for VisualEditormediawiki/extensions/ConfirmEditREL1_36+186 -17
Support hCaptcha for VisualEditormediawiki/extensions/ConfirmEditREL1_35+186 -17
Support hCaptcha for VisualEditormediawiki/extensions/ConfirmEditmaster+186 -17
Customize query in gerrit

Related Objects

Event Timeline

D3nnis3n created this task.Oct 5 2020, 10:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2020, 10:56 PM
D3nnis3n updated the task description. (Show Details)Oct 5 2020, 10:59 PM
D3nnis3n updated the task description. (Show Details)
Reedy added a project: VisualEditor.Oct 5 2020, 10:59 PM
Reedy subscribed.

Probably needs something like rECOEe614050b6ab3: ConfirmEdit: Support No CAPTCHA reCAPTCHA did for VE support

D3nnis3n added a comment.Oct 5 2020, 11:01 PM

I saw that task and hence assumed Visual Editor would now work with ReCaptcha, but as i noted in my OP as a "side-notice", ReCaptcha is not working either.

Reedy added a comment.Oct 5 2020, 11:06 PM

https://www.mediawiki.org/w/index.php?title=Extension%3AConfirmEdit&type=revision&diff=4156765&oldid=4153726

Added some documentation to say it doesn't work, for now

In T264684#6519682, @Reedy wrote:

Probably needs something like rECOEe614050b6ab3: ConfirmEdit: Support No CAPTCHA reCAPTCHA did for VE support

I wonder why the code seems to be there for support, but the docs are as such... Out of date?

D3nnis3n updated the task description. (Show Details)Oct 5 2020, 11:07 PM

Thank you. I also added a screenshot to make clear where it happens and how it looks, hopefully that helps.
And hopefully this time my report was formatted correctly :)

alistair3149 subscribed.Mar 24 2021, 12:49 AM
gerritbot added a comment.Mar 25 2021, 3:15 PM

Change 674913 had a related patch set uploaded (by Alistair3149; author: Alistair3149):
[mediawiki/extensions/ConfirmEdit@master] Support hCaptcha for VisualEditor

https://gerrit.wikimedia.org/r/674913

gerritbot added a project: Patch-For-Review.Mar 25 2021, 3:15 PM
alistair3149 added a comment.Mar 25 2021, 3:22 PM

Submitted a patch based on the NoCaptchaReCaptcha implementation. The config flags are also refactored to not use global variables.

ppelberg added a project: Editing-team (Kanban Board).Mar 25 2021, 3:48 PM
ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Mar 25 2021, 3:55 PM
matmarex subscribed.Apr 21 2021, 6:57 PM
gerritbot added a comment.Apr 22 2021, 4:19 PM

Change 674913 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Support hCaptcha for VisualEditor

https://gerrit.wikimedia.org/r/674913

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 22 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 22 2021, 5:10 PM
gerritbot added a comment.Apr 22 2021, 5:27 PM

Change 681972 had a related patch set uploaded (by Alistair3149; author: Alistair3149):

[mediawiki/extensions/ConfirmEdit@REL1_35] Support hCaptcha for VisualEditor

https://gerrit.wikimedia.org/r/681972

gerritbot added a project: Patch-For-Review.Apr 22 2021, 5:27 PM
alistair3149 added a comment.Apr 22 2021, 5:27 PM

Thanks for everyone's help! Cherry-picked the patch for REL1_35.

gerritbot added a comment.Apr 22 2021, 10:37 PM

Change 681980 had a related patch set uploaded (by Reedy; author: Alistair3149):

[mediawiki/extensions/ConfirmEdit@REL1_36] Support hCaptcha for VisualEditor

https://gerrit.wikimedia.org/r/681980

gerritbot added a comment.Apr 22 2021, 11:06 PM

Change 681972 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_35] Support hCaptcha for VisualEditor

https://gerrit.wikimedia.org/r/681972

gerritbot added a comment.Apr 22 2021, 11:07 PM

Change 681980 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_36] Support hCaptcha for VisualEditor

https://gerrit.wikimedia.org/r/681980

Maintenance_bot removed a project: Patch-For-Review.Apr 22 2021, 11:10 PM
matmarex added a comment.Apr 28 2021, 10:00 PM

On re-reading this bug report, I'm not sure if the patch actually fixes the issue. The description mentions an issue affecting ReCaptcha as well as HCaptcha. The patch implemented HCaptcha support, but has not touched the existing ReCaptcha code at all.

Reedy renamed this task from "Invalid response from server." when using HCaptcha and Visual Editor to "Invalid response from server." when using hCaptcha and Visual Editor.Apr 29 2021, 12:00 AM
Reedy updated the task description. (Show Details)
Esanders assigned this task to matmarex.May 5 2021, 5:18 PM
Esanders removed a project: Editing-team (Kanban Board).May 26 2021, 12:52 PM
matmarex changed the task status from Open to Stalled.May 26 2021, 4:59 PM
matmarex removed matmarex as the assignee of this task.

Waiting for the task's author to respond whether this resolves their problem.

D3nnis3n added a comment.EditedMay 26 2021, 8:49 PM

Hello,
thank you so much, this indeed fixes the problem and spam is gone while anonymous users can still contribute with VE active.

(I'm only using HCaptcha as ReCaptcha is ineffective, but it had the same issue. So if ReCaptcha hasn't been touched, that is still broken)

matmarex closed this task as Resolved.May 26 2021, 10:21 PM
matmarex assigned this task to alistair3149.

OK, thanks for responding! I guess we should resolve this, and if anyone else is experiencing the issue with ReCaptcha, they should file a separate bug.

D3nnis3n added a comment.Mar 28 2024, 5:20 PM

Confirmed ReCaptcha is working fine with Visual Editor as well, just ineffective nowadays.

D3nnis3n unsubscribed.Mar 28 2024, 5:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL