Page MenuHomePhabricator
Create Task
Maniphest T264907

Convert Cosmos to use ConfigRegistry
Closed, ResolvedPublic
Actions

Description

At some point I'd like to convert Cosmos to use the ConfigRegistry rather than the current Config.php.

Details

SubjectRepoBranchLines +/-
ResourceLoaderLessModule: Make code more readable, match conventionmediawiki/skins/Cosmosmaster+75 -43
Basic code cleanup in Cosmos\ResourceLoaderLessModulemediawiki/skins/Cosmosmaster+26 -14
Convert to ConfigRegistrymediawiki/skins/Cosmosmaster+205 -297
Technical debt cleanup: Remove unused parameters from methodsmediawiki/skins/Cosmosmaster+40 -76
Customize query in gerrit

Related Objects
Search...

Event Timeline

Universal_Omega triaged this task as Low priority.Oct 7 2020, 4:21 PM
Universal_Omega created this task.
Universal_Omega moved this task from Backlog to Extension registration manifest_version 2 on the MediaWiki-Configuration board.
Universal_Omega moved this task from Incoming / Backlog to Feature requests on the Cosmos board.
SamanthaNguyen moved this task from Feature requests to Code hygiene on the Cosmos board.Oct 10 2020, 9:01 PM
SamanthaNguyen mentioned this in T265063: Factor SocialProfile features of Cosmos into an extension.Oct 11 2020, 7:39 PM
gerritbot added a comment.Oct 11 2020, 8:06 PM

Change 633376 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Basic code cleanup in Cosmos\ResourceLoaderLessModule

https://gerrit.wikimedia.org/r/633376

gerritbot added a project: Patch-For-Review.Oct 11 2020, 8:06 PM

Change 633377 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] ResourceLoaderLessModule: General code cleanup

https://gerrit.wikimedia.org/r/633377

gerritbot added a comment.Oct 12 2020, 10:21 PM

Change 633582 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

SamanthaNguyen added a parent task: T265063: Factor SocialProfile features of Cosmos into an extension.Oct 12 2020, 10:31 PM
gerritbot added a comment.Oct 13 2020, 6:02 PM

Change 633582 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

gerritbot added a comment.Oct 13 2020, 10:02 PM

Change 633762 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] Convert to ConfigRegistry

https://gerrit.wikimedia.org/r/633762

Universal_Omega claimed this task.Oct 13 2020, 11:05 PM
SamanthaNguyen mentioned this in T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings.Oct 14 2020, 8:19 PM
SamanthaNguyen added a parent task: T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings.Oct 14 2020, 8:24 PM
SamanthaNguyen moved this task from Code hygiene to In Progress on the Cosmos board.Oct 15 2020, 12:09 AM
Universal_Omega closed this task as Resolved.Oct 15 2020, 1:07 AM
Universal_Omega moved this task from In Progress to Done on the Cosmos board.
Universal_Omega moved this task from Extension registration manifest_version 2 to Done on the MediaWiki-Configuration board.
gerritbot added a comment.Oct 15 2020, 1:14 AM

Change 633762 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Convert to ConfigRegistry

https://gerrit.wikimedia.org/r/633762

gerritbot added a comment.Oct 15 2020, 1:30 AM

Change 633376 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Basic code cleanup in Cosmos\ResourceLoaderLessModule

https://gerrit.wikimedia.org/r/633376

gerritbot added a comment.Oct 15 2020, 1:36 AM

Change 633377 abandoned by SamanthaNguyen:
[mediawiki/skins/Cosmos@master] ResourceLoaderLessModule: Make code more readable, match convention

Reason:
I could rebase this on top of master, but that's sort of annoying, so I'll make a new patch

https://gerrit.wikimedia.org/r/633377

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL