Page MenuHomePhabricator

Develop approach for how Reply Links should be treated where an entire comment is styled
Closed, DeclinedPublic

Description

This task is about deciding how the [ reply ] links ought to look when the entirety of the comment to which they are appended in wrapped in some kind of tag. E.g. <small></small> tags.

Background

T256033 makes it so [ reply ] links do not inherit the formatting that is applied to the text that appears before it. This task is about deciding whether exceptions should be made to this behavior.

One such exception could be the case where people wrap the entirety of their comments in <small> tags to, presumably, signify to others that they are making a side comment. [i]

Open questions

  • How should [ reply ] links appears in cases where people wrap the entirety of their comments in <small> tags?
  • What – if any – precedents exist for primary affordances/UI components inheriting "local" styling?
  • What – if any – changes should be made to the approach T256033 implements

Done

  • All ===Open questions are answered

i. See the example @Esanders shared in T256033#6640799:

Observe how people have wrapped their entire comments in small tags
image.png (281×1 px, 101 KB)

Event Timeline

matmarex claimed this task.
matmarex subscribed.

I don't think we need to define the exact behavior here. It's harmless if they inherit the styling, and it's harmless if they don't, and it would be fiddly to try to make it work the same in every case.