| Krinkle | |
| Jan 28 2021, 3:20 AM |
| F34095144: Screen Shot 2021-02-08 at 6.17.25 AM.png | |
| Feb 8 2021, 2:20 PM |
| F34095146: Screen Shot 2021-02-08 at 6.18.04 AM.png | |
| Feb 8 2021, 2:20 PM |
| F34092198: Screen Shot 2021-02-04 at 6.49.45 AM.png | |
| Feb 4 2021, 2:59 PM |
| F34092196: Screen Shot 2021-02-04 at 6.49.05 AM.png | |
| Feb 4 2021, 2:59 PM |
| F34050173: mw-vector.png | |
| Jan 28 2021, 3:20 AM |
| F34050178: beta.png | |
| Jan 28 2021, 3:20 AM |
| F34050171: mw-mono..png | |
| Jan 28 2021, 3:20 AM |
| F34050175: Screenshot 2021-01-28 at 03.19.19.png | |
| Jan 28 2021, 3:20 AM |
The spaces between the "diff" parenthesis and revision compare buttons is missing.
The spaces between the two revision compare buttons is also missing.
As in production today:
https://en.wikipedia.org/w/index.php?title=Main_Page&action=history
Currently on Beta Cluster and on group0 in production, such as mediawiki.org:
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T273148#6803941 |
| 2 | ✅ | T273148#6803941 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T273148#6811215 |
| 2 | ✅ | T273148#6811215 |
Change 659258 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] HistoryAction: Fix margins of normalized input controls
Change 659258 merged by jenkins-bot:
[mediawiki/core@master] HistoryAction: Fix margins of normalized input controls
Does this task also cover the fact that there are two radio inputs in a row on intermediate revisions, or should I open a new task about that?
@Nirmos I think that is by design, clicking the left one will bring "up" the lower selection to it, clicking the right one will bring "down" the higher selection to it.
No, that has always been the case. Ever since the "compare revisions" feature was added to page histories, the unstyled page has had two radiobuttons for every row, and JavaScript is used to hide (by means of a visibility:hidden; declaration) those in the left-hand group adjacent to and above the selected button in the right-hand group, and to hide those in the right-hand group adjacent to and below the selected button in the left-hand group. This much has not changed: the recent change is merely that a margin:0; declaration has been added to those buttons, causing them to sit closer together.
Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
✅ AC1: The spaces between the "diff" parenthesis and revision compare buttons are NOT missing.
| Vector | Monobook |
 |  |
✅ AC2: The spaces between the two revision compare buttons are NOT missing.
see above
Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
✅ AC1: The spaces between the "diff" parenthesis and revision compare buttons are NOT missing.
| Vector | Monobook |
 |  |
✅ AC2: The spaces between the two revision compare buttons are NOT missing.
see above
