WikiPage is going to be broken down into services. It's impossible to instantiate it within the context without using global state, and in general having WikiPage accessor in context violates the laws of nature.
The method usages should be found, replaced with explicit use of WikiPageFactory and method should be hard-deprecated and eventually removed.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | daniel | T275710 Deprecate IContextSource::getWikiPage and IContextSource::canUseWikiPage | |||
| Resolved | BUG REPORT | Reedy | T285959 Captcha interface is not shown to unregistered users, page save is not possible | ||
| Resolved | BUG REPORT | DannyS712 | T286140 AbuseLog no longer recording revids of saved edits |
We have extension that extends/implements IContextSource so we need to update those methods deprecation also there:
Change 699911 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/Wikibase@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 699911 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701091 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/ProofreadPage@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701127 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/BlueSpiceFoundation@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 701091 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Replace depricating method IContextSource::getWikiPage & IContextSource::canUseWikiPage
Change 701356 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/BlueSpiceFoundation@master] Declare missing method of CsrfTokenSetProvider.
Change 701356 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Declare missing method of CsrfTokenSetProvider.
Change 701127 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 701882 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/EntitySchema@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701893 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/MobileFrontend@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 701896 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/AbuseFilter@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701897 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/AkismetKlik@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701901 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/CognitiveProcessDesigner@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701903 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/ConfirmEdit@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 701911 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/MiniInvite@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 701916 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/MsUpload@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701920 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/SpamBlacklist@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701920 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701903 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 701896 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 702119 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/TwoColConflict@master] Replace depricating method IContextSource::getWikiPage
Change 702125 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/WikibaseMediaInfo@master] Replace depricating method IContextSource::getWikiPage
Change 702130 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/WikiShare@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 702131 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/Wikispeech@master] Replace depricating method IContextSource::getWikiPage
Change 701911 merged by jenkins-bot:
[mediawiki/extensions/MiniInvite@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 702131 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Replace depricating method IContextSource::getWikiPage
Change 702119 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Replace depricating method IContextSource::getWikiPage
Change 701916 merged by jenkins-bot:
[mediawiki/extensions/MsUpload@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 701882 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Change 702365 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/core@master] WIP: Hard deprecate IContextSource::getWikiPage and IContextSource::canUseWikiPage
Change 702372 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/BlueSpiceFoundation@master] WIP: Hard deprecate IContextSource::getWikiPage and IContextSource::canUseWikiPage
Change 701893 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace deprecated method IContextSource methods
Change 702125 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Replace depricating method IContextSource::getWikiPage
Change 702130 merged by jenkins-bot:
[mediawiki/extensions/WikiShare@master] Replace depricating method IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 702614 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/core@master] Replace depricating methods IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 702678 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/Wikibase@master] Replace custom Title mock to MockTitleTrait
Caused T285959: Captcha interface is not shown to unregistered users, page save is not possible.
I'd be concerned what other side effects these patches may be having.
Also, please don't merge patches with typos/grammer errors in them. "depricating" is not a word, it would be "deprecating", but that would be the action of deprecating something... But in this case, "Replace deprecated methods" would be the appropriate wording.
Change 702698 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/ConfirmEdit@master] Replaced deprecate methods IContextSource::getWikiPage && IContextSource::canUseWikiPage.
Change 702698 abandoned by Roman Stolar:
[mediawiki/extensions/ConfirmEdit@master] Replaced deprecate methods IContextSource::getWikiPage && IContextSource::canUseWikiPage.
Reason:
Change 702678 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace custom Title mock to MockTitleTrait
Ok, please cease from merging any more of these patches.
With T286140: AbuseLog no longer recording revids of saved edits, this is the second regression that these have caused in production.
It would seem they're not being tested, and are clearly breaking things because they're not doing the right thing.
Change 737353 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/ConfirmEdit@master] Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 737383 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/WikiEditor@master] Replace usage of ConfirmEdit_ActivateCaptcha random properties.
Change 737353 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 737383 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Replace usage of ConfirmEdit_ActivateCaptcha random properties.
Change 739128 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/AbuseFilter@master] Replace usage of the method IContextSource::getWikiPage that will be deprecated to WikiPageFactory usage
Change 739274 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/extensions/FileImporter@master] Replace usage of the method IContextSource::getWikiPage that will be deprecated, to WikiPageFactory usage
Change 739274 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Replace usage of the method IContextSource::getWikiPage that will be deprecated, to WikiPageFactory usage
Change 739547 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):
[mediawiki/skins/MinervaNeue@master] Replace usage of the methods IContextSource::getWikiPage & canUseWikiPage that will be deprecated to WikiPageFactory usage
Change 702614 merged by jenkins-bot:
[mediawiki/core@master] Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage
Change 739547 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Replace usage of the methods IContextSource::getWikiPage & canUseWikiPage that will be deprecated to WikiPageFactory usage
For reference, this was reverted because of T297744: Page tabs like "Edit", "View history" do not appear on Special:WhatLinksHere.
Change 747227 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[mediawiki/core@master] Replace deprecated IContextSource methods (attempt #2)
Change 702372 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Hard deprecate IContextSource::getWikiPage and IContextSource::canUseWikiPage
WikiPage instances are expensive to instantiate because initializing them always requires a DB query. If IContextSource::getWikiPage calls are to be replaced by instantiations via WikiPageFactory, then every extension that needs access to the WikiPage instance corresponding to the current page will trigger a new, effectively redundant, DB query. I think this cost needs to be considered here.
Thanks @TK-999. It seems like using WikiPageFactory for the current page would be a step back in terms of performance. The reason the current patches haven't caused issues is likely because they're largely in relatively cold areas.
In terms of injection, I don't see any particular issue with exposing it via RequestContext. The object is created by the web entry point (e.g. MediaWiki.php) and then injected through RequestContext to anything that may need it, the same way it communicates the Title and User as well. I don't think that's something that is worth deprecating or changing.
Access to WikiPage *outside* RequestContet seems fine to migrate, although that too incurs database query costs. The way we generally solve this is through the LinkCache, which is meant to ensure the same page records aren't fetched multiple times int the same request (up to a certain limit).
Perhaps this is not working correctly? If PageStore bypasses it, or is asking for more than we cache, that needs to be fixed before wider adoption. Or perhaps the inverse is true, where WikiPage needs more than PageStore/LinkCache retain, and this adoption would change the order such that WikiPage comes second and then has to download the row a second time.
Assinging to @daniel to look at when he comes back in two weeks.
Change 964428 had a related patch set uploaded (by Robert Vogel; author: Roman Stolar):
[mediawiki/extensions/CognitiveProcessDesigner@REL1_39] Replace deprecated method `IContextSource::getWikiPage`
Change 964429 had a related patch set uploaded (by Robert Vogel; author: Roman Stolar):
[mediawiki/extensions/CognitiveProcessDesigner@REL1_39-3.0.x] Replace deprecated method `IContextSource::getWikiPage`
Perhaps one option could be to add a new method to WikiPageFactory that returns an optionally cached WikiPage instance for a given PageIdentity. That could then be used as a replacement without a performance cost.
Change 964428 merged by Robert Vogel:
[mediawiki/extensions/CognitiveProcessDesigner@REL1_39] Replace deprecated method `IContextSource::getWikiPage`
Change 701901 merged by Robert Vogel:
[mediawiki/extensions/CognitiveProcessDesigner@master] Replace deprecated method `IContextSource::getWikiPage`
Change 964429 merged by Robert Vogel:
[mediawiki/extensions/CognitiveProcessDesigner@REL1_39-3.0.x] Replace deprecated method `IContextSource::getWikiPage`
Change 739128 abandoned by Daniel Kinzler:
[mediawiki/extensions/AbuseFilter@master] Replace usage of the method IContextSource::getWikiPage that will be deprecated to WikiPageFactory usage
Reason:
obsolete