Remove IE<9 CSS hacks from portals CSS
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdrewniak
	Mar 14 2021, 2:28 PM

Description

The portals repo was created with ancient browsers like IE6 in mind, and thus included CSS hacks to account for these ancient browser quirks. Since browsers lower than IE9 cannot access Wikimedia properties due to TLS 1.2 limitations, it makes sense to remove these hacks from the codebase.

Acceptance Criteria

The file https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/portals/+/refs/heads/master/dev/wikipedia.org/assets/postcss/_ie.css is removed
The reference to that file is removed from https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/portals/+/refs/heads/master/dev/wikipedia.org/assets/postcss/README.txt
The import of that file is removed from https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/portals/+/refs/heads/master/dev/wikipedia.org/assets/postcss/style.css

Details

	Subject	Repo	Branch	Lines +/-
	Remove unnecessary IE<9 CSS hacks from portals CSS	wikimedia/portals	master	+0 -54

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T277404 [EPIC] Modernize portals code for browser support and maintainability
		Resolved		Tsiruot	T277408 Remove IE<9 CSS hacks from portals CSS

Event Timeline

Jdrewniak created this task.Mar 14 2021, 2:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2021, 2:28 PM

Jdrewniak triaged this task as Low priority.Mar 14 2021, 2:30 PM

Jdrewniak moved this task from Untriaged to Code Quality / Tech Debt on the Wikimedia-Portals board.

Jdrewniak added a parent task: T277404: [EPIC] Modernize portals code for browser support and maintainability.

Jdrewniak mentioned this in T273179: Update the front-page of Wikimedia projects.Mar 14 2021, 2:38 PM

Tsiruot claimed this task.Mar 14 2021, 2:59 PM

Change 672011 had a related patch set uploaded (by Ishan Saini; owner: Ishan Saini):
[wikimedia/portals@master] Remove unnecessary IE<9 CSS hacks from portals CSS

https://gerrit.wikimedia.org/r/672011

gerritbot added a project: Patch-For-Review.Mar 14 2021, 3:11 PM

I think we can also correct the conditional comments here, for versions less than or equal to 9. Make it a rule just for equal IE9.
https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/portals/+/refs/heads/master/dev/wikipedia.org/index.handlebars

I have added a patch which fulfill all the criterias mentioned above.

Change 672011 merged by jenkins-bot:
[wikimedia/portals@master] Remove unnecessary IE<9 CSS hacks from portals CSS

https://gerrit.wikimedia.org/r/672011

Tsiruot closed this task as Resolved.Mar 14 2021, 5:07 PM

Tsiruot removed Tsiruot as the assignee of this task.

Tsiruot subscribed.

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2021, 5:10 PM

Tsiruot claimed this task.Mar 17 2021, 7:23 AM