Add a link: dialog for no suggestions available
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MMiller_WMF
	Mar 15 2021, 8:37 PM

Description

This edge case is possible: a user chooses a suggested article from the feed, but then there are not actually any suggestions available when they arrive on the article. This can happen because another user has added all the links since the feed was refreshed, among other reasons.

In this case:

The user should see a simple error dialog.
It should say, "Suggestions are no longer available on this article."
The button should say, "Back to suggested edits"
The button should go back to the suggested edits module on mobile, or back to the homepage on desktop.

Instrumentation

See T278112: Instrumentation: dialog for no suggestions available for details.

Details

	Subject	Repo	Branch	Lines +/-
	No suggestions dialog: Use more robust method to bring user back to Homepage	mediawiki/extensions/GrowthExperiments	master	+1 -3
	Add a link: dialog for no suggestions available	mediawiki/extensions/GrowthExperiments	master	+20 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	MMiller_WMF	T252822 [EPIC] Growth: "add a link" structured task 1.0
Resolved	kostajh	T268704 Add a link: frontend product specifications
Resolved	kostajh	T277508 Add a link: dialog for no suggestions available

Event Timeline

MMiller_WMF created this task.Mar 15 2021, 8:37 PM

We should also log details of the error to the console, for easier debugging. And maybe send it to the Javscript error feed in logstash, although these are not necessarily errors in the programming sense so that's debatable.

kostajh moved this task from Backlog to Post-release backlog on the Add-Link board.Mar 22 2021, 10:38 AM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 22 2021, 10:59 AM

kostajh updated the task description. (Show Details)Mar 22 2021, 12:20 PM

kostajh mentioned this in T278112: Instrumentation: dialog for no suggestions available.

kostajh claimed this task.Mar 22 2021, 2:32 PM

kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Desktop:

Mobile:

Change 674141 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Add a link: dialog for no suggestions available

https://gerrit.wikimedia.org/r/674141

gerritbot added a project: Patch-For-Review.Mar 22 2021, 8:37 PM

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 22 2021, 8:37 PM

kostajh moved this task from Post-release backlog to In progress on the Add-Link board.

In T277508#6916759, @Tgr wrote:

We should also log details of the error to the console, for easier debugging. And maybe send it to the Javscript error feed in logstash, although these are not necessarily errors in the programming sense so that's debatable.

What details would you want to log? We currently have mw.log.error( suggestedEditSession.taskData.error ); which just tells us that we failed to get the task data.

Logging the error message should suffice. Knowing why the data could not be retrieved can be informative.

• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 24 2021, 4:59 PM

Change 674141 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: dialog for no suggestions available

https://gerrit.wikimedia.org/r/674141

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 24 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2021, 6:10 PM

kostajh moved this task from In progress to Done / QA on the Add-Link board.Mar 29 2021, 11:30 AM

kostajh mentioned this in T276838: Add Links: Cannot read property 'link_target' of undefined.Apr 6 2021, 1:01 PM

The back button is using router.back(), which doesn't do the expected thing when the page has been accessed via the task card in the post-edit dialog.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM

• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:43 PM

leila unsubscribed.Apr 20 2021, 4:57 PM

MBinder_WMF unsubscribed.Apr 26 2021, 5:36 PM

For @RHo review - as per the screenshots in @kostajh comment and my testing - all specs seem to be in place:

suggestions_not_available 2021-04-28 at 11.42.59 AM.png (716×1 px, 61 KB)

Change 683981 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] No suggestions dialog: Use more robust method to bring user back to Homepage

https://gerrit.wikimedia.org/r/683981

gerritbot added a project: Patch-For-Review.Apr 30 2021, 7:22 PM

Change 683981 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] No suggestions dialog: Use more robust method to bring user back to Homepage

https://gerrit.wikimedia.org/r/683981

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 2 2021, 9:00 PM

Super, thanks all

Catrope unsubscribed.May 3 2021, 4:15 PM

RHo mentioned this in T291902: Add an image: dialog for no suggestions available.Sep 28 2021, 7:33 AM

	F34435066: suggestions_not_available 2021-04-28 at 11.42.59 AM.png
	Apr 30 2021, 1:55 AM

	F34179697: image.png
	Mar 22 2021, 8:36 PM

	F34179694: image.png
	Mar 22 2021, 8:36 PM

Add a link: dialog for no suggestions availableClosed, ResolvedPublicActions