Page MenuHomePhabricator
Create Task
Maniphest T279369

Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement
Closed, ResolvedPublic
Actions

Description

Linker::link() and Linker::linkKnown() functions are deprecated as of MediaWiki 1.28, and the new LinkRenderer is preferred instead.
https://doc.wikimedia.org/mediawiki-core/master/php/classLinker.html

./RevisionCommentSupplement/RevisionCommentSupplement.hook.php:				Linker::linkKnown(
./RevisionCommentSupplement/special/SpecialRevisionCommentSupplement.php:			$link = Linker::linkKnown(
./RevisionCommentSupplement/special/SpecialRevisionCommentSupplement.php:								Linker::linkKnown(
./RevisionCommentSupplement/special/SpecialRevisionCommentSupplement.php:						Linker::linkKnown(
./RevisionCommentSupplement/special/SpecialRevisionCommentSupplement.php:						Linker::linkKnown(
./RevisionCommentSupplement/special/SpecialRevisionCommentSupplement.php:						Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementDelete.php:			$link = Linker::link(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementHideHistory.php:			$link = Linker::link(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementHideHistory.php:					Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementHideHistory.php:					Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementHideHistory.php:					Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementHideHistory.php:					Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementHistory.php:					$hide = '(' . Linker::link(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementList.php:					$link .= Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementList.php:				$link .= Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementList.php:				$link = Linker::linkKnown(
./RevisionCommentSupplement/special/ViewRevisionCommentSupplementList.php:					return Linker::linkKnown(

Details

SubjectRepoBranchLines +/-
Replace Linker::linkKnown() with LinkRenderer, second timemediawiki/extensions/RevisionCommentSupplementmaster+3 -1
Replace Linker::link() and linkKnown() with LinkRenderer servicemediawiki/extensions/RevisionCommentSupplementmaster+27 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

Aklapper created this task.Apr 5 2021, 7:51 PM
gerritbot added a comment.Jul 15 2022, 11:48 PM

Change 814265 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/RevisionCommentSupplement@master] Replace Linker::link() and linkKnown() with LinkRenderer service

https://gerrit.wikimedia.org/r/814265

gerritbot added a project: Patch-For-Review.Jul 15 2022, 11:48 PM
Southparkfan claimed this task.Jul 15 2022, 11:48 PM
gerritbot added a comment.Jul 18 2022, 5:18 PM

Change 814265 merged by jenkins-bot:

[mediawiki/extensions/RevisionCommentSupplement@master] Replace Linker::link() and linkKnown() with LinkRenderer service

https://gerrit.wikimedia.org/r/814265

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2022, 5:30 PM
Southparkfan closed this task as Resolved.Jul 18 2022, 7:39 PM
Southparkfan reopened this task as Open.

Nevermind, missed one occurrence :P

gerritbot added a comment.Jul 18 2022, 7:48 PM

Change 814889 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/RevisionCommentSupplement@master] Replace Linker::linkKnown() with LinkRenderer, second time

https://gerrit.wikimedia.org/r/814889

gerritbot added a project: Patch-For-Review.Jul 18 2022, 7:48 PM
gerritbot added a comment.Jul 18 2022, 7:53 PM

Change 814889 merged by jenkins-bot:

[mediawiki/extensions/RevisionCommentSupplement@master] Replace Linker::linkKnown() with LinkRenderer, second time

https://gerrit.wikimedia.org/r/814889

Southparkfan closed this task as Resolved.Jul 18 2022, 7:58 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2022, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL