Page MenuHomePhabricator

Remove partial action blocks feature flag
Open, Needs TriagePublic

Description

Once work is completed on partial action blocks, and its has been successfully deployed, remove the $wgEnablePartialActionBlocks flag.

This will involve updates to:

  • MediaWiki core
  • mediawiki-config repo

Related Objects

Event Timeline

Just noticed in DefaultSettings.php..

/**
 * Flag to enable partial blocks against performing certain actions.
 *
 * @unstable Temporary feature flag, to be removed before the release of 1.37: T280532
 * @var bool
 */
$wgEnablePartialActionBlocks = false;

Comment needs updating, or flag removing...

Change 726722 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] DefaultSettings.php: Update removal comment of $wgEnablePartialActionBlocks

https://gerrit.wikimedia.org/r/726722

Change 726598 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_37] DefaultSettings.php: Update removal comment of $wgEnablePartialActionBlocks

https://gerrit.wikimedia.org/r/726598

Change 726598 abandoned by Reedy:

[mediawiki/core@REL1_37] DefaultSettings.php: Update removal comment of $wgEnablePartialActionBlocks

Reason:

https://gerrit.wikimedia.org/r/726598

Change 726722 abandoned by Reedy:

[mediawiki/core@master] DefaultSettings.php: Update removal comment of $wgEnablePartialActionBlocks

Reason:

https://gerrit.wikimedia.org/r/726722

Krinkle added a project: MW-1.39-release.
Krinkle subscribed.

From a quick analysis, this does not appear to be a release blocker. It's a missed intent for something that would have been nice. Given that it has an open subtask, I'm tentatively adding it to the next release instead.

Izno subscribed.

Probably shouldn't be tagged for a specific release at this point and probably not before it's widely deployed on WMF.