Page MenuHomePhabricator
Create Task
Maniphest T281103

Update how we measure LayoutShift
Closed, ResolvedPublic
Actions

Description

Google announced that they are changing how they measure CLS and I think we should follow so we measure the same way as they when they push the change: https://web.dev/evolving-cls/

Details

SubjectRepoBranchLines +/-
eventlogging: Remove obsoleted navtiming schemasoperations/puppetproduction+0 -10
Remove elementtiming,firstinputtiming,layoutshift,resourcetiming,rumspeedindexschemas/event/secondarymaster+0 -2 K
Remove former EventLogging streams for navtimingoperations/mediawiki-configmaster+0 -48
Add cumulative layout shift and largest contenful paint.performance/navtimingmaster+302 -4
Add test for multiple CLS frames and roundingmediawiki/extensions/NavigationTimingmaster+5 -2
Collect Cumulative Layout Shift instead of just Layout Shiftmediawiki/extensions/NavigationTimingmaster+44 -129
navtiming: Add cumulative layout shift and largest contentful paint.schemas/event/secondarymaster+412 -3
Add cumuluative layout schema.schemas/event/secondarymaster+197 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Peter created this task.Apr 26 2021, 9:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 9:22 AM
• Gilles claimed this task.Apr 26 2021, 6:29 PM
• Gilles moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
• Gilles added a comment.Apr 28 2021, 4:56 AM

Confirmation from Michal of which code we should use: https://twitter.com/mmocny/status/1387161141097517067

Peter added a comment.May 10 2021, 12:42 PM

@Gilles do you know if there is a new name too?

• Gilles added a comment.May 11 2021, 10:27 AM

Not that I know of, but that was still being debated at recent meetings

Peter mentioned this in T286703: Navigation Timing cleanup.Jul 15 2021, 8:54 AM
Krinkle removed • Gilles as the assignee of this task.Aug 9 2021, 6:58 PM
Krinkle moved this task from Doing: Prio Interrupt to Inbox, needs triage on the Performance-Team board.
Krinkle added a subscriber: • Gilles.
• dpifke assigned this task to Peter.Aug 10 2021, 6:57 PM
• dpifke moved this task from Inbox, needs triage to Doing: Goals on the Performance-Team board.
Peter added a parent task: T290019: Review navigation timing extension.Aug 30 2021, 4:28 PM
Peter moved this task from Doing: Goals to To-do: Goals prioritized current Quarter on the Performance-Team board.Sep 20 2021, 6:23 PM
Peter moved this task from To-do: Goals prioritized current Quarter to Backlog: Maintenance, non-prioritized on the Performance-Team board.Sep 20 2021, 6:43 PM
Peter moved this task from Backlog: Maintenance, non-prioritized to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.
Peter added a parent task: T319329: Expand navigation timing metrics to include user experience metrics and modernise navigation timing.Oct 4 2022, 6:18 PM
larissagaulia moved this task from To-do: Goals, prioritized next 4 Quarters to To-do: Goals prioritized current Quarter on the Performance-Team board.Oct 18 2022, 7:26 PM
Krinkle mentioned this in T319329: Expand navigation timing metrics to include user experience metrics and modernise navigation timing.Oct 18 2022, 9:32 PM
gerritbot added a comment.Oct 20 2022, 7:52 AM

Change 844911 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/extensions/NavigationTiming@master] Collect Cumulative Layout Shift instead of just Layout Shift.

https://gerrit.wikimedia.org/r/844911

gerritbot added a project: Patch-For-Review.Oct 20 2022, 7:52 AM
Peter moved this task from To-do: Goals prioritized current Quarter to Doing: Goals on the Performance-Team board.Oct 21 2022, 12:45 PM
gerritbot added a comment.Nov 22 2022, 8:52 AM

Change 859433 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[schemas/event/secondary@master] Add cumuluative layout schema.

https://gerrit.wikimedia.org/r/859433

gerritbot added a comment.Nov 22 2022, 4:21 PM

Change 859433 abandoned by Phedenskog:

[schemas/event/secondary@master] Add cumuluative layout schema.

Reason:

Lest add this to navtiming

https://gerrit.wikimedia.org/r/859433

gerritbot added a comment.Nov 23 2022, 8:03 AM

Change 859968 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[schemas/event/secondary@master] navtiming: Add cumulative layout shift and largest contentful paint.

https://gerrit.wikimedia.org/r/859968

gerritbot added a comment.Nov 25 2022, 10:05 AM

Change 860842 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/NavigationTiming@master] Add test for multiple CLS frames and rounding

https://gerrit.wikimedia.org/r/860842

gerritbot added a comment.Nov 25 2022, 10:06 AM

Change 859968 merged by jenkins-bot:

[schemas/event/secondary@master] navtiming: Add cumulative layout shift and largest contentful paint.

https://gerrit.wikimedia.org/r/859968

gerritbot added a comment.Nov 25 2022, 10:48 AM

Change 844911 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] Collect Cumulative Layout Shift instead of just Layout Shift

https://gerrit.wikimedia.org/r/844911

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 25 2022, 11:01 AM
gerritbot added a comment.Nov 25 2022, 5:03 PM

Change 860842 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] Add test for multiple CLS frames and rounding

https://gerrit.wikimedia.org/r/860842

Maintenance_bot removed a project: Patch-For-Review.Nov 25 2022, 5:30 PM
gerritbot added a comment.Nov 28 2022, 9:18 AM

Change 861343 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[performance/navtiming@master] Add cumulative layout shift and largest contenful paint.

https://gerrit.wikimedia.org/r/861343

gerritbot added a project: Patch-For-Review.Nov 28 2022, 9:18 AM
gerritbot added a comment.Dec 13 2022, 6:40 AM

Change 861343 merged by jenkins-bot:

[performance/navtiming@master] Add cumulative layout shift and largest contenful paint.

https://gerrit.wikimedia.org/r/861343

Peter closed this task as Resolved.Dec 19 2022, 7:30 AM
gerritbot added a comment.Jan 14 2023, 6:13 PM

Change 726852 had a related patch set uploaded (by Krinkle; author: Peter Hedenskog):

[operations/puppet@production] eventlogging: Remove obsoleted navtiming schemas

https://gerrit.wikimedia.org/r/726852

gerritbot added a comment.Jan 14 2023, 6:16 PM

Change 879926 had a related patch set uploaded (by Krinkle; author: Krinkle):

[operations/mediawiki-config@master] Remove former EventLogging streams for navtiming

https://gerrit.wikimedia.org/r/879926

gerritbot added a comment.Feb 1 2023, 8:17 AM

Change 879926 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove former EventLogging streams for navtiming

https://gerrit.wikimedia.org/r/879926

Stashbot mentioned this in T323623: Decomission the FirstInputTiming instrument from webperf pipeline.Feb 1 2023, 8:17 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:17:44Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:879926|Remove former EventLogging streams for navtiming (T281103 T286703 T308621 T323623)]]

Stashbot mentioned this in T308621: Remove inactive code for Element Timing experiment.Feb 1 2023, 8:17 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:19:32Z] <ladsgroup@deploy1002> ladsgroup and krinkle: Backport for [[gerrit:879926|Remove former EventLogging streams for navtiming (T281103 T286703 T308621 T323623)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Stashbot added a comment.Feb 1 2023, 8:27 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:27:27Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:879926|Remove former EventLogging streams for navtiming (T281103 T286703 T308621 T323623)]] (duration: 09m 42s)

gerritbot added a comment.Feb 7 2023, 6:07 PM

Change 726852 merged by Ottomata:

[operations/puppet@production] eventlogging: Remove obsoleted navtiming schemas

https://gerrit.wikimedia.org/r/726852

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2023, 6:32 PM
gerritbot added a comment.Feb 7 2023, 11:37 PM

Change 887425 had a related patch set uploaded (by Krinkle; author: Krinkle):

[schemas/event/secondary@master] Remove elementtiming,firstinputtiming,layoutshift,resourcetiming,rumspeedindex

https://gerrit.wikimedia.org/r/887425

gerritbot added a project: Patch-For-Review.Feb 7 2023, 11:37 PM
gerritbot added a comment.Feb 8 2023, 10:03 PM

Change 887425 merged by jenkins-bot:

[schemas/event/secondary@master] Remove elementtiming,firstinputtiming,layoutshift,resourcetiming,rumspeedindex

https://gerrit.wikimedia.org/r/887425

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2023, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL