Page MenuHomePhabricator
Create Task
Maniphest T284777

PHP Deprecated: Passing extra fields (quality) to LocalFile::loadFromRow was deprecated in MediaWiki 1.37. Property assignment will be removed in a later version. [Called from OldLocalFile::loadFromRow]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Passing extra fields (quality) to LocalFile::loadFromRow was deprecated in MediaWiki 1.37. Property assignment will be removed in a later version. [Called from OldLocalFile::loadFromRow]
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.9/includes/filerepo/file/OldLocalFile.php(202)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.37.0-wmf.9/includes/debug/MWDebug.php(376): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.37.0-wmf.9/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.37.0-wmf.9/includes/GlobalFunctions.php(1030): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.9/includes/filerepo/file/LocalFile.php(668): wfDeprecatedMsg(string, string)
#5 /srv/mediawiki/php-1.37.0-wmf.9/includes/filerepo/file/OldLocalFile.php(202): LocalFile->loadFromRow(stdClass, string)
#6 /srv/mediawiki/php-1.37.0-wmf.9/includes/filerepo/file/OldLocalFile.php(83): OldLocalFile->loadFromRow(stdClass, string)
#7 /srv/mediawiki/php-1.37.0-wmf.9/includes/filerepo/LocalRepo.php(85): OldLocalFile::newFromRow(stdClass, LocalRepo)
#8 /srv/mediawiki/php-1.37.0-wmf.9/includes/filerepo/file/LocalFile.php(1266): LocalRepo->newFileFromRow(stdClass)
#9 /srv/mediawiki/php-1.37.0-wmf.9/includes/api/ApiQueryImageInfo.php(203): LocalFile->getHistory(integer, NULL, NULL)
#10 /srv/mediawiki/php-1.37.0-wmf.9/includes/api/ApiQuery.php(333): ApiQueryImageInfo->execute()
#11 /srv/mediawiki/php-1.37.0-wmf.9/includes/api/ApiMain.php(1714): ApiQuery->execute()
#12 /srv/mediawiki/php-1.37.0-wmf.9/includes/api/ApiMain.php(684): ApiMain->executeAction()
#13 /srv/mediawiki/php-1.37.0-wmf.9/includes/api/ApiMain.php(655): ApiMain->executeActionWithErrorHandling()
#14 /srv/mediawiki/php-1.37.0-wmf.9/api.php(90): ApiMain->execute()
#15 /srv/mediawiki/php-1.37.0-wmf.9/api.php(45): wfApiMain()
#16 /srv/mediawiki/w/api.php(3): require(string)
#17 {main}
Impact

~900 occurrences in the 15 minute period following deployment to group2

Notes

Details

Request URL
https://de.wikipedia.org/w/api.php?action=query&format=*&prop=*&titles=*&iiprop=*&iiextmetadatafilter=*&iiextmetadatalanguage=*&uselang=*&smaxage=*&maxage=*
SubjectRepoBranchLines +/-
Drop LocalFile::getHistory hook handlermediawiki/extensions/FlaggedRevswmf/1.37.0-wmf.9+0 -44
Deprecate LocalFile::getHistory hookmediawiki/coremaster+3 -1
Drop LocalFile::getHistory hook handlermediawiki/extensions/FlaggedRevsmaster+0 -44
Customize query in gerrit

Related Objects
Search...

Event Timeline

jeena created this task.Jun 10 2021, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2021, 7:18 PM
jeena added a parent task: T281152: 1.37.0-wmf.11 deployment blockers.Jun 10 2021, 7:19 PM
• Pchelolo added subscribers: tstarling, • Pchelolo.Jun 10 2021, 7:59 PM

cc @tstarling

Ladsgroup claimed this task.Jun 11 2021, 7:03 AM
Ladsgroup subscribed.

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/697895/4/includes/filerepo/file/LocalFile.php

I'm looking into it.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 11 2021, 7:03 AM
Ladsgroup added a comment.Jun 11 2021, 7:32 AM

The problem is the one and only FlaggedRevs. It changes the fields of querying oldimage and adds fr_quality, in turn the class tries to apply it. I'm not sure why such hook even exists, it's undocumented and its usage in FlaggedRevs doesn't give any benefits either. Looking further.

gerritbot added a comment.Jun 11 2021, 7:55 AM

Change 699381 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/FlaggedRevs@master] Drop LocalFile::getHistory hook handler

https://gerrit.wikimedia.org/r/699381

gerritbot added a project: Patch-For-Review.Jun 11 2021, 7:55 AM
gerritbot added a comment.Jun 11 2021, 8:17 AM

Change 699383 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] Deprecate LocalFile::getHistory

https://gerrit.wikimedia.org/r/699383

gerritbot added a comment.Jun 11 2021, 3:20 PM

Change 699381 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Drop LocalFile::getHistory hook handler

https://gerrit.wikimedia.org/r/699381

Krinkle moved this task from Untriaged to June 2021 on the Wikimedia-production-error board.Jun 11 2021, 4:37 PM
gerritbot added a comment.Jun 17 2021, 4:26 PM

Change 699383 merged by jenkins-bot:

[mediawiki/core@master] Deprecate LocalFile::getHistory hook

https://gerrit.wikimedia.org/r/699383

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 17 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 17 2021, 5:10 PM
gerritbot added a comment.Jun 21 2021, 9:42 AM

Change 700340 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/FlaggedRevs@wmf/1.37.0-wmf.9] Drop LocalFile::getHistory hook handler

https://gerrit.wikimedia.org/r/700340

gerritbot added a project: Patch-For-Review.Jun 21 2021, 9:42 AM
gerritbot added a comment.Jun 21 2021, 9:49 AM

Change 700340 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.37.0-wmf.9] Drop LocalFile::getHistory hook handler

https://gerrit.wikimedia.org/r/700340

Stashbot added a comment.Jun 21 2021, 9:55 AM

Mentioned in SAL (#wikimedia-operations) [2021-06-21T09:55:32Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.9/extensions/FlaggedRevs: Backport: [[gerrit:700340|Drop LocalFile::getHistory hook handler (T284777 T277883)]] (duration: 00m 58s)

Stashbot mentioned this in T277883: Drop all low-use and unused features of FlaggedRevs to make it more maintainable.Jun 21 2021, 9:55 AM
Ladsgroup closed this task as Resolved.Jun 21 2021, 9:59 AM

image.png (221×1 px, 26 KB)

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2021, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL