Page MenuHomePhabricator
Create Task
Maniphest T288109

Wikipedia Preview Wordmark size
Closed, ResolvedPublic
Actions

Description

the wordmark we are using is alright in the size https://wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-en.svg

I found the following size is very big
https://wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-zh.svg
https://wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-zh-c.svg (this file is no longer available)

image.png (246×722 px, 80 KB)

Storybook Demo: https://wikimedia.github.io/wikipedia-preview/storybook-static/?path=/story/wikipedia-preview--standard-with-image&args=lang:zh-c

NOTE: maybe max-height / max-width can help to prevent big image?

Event Timeline

hueitan created this task.Aug 4 2021, 2:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2021, 2:27 PM
SBisson edited projects, added Inuka-Team (Kanban); removed Inuka-Team.Feb 21 2024, 4:30 PM
SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Feb 21 2024, 4:34 PM
SBisson subscribed.

I would like us to revisit this issue.

Maybe we could start by creating single storybook page with a preview in all supported wordmark languages so we can quickly evaluate if this is still an issue.

SBisson triaged this task as Medium priority.Feb 21 2024, 4:35 PM
hueitan updated the task description. (Show Details)Feb 22 2024, 3:02 AM
hueitan added a comment.Feb 22 2024, 7:06 AM

Maybe we could start by creating single storybook page with a preview in all supported wordmark languages so we can quickly evaluate if this is still an issue.

We can already check all supported workmark lang in the storybook now, but you need to go through one by one
https://wikimedia.github.io/wikipedia-preview/main/storybook/?path=/story/wikipedia-preview--standard-with-image&args=lang:atj

hueitan added a comment.EditedFeb 22 2024, 7:18 AM

a quick look of all existing workmark, it looks fine to me

Screenshot 2024-02-22 at 15.16.39.png (1×754 px, 252 KB)
Screenshot 2024-02-22 at 15.16.49.png (1×744 px, 243 KB)
Screenshot 2024-02-22 at 15.16.56.png (1×742 px, 139 KB)
SBisson added a subscriber: SGautam_WMF.Feb 22 2024, 4:13 PM

@SGautam_WMF what do you think of the various wordmarks in the images above? If you think they are OK we can resolve this task.

SGautam_WMF added a comment.Mar 1 2024, 12:55 PM
In T288109#9568429, @SBisson wrote:

@SGautam_WMF what do you think of the various wordmarks in the images above? If you think they are OK we can resolve this task.

Looks good to me, we can resolve this task.

SBisson closed this task as Resolved.Mar 1 2024, 1:58 PM
SBisson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL