Page MenuHomePhabricator
Create Task
Maniphest T288324

WARNING: In GitLab 14.0 we will begin removing all configuration backups older than yourgitlab_rails['backup_keep_time'] setting (currently set to: 259200)
Closed, ResolvedPublic
Actions

Description

The following WARNING is being sent to all root inboxes:

Cron <root@gitlab1001> /usr/bin/gitlab-ctl backup-etc >/dev/null && (find /etc/gitlab/config_backup/ -maxdepth 1 -type f -name 'gitlab_config*.tar' -mtime +6 | xargs -d '\n' -r rm --) && ls -t /etc/gitlab/config_backup/gitlab_config*.tar | head -n1 | xargs -i cp {} /etc/gitlab/config_backup/latest/latest.tar

WARNING: In GitLab 14.0 we will begin removing all configuration backups older than yourgitlab_rails['backup_keep_time'] setting (currently set to: 259200)

Details

SubjectRepoBranchLines +/-
gitlab::backup make config backup less verboseoperations/puppetproduction+1 -1
gitlab::backup remove deprication warning and deletion of config backupoperations/puppetproduction+1 -3
fix shell for backup cronjoboperations/gitlab-ansiblemaster+3 -0
remove backup warning for config backupsoperations/gitlab-ansiblemaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

jcrespo created this task.Aug 6 2021, 7:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2021, 7:17 AM
LSobanski subscribed.Aug 6 2021, 7:36 AM
Jelto subscribed.Aug 6 2021, 9:37 AM
Jelto claimed this task.Aug 6 2021, 10:24 AM
gerritbot added a comment.Aug 6 2021, 12:08 PM

Change 710529 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/gitlab-ansible@master] remove backup warning for config backups

https://gerrit.wikimedia.org/r/710529

gerritbot added a project: Patch-For-Review.Aug 6 2021, 12:08 PM
gerritbot added a comment.Aug 6 2021, 5:35 PM

Change 710529 merged by Brennen Bearnes:

[operations/gitlab-ansible@master] remove backup warning for config backups

https://gerrit.wikimedia.org/r/710529

Stashbot added a comment.Aug 6 2021, 5:39 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-06T17:39:01Z] <brennen> gitlab: run ansible to apply [[gerrit:710529|remove backup warning for config backups]] (T288324)

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2021, 6:10 PM
gerritbot added a comment.Aug 8 2021, 10:30 AM

Change 710676 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/gitlab-ansible@master] fix shell for backup cronjob

https://gerrit.wikimedia.org/r/710676

gerritbot added a project: Patch-For-Review.Aug 8 2021, 10:30 AM
jcrespo added a comment.Aug 10 2021, 8:18 AM

We now get:

Cron <root@gitlab1001> /usr/bin/gitlab-ctl backup-etc 2> >(grep -v "In GitLab 14.0 we will begin removing all configuration backups") >/dev/null && (find /etc/gitlab/config_backup/ -maxdepth 1 -type f -name 'gitlab_config*.tar' -mtime +6 | xargs -d '\n' -r rm --) && ls -t /etc/gitlab/config_backup/gitlab_config*.tar | head -n1 | xargs -i cp {} /etc/gitlab/config_backup/latest/latest.tar

/bin/sh: 1: Syntax error: redirection unexpected
gerritbot added a comment.Aug 10 2021, 4:20 PM

Change 710676 merged by Brennen Bearnes:

[operations/gitlab-ansible@master] fix shell for backup cronjob

https://gerrit.wikimedia.org/r/710676

Stashbot added a comment.Aug 10 2021, 4:25 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-10T16:25:20Z] <brennen> gitlab: run ansible to apply [[gerrit:710676|fix shell for backup cronjob]] (T288324)

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2021, 5:10 PM
Jelto added a comment.Aug 11 2021, 6:57 AM

Should be fixed with https://gerrit.wikimedia.org/r/710676. No new error message from root@gitlab1001

brennen triaged this task as Low priority.Aug 12 2021, 12:07 AM
brennen added a project: User-brennen.

The unnecessary grep here should probably be removed once we upgrade to 14.x. Leaving this open for the time being.

brennen moved this task from Backlog to Radar on the User-brennen board.Aug 12 2021, 12:07 AM
brennen edited projects, added Release-Engineering-Team (Radar); removed Release-Engineering-Team.
gerritbot added a comment.Sep 9 2021, 9:01 AM

Change 719930 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/puppet@production] gitlab::backup remove deprication warning and deletion of config backup

https://gerrit.wikimedia.org/r/719930

gerritbot added a project: Patch-For-Review.Sep 9 2021, 9:02 AM
gerritbot added a comment.Sep 10 2021, 7:49 AM

Change 719930 merged by Jelto:

[operations/puppet@production] gitlab::backup remove deprication warning and deletion of config backup

https://gerrit.wikimedia.org/r/719930

Maintenance_bot removed a project: Patch-For-Review.Sep 10 2021, 8:10 AM
gerritbot added a comment.Sep 10 2021, 1:58 PM

Change 720316 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/puppet@production] gitlab::backup make config backup less verbose

https://gerrit.wikimedia.org/r/720316

gerritbot added a project: Patch-For-Review.Sep 10 2021, 1:58 PM
Jelto closed this task as Resolved.Sep 15 2021, 6:41 AM

The warning was removed in the GitLab upgrade to 14.x (https://phabricator.wikimedia.org/T289802.) The grep was removed in https://gerrit.wikimedia.org/r/719930. So I'm closing this issue.
Feel free to open again.

gerritbot added a comment.Sep 15 2021, 6:41 AM

Change 720316 abandoned by Jelto:

[operations/puppet@production] gitlab::backup make config backup less verbose

Reason:

change not needed

https://gerrit.wikimedia.org/r/720316

jcrespo awarded a token.Sep 15 2021, 7:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL