Updated mocks show a 'Turn on push notifications' button and a 'dismiss' link. Tapping 'Turn on push notifications' will trigger the in app model for push permissions and then follow the flow for 'Contributor logs into the app for the first time after Notification update'.

@cmadeo

Sorry, I'm just now looking at this. I've got some new error cases that need to be handled on this one, but even in the success case I'm not certain what will happen. Can you clarify?

1. Success: User taps "Turn on push" > permissions prompt appears > User allows permissions (behind the scenes we'll also subscribe their device token, that succeeds) > Card hides and user stays on Explore feed? Or user is pushed to Notification Center?
2. Failure: User taps "Turn on push" > permissions prompt appears > User denies permissions > ?
3. Failure: User taps "Turn on push" > permissions prompt appears > User allows permissions (behind the scenes we'll also need to subscribe their device token, but that fails) > ?
4. Failure: User is logged out, so we cannot subscribe their device token behind the scenes.

Suggestion for the failure cases 2 & 3 is that we have some sort of prompt saying there was an issue (missing permissions or issue with subscription), and they can try again later in our Notification Push Settings screen since we're handling all possible error cases there. Then hide the card. Otherwise I think it'll be difficult to handle these error cases within this tiny card.

For failure case 4 I suggest we hide the card if they aren't logged in.

Hi @Tsevener, as discussed in our meeting tapping on the CTA will bring users to the Settings screen and then pop the appropriate alerts / models.

Notes from grooming:

This task's explore feed card is meant to be new, as a new feature announcement. We also have an old notifications card that was only meant for the In the News notification, so we need to remove this as a part of this task.

Notes from eng sync: first check existing card show logic, we maybe be able to keep it and simply redesign/reroute if it mostly does what we want already.

Updated the associated flows for onboarding, please also see https://phabricator.wikimedia.org/T302633 for additional onboarding details and designs.

@cmadeo I made some task description tweaks, let me know if this looks okay:

• In general this is now framed from the perspective of updating our existing Explore feed push notifications card. I thought this would be easier for us to work against.
• Added a "Navigate to Settings > Notifications" callout as discussed in https://phabricator.wikimedia.org/T302633#7745960
• I removed the screenshot of the flow, since it doesn't mention anything about the Explore feed card. I thought this might make it less confusing as to the scope of this particular ticket.

I do have a couple of additional questions here:

1. It looks like our old card did not have the 3 dot icon in the header area, but your new mock does. Can you let us know what menu options / actions you expect when the user taps on this button?
2. Should this card be hidden if the user is not logged in? Note we cannot fully subscribe them to notifications in Settings > Notifications without being logged in.
3. Is that subtitle date meant to be whatever date the user first sees the card? Or the date of the release?

Thanks @Tsevener

It looks like our old card did not have the 3 dot icon in the header area, but your new mock does. Can you let us know what menu options / actions you expect when the user taps on this button?

Ah I'm surprised that our old card did not have this, could we have the menu lead to the options of 'Hide this card' and 'Customize Explore feed'

Should this card be hidden if the user is not logged in? Note we cannot fully subscribe them to notifications in Settings > Notifications without being logged in.

Yes, let's hide this card if possible when not logged in

Is that subtitle date meant to be whatever date the user first sees the card? Or the date of the release?

Whatever date the user first sees the card

@Tsevener your updates look good and I also updated the task description to include a new flow diagram. Thank you!

UI portion PR https://github.com/wikimedia/wikipedia-ios/pull/4163

@Mazevedo this is looking great! Thank you so much!

Two small tweaks:

In the app	Mock-up

• Would it be possible to remove the background fill (a light grey) from the Default presentation of the image?
• Question: It looks like the image is being slightly cropped, I can't tell if this is only on my smaller testing device?

Hi @cmadeo! Unfortunately, all the adjustment options crop the images a little (even on larger screens). The one used on the version you tested is the one that cropped the least. Would you like to try different image dimensions to see if it looks better?