Page MenuHomePhabricator
Create Task
Maniphest T289248

Drop stable check for images used in pages
Closed, ResolvedPublic
Actions

Description

Basically implement parts of https://gerrit.wikimedia.org/r/703040

This means flaggedimages table will be probably dropped

Details

SubjectRepoBranchLines +/-
Drop flaggedimages tablemediawiki/extensions/FlaggedRevsmaster+1 -29
Drop support for checking for stable versions of filesmediawiki/extensions/FlaggedRevsmaster+115 -1 K
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenLadsgroupT277883 Drop all low-use and unused features of FlaggedRevs to make it more maintainable
ResolvedMarosteguiT290340 Drop the flaggedimages table from Wikimedia production
ResolvedLadsgroupT289248 Drop stable check for images used in pages
· · ·

Event Timeline

Ladsgroup created this task.Aug 19 2021, 12:08 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 19 2021, 12:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Aug 21 2021, 3:17 PM

Change 714181 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Drop support for files

https://gerrit.wikimedia.org/r/714181

gerritbot added a project: Patch-For-Review.Aug 21 2021, 3:17 PM
gerritbot added a comment.Aug 24 2021, 2:33 AM

Change 714181 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Drop support for checking for stable versions of files

https://gerrit.wikimedia.org/r/714181

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2021, 3:10 AM
Marostegui added a comment.Aug 24 2021, 8:48 AM

This is very good news as this table is reaching considerable sizes on some wikis, like:
dewiki: 67G
ruwiki: 55G

• mmodell subscribed.Aug 31 2021, 7:03 PM

This should now be live on testwikis.

Ladsgroup added a comment.Aug 31 2021, 8:10 PM

unfortunately the only test wiki that has flaggedrevs seems to be test2wiki and it's on group1 :/

Ladsgroup added a comment.Sep 2 2021, 12:22 AM

On group1 now, tested now, so far looks good and no user has made a ticket against MediaWiki-extensions-FlaggedRevs

Ladsgroup added a comment.Sep 3 2021, 10:30 AM

It seems it's stable in production \o/

gerritbot added a comment.Sep 3 2021, 3:25 PM

Change 717445 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Drop flaggedimages table

https://gerrit.wikimedia.org/r/717445

gerritbot added a project: Patch-For-Review.Sep 3 2021, 3:25 PM
Jdforrester-WMF mentioned this in T290340: Drop the flaggedimages table from Wikimedia production.Sep 3 2021, 4:52 PM
Jdforrester-WMF added a parent task: T290340: Drop the flaggedimages table from Wikimedia production.
gerritbot added a comment.Sep 3 2021, 4:52 PM

Change 717445 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Drop flaggedimages table

https://gerrit.wikimedia.org/r/717445

Ladsgroup closed this task as Resolved.Sep 3 2021, 4:55 PM

This is done.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 3 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2021, 5:10 PM
stjn awarded a token.Sep 10 2021, 10:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL