Page MenuHomePhabricator
Create Task
Maniphest T291582

Implement condition agreements in Special:Preferences [M]
Closed, ResolvedPublic
Actions

Assigned To
STran
Authored By
STran
Sep 22 2021, 4:45 PM
Tags
Referenced Files
F34679451: Screen Shot 2021-10-08 at 4.18.01 PM.png
Oct 8 2021, 8:38 PM
F34679436: Screen Shot 2021-10-08 at 4.17.43 PM.png
Oct 8 2021, 8:38 PM
F34676590: Screen Shot 2021-10-05 at 11.49.57 AM.png
Oct 6 2021, 9:09 PM
F34660152: image.png
Sep 28 2021, 8:44 AM
F34660157: image.png
Sep 28 2021, 8:44 AM
F34651046: image.png
Sep 22 2021, 4:45 PM
Subscribers
Aklapper
• imaigwilo
Niharika
phuedx
• Prtksxna
STran

Description

From T264150: User needs to request access to IP information [L]

image.png (444×1 px, 39 KB)

There are two conditions that need to be met before the IP Information accordion displays information for the user:

  • User needs to enable the tool
  • User needs to accept to the terms of the tool

These are represented by two checkboxes in Special:Preferences, under the "User Profile tab" (see mock 1)

  1. Show the IP Information tool on Special:Contributions page for IP addresses.
  2. I agree to use this information for my patrolling and anti-vandalism work.

Note: The user cannot agree to the terms without enabling the tool. The second checkbox is disabled until the first checkbox is checked.

Details

SubjectRepoBranchLines +/-
Implement use agreement checkbox for IPInfo in Special:Preferencesmediawiki/extensions/IPInfomaster+138 -39
Customize query in gerrit

Related Objects
Search...

Event Timeline

STran created this task.Sep 22 2021, 4:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2021, 4:45 PM
phuedx added a parent task: T264150: User needs to request access to IP information [L].Sep 22 2021, 4:48 PM
Niharika updated the task description. (Show Details)Sep 22 2021, 4:49 PM
ARamirez_WMF renamed this task from Implement condition agreements in Special:Preferences to Implement condition agreements in Special:Preferences [M].Sep 22 2021, 4:56 PM
ARamirez_WMF moved this task from Untriaged to Cards ready for development on the Anti-Harassment board.
phuedx added a subtask: T291583: [SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases [8H].Sep 22 2021, 5:14 PM
STran claimed this task.Sep 23 2021, 8:24 AM
STran moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.
STran edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Sep 23 2021, 9:15 AM

Change 723065 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Implement use agreement checkbox for IPInfo in Special:Preferences

https://gerrit.wikimedia.org/r/723065

gerritbot added a project: Patch-For-Review.Sep 23 2021, 9:15 AM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Sep 23 2021, 9:28 AM
Niharika mentioned this in T264150: User needs to request access to IP information [L].Sep 24 2021, 5:37 AM
STran added subscribers: phuedx, • Prtksxna.Sep 28 2021, 8:44 AM

@Prtksxna Could I get some 👀 on the copy for this error message and also your opinion on the design? The ticket says to disable the use agreement checkbox if the enable checkbox has not been checked:

image.png (258×1 px, 28 KB)

@phuedx noted that hide-if is a utility provided by HTMLForm and as such, is the "default" UX for hiding/showing dependent options. Using hide-if would mean that the use agreement checkbox would only be visible if the enable checkbox is checked.

Do you have a preference between the two?

And here is the error message if you try to only agree to the use agreement:

image.png (320×1 px, 39 KB)

STran moved this task from Code Review 🔍 to Needs Design/Product 🎨 on the Anti-Harassment (The Letter Song) board.Sep 28 2021, 8:44 AM
• Prtksxna added a comment.Sep 28 2021, 3:00 PM
In T291582#7382740, @STran wrote:

@Prtksxna Could I get some 👀 on the copy for this error message and also your opinion on the design?

Design matches the spec 👍🏾 The alignments seem a bit off but I'm guessing that is OOUI?
We're waiting on legal for the final messages, will create a ticket as soon as we have them.

The ticket says to disable the use agreement checkbox if the enable checkbox has not been checked:

image.png (258×1 px, 28 KB)

And here is the error message if you try to only agree to the use agreement:
image.png (320×1 px, 39 KB)

If the checkbox is disabled, how can someone reach this state?

@phuedx noted that hide-if is a utility provided by HTMLForm and as such, is the "default" UX for hiding/showing dependent options. Using hide-if would mean that the use agreement checkbox would only be visible if the enable checkbox is checked.

Do you have a preference between the two?

Yep, we have a preference to disable instead of hiding UI elements in most cases. This way we avoid the UI jump (no animations in mw yet 🙁) and its better for a11y (hiding and showing is possible through aria tags but their support isn't universally good).

• Prtksxna added a comment.Sep 28 2021, 4:18 PM
In T291582#7384078, @Prtksxna wrote:

If the checkbox is disabled, how can someone reach this state?

@STran answered in a meeting - no-JS.

Everything looks good, then 👍🏾

phuedx added a comment.Sep 28 2021, 5:57 PM
In T291582#7384078, @Prtksxna wrote:

@phuedx noted that hide-if is a utility provided by HTMLForm and as such, is the "default" UX for hiding/showing dependent options. Using hide-if would mean that the use agreement checkbox would only be visible if the enable checkbox is checked.

Do you have a preference between the two?

Yep, we have a preference to disable instead of hiding UI elements in most cases. This way we avoid the UI jump (no animations in mw yet 🙁) and its better for a11y (hiding and showing is possible through aria tags but their support isn't universally good).

I defer to your expertise and domain knowledge. Is there a task tracking migrating away from conditional hide/reveal of UI elements in forms? If not, should we create one?

STran moved this task from Needs Design/Product 🎨 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Sep 29 2021, 8:04 AM
phuedx moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Oct 4 2021, 6:10 PM
gerritbot added a comment.Oct 4 2021, 6:29 PM

Change 723065 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Implement use agreement checkbox for IPInfo in Special:Preferences

https://gerrit.wikimedia.org/r/723065

STran mentioned this in rEIPIa4b9f85578e7: Implement use agreement checkbox for IPInfo in Special:Preferences.Oct 4 2021, 6:29 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 4 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2021, 7:10 PM
• imaigwilo subscribed.EditedOct 6 2021, 9:09 PM

Verified that IP info box shows on the page after.
updated page ur: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences
Screen shot of IP Info:

Screen Shot 2021-10-08 at 4.17.43 PM.png (1×3 px, 1 MB)

Screen Shot 2021-10-08 at 4.18.01 PM.png (1×2 px, 315 KB)

phuedx closed subtask T291583: [SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases [8H] as Resolved.Oct 7 2021, 10:54 AM
phuedx mentioned this in T292755: Epic: IP Info access.Oct 7 2021, 3:03 PM
Niharika subscribed.Oct 8 2021, 6:38 PM
In T291582#7406922, @imaigwilo wrote:

Verified that IP info box shows on the page after.
updated page ur:
Screen shot of IP Info:

I think this is missing the screenshots, @imaigwilo. But I can move it along on your word!

• imaigwilo added a comment.Oct 8 2021, 8:39 PM

@Niharika pardon me, I have added the screen shots now it works as expected. Thank you.

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Oct 8 2021, 8:40 PM
Niharika closed this task as Resolved.Oct 9 2021, 1:23 AM
phuedx mentioned this in T295306: Review all Resource Loader module definitions for case-sensitivity issues [4H].Dec 14 2021, 3:29 PM
Tchanders mentioned this in T304430: Use localStorage instead of a user preference for saving whether the infobox is expanded or collapsed.Mar 22 2022, 3:25 PM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL